-
Notifications
You must be signed in to change notification settings - Fork 3
Update template content #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template content #26
Conversation
|
||
private getHello() { | ||
return 'Hello' | ||
return `Hello, ${name}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears the template, even for the starter version, does not have semicolons, so that's what we want. Just want to test that this works once a project is init
from the starter template. If not, it may require adding prettier config to the starter template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - I formatted it according to the prettier
config in the production template. I don't believe the starter template ships with eslint/prettier, pretty sure that's a setting passed in from the algokit CLI? If changes are needed here, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can test the output of this template if you run algokit -v init --name playground --no-git --UNSAFE-SECURITY-accept-template-url --template-url . --template-url-ref HEAD --no-bootstrap
from the root of this repo btw. :)
Proposed Changes
localnet.beforeEach
tolocalnet.newScope
since it's marked deprecated)