Add tests for Google Places Search and Details fields

Author: czlee

test/unit/lookups/google_places_details_test.rb

@@ -81,6 +81,39 @@ def test_google_places_details_query_url_always_uses_https
     assert_match(%r(^https://), url)
   end
 
+  def test_google_places_details_query_url_omits_fields_by_default
+    url = lookup.query_url(Geocoder::Query.new("some-place-id"))
+    assert_no_match(/fields=/, url)
+  end
+
+  def test_google_places_details_query_url_contains_specific_fields_when_given
+    fields = %w[formatted_address place_id]
+    url = lookup.query_url(Geocoder::Query.new("some-place-id", fields: fields))
+    assert_match(/fields=#{fields.join('%2C')}/, url)
+  end
+
+  def test_google_places_details_query_url_contains_specific_fields_when_configured
+    fields = %w[business_status geometry photos]
+    Geocoder.configure(google_places_details: {fields: fields})
+    url = lookup.query_url(Geocoder::Query.new("some-place-id"))
+    assert_match(/fields=#{fields.join('%2C')}/, url)
+    Geocoder.configure(google_places_details: {})
+  end
+
+  def test_google_places_details_query_url_omits_fields_when_nil_given
+    Geocoder.configure(google_places_details: {fields: %w[business_status geometry photos]})
+    url = lookup.query_url(Geocoder::Query.new("some-place-id", fields: nil))
+    assert_no_match(/fields=/, url)
+    Geocoder.configure(google_places_details: {})
+  end
+
+  def test_google_places_details_query_url_omits_fields_when_nil_configured
+    Geocoder.configure(google_places_details: {fields: nil})
+    url = lookup.query_url(Geocoder::Query.new("some-place-id"))
+    assert_no_match(/fields=/, url)
+    Geocoder.configure(google_places_details: {})
+  end
+
   def test_google_places_details_result_with_no_reviews_shows_empty_reviews
     assert_equal no_reviews_result.reviews, []
   end

test/unit/lookups/google_places_search_test.rb

@@ -63,6 +63,26 @@ def test_google_places_search_query_url_contains_specific_fields_when_given
     assert_match(/fields=#{fields.join('%2C')}/, url)
   end
 
+  def test_google_places_search_query_url_contains_specific_fields_when_configured
+    fields = %w[business_status geometry photos]
+    Geocoder.configure(google_places_search: {fields: fields})
+    url = lookup.query_url(Geocoder::Query.new("some-address"))
+    assert_match(/fields=#{fields.join('%2C')}/, url)
+    Geocoder.configure(google_places_search: {})
+  end
+
+  def test_google_places_search_query_url_omits_fields_when_nil_given
+    url = lookup.query_url(Geocoder::Query.new("some-address", fields: nil))
+    assert_no_match(/fields=/, url)
+  end
+
+  def test_google_places_search_query_url_omits_fields_when_nil_configured
+    Geocoder.configure(google_places_search: {fields: nil})
+    url = lookup.query_url(Geocoder::Query.new("some-address"))
+    assert_no_match(/fields=/, url)
+    Geocoder.configure(google_places_search: {})
+  end
+
   def test_google_places_search_query_url_uses_find_place_service
     url = lookup.query_url(Geocoder::Query.new("some-address"))
     assert_match(%r{//maps.googleapis.com/maps/api/place/findplacefromtext/}, url)