PS-920 catch all integration errors (#632)

Author: 4rthem

databox/api/src/Api/OutputTransformer/WorkspaceIntegrationOutputTransformer.php

@@ -81,10 +81,17 @@ public function transform(object $data, string $outputClass, array &$context = [
             $output->setData($subData);
         }
 
-        $config = $this->integrationManager->getIntegrationConfiguration($data);
-        $integration = $config->getIntegration();
-        $output->integrationTitle = $integration->getTitle();
-        $output->setConfig($integration->resolveClientConfiguration($data, $config));
+        try {
+            $config = $this->integrationManager->getIntegrationConfiguration($data);
+            $integration = $config->getIntegration();
+            $output->integrationTitle = $integration->getTitle();
+            $output->setConfig($integration->resolveClientConfiguration($data, $config));
+        } catch (\Throwable $e) {
+            $output->lastErrors ??= [];
+            $output->lastErrors[] = [
+                'message' => $e->getMessage(),
+            ];
+        }
 
         if ($this->isGranted(AbstractVoter::EDIT, $data)) {
             $output->configYaml = Yaml::dump($data->getConfig(), 4);

databox/api/src/Entity/Core/AttributeDefinition.php

@@ -564,4 +564,9 @@ public function validateInitialValues(ExecutionContextInterface $context): void
             }
         }
     }
+
+    public function getOwnerId(): ?string
+    {
+        return $this->getWorkspace()?->getOwnerId();
+    }
 }

databox/api/src/Entity/Traits/ErrorDisableInterface.php

@@ -18,5 +18,9 @@ public function getErrorCount(): int;
 
     public function disableAfterErrors(): void;
 
+    public function isEnabled(): bool;
+
     public function getWorkspace(): ?Workspace;
+
+    public function getOwnerId(): ?string;
 }

databox/api/src/Integration/Aws/Rekognition/AwsRekognitionIntegration.php

@@ -17,6 +17,7 @@
 use App\Integration\UserActionsIntegrationInterface;
 use App\Integration\WorkflowHelper;
 use App\Integration\WorkflowIntegrationInterface;
+use App\Notification\EntityDisableNotifyableException;
 use App\Storage\RenditionManager;
 use App\Workflow\Event\AssetIngestWorkflowEvent;
 use Symfony\Component\Config\Definition\Builder\NodeBuilder;
@@ -189,8 +190,12 @@ public function getNeededJobs(IntegrationConfig $config, IntegrationConfig $need
         }
 
         if ($neededIntegrationConfig->getIntegration() instanceof RenditionIntegration) {
-            $renditionDefinition = $this->renditionManager
-                ->getRenditionDefinitionByName($neededIntegrationConfig->getWorkspaceId(), $rendition);
+            try {
+                $renditionDefinition = $this->renditionManager
+                    ->getRenditionDefinitionByName($neededIntegrationConfig->getWorkspaceId(), $rendition);
+            } catch (\InvalidArgumentException $e) {
+                throw new EntityDisableNotifyableException($config->getWorkspaceIntegration(), sprintf('Rendition "%s" not found', $rendition), sprintf('Rendition "%s" not found in workspace "%s"', $rendition, $neededIntegrationConfig->getWorkspaceIntegration()->getWorkspace()->getName()), $e->getCode(), $e);
+            }
 
             return [
                 RenditionIntegration::getJobId(

databox/api/src/Notification/EntityDisableNotifyableException.php

@@ -17,7 +17,7 @@ public function __construct(
         $workspace = $this->entity->getWorkspace();
 
         parent::__construct(
-            $workspace?->getOwnerId(),
+            $this->entity->getOwnerId(),
             $subject,
             $message.($appendWorkspace && $workspace ? ' (in workspace: '.$workspace?->getName().')' : ''),
             $code,

databox/api/src/Notification/ExceptionNotifier.php

@@ -15,15 +15,19 @@ public function __construct(
 
     public function notifyException(UserNotifyableException $exception): void
     {
+        if ($exception instanceof EntityDisableNotifyableException) {
+            if (!$exception->getEntity()->isEnabled()) {
+                return;
+            }
+
+            $this->errorDisableHandler->handleError($exception->getEntity(), $exception);
+        }
+
         foreach ($exception->getSubscribers() as $subscriber) {
             $this->notifier->notifyUser($subscriber, $exception->getNotificationId(), [
                 'subject' => $exception->getSubject(),
                 'message' => $exception->getMessage(),
             ]);
         }
-
-        if ($exception instanceof EntityDisableNotifyableException) {
-            $this->errorDisableHandler->handleError($exception->getEntity(), $exception);
-        }
     }
 }

databox/api/src/Workflow/IntegrationWorkflowRepository.php

@@ -13,7 +13,10 @@
 use App\Integration\FilterNeedIntegrationInterface;
 use App\Integration\IntegrationManager;
 use App\Integration\WorkflowIntegrationInterface;
+use App\Notification\ExceptionNotifier;
+use App\Notification\UserNotifyableException;
 use Doctrine\ORM\EntityManagerInterface;
+use Psr\Log\LoggerInterface;
 
 final readonly class IntegrationWorkflowRepository implements WorkflowRepositoryInterface
 {
@@ -30,6 +33,8 @@ public function __construct(
         private EntityManagerInterface $em,
         private IntegrationManager $integrationManager,
         private WorkflowRepositoryInterface $decorated,
+        private ExceptionNotifier $exceptionNotifier,
+        private LoggerInterface $logger,
     ) {
     }
 
@@ -126,7 +131,16 @@ private function createIntegrationsToWorkflow(Workflow $workflow, string $worksp
 
                     $neededJobs = null;
                     if ($integration instanceof FilterNeedIntegrationInterface && null !== $neededConfig) {
-                        $neededJobs = $integration->getNeededJobs($config, $neededConfig, $job);
+                        try {
+                            $neededJobs = $integration->getNeededJobs($config, $neededConfig, $job);
+                        } catch (UserNotifyableException $e) {
+                            $this->exceptionNotifier->notifyException($e);
+                        } catch (\Exception $e) {
+                            $this->logger->alert(
+                                sprintf('Error while getting needed jobs for integration "%s"', $workspaceIntegration->getWorkspaceId()),
+                                ['exception' => $e]
+                            );
+                        }
                     }
 
                     foreach ($jobMap[$workspaceIntegration->getId()] as $j) {