You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 9, 2023. It is now read-only.
I'm starting to set up hypernova in a Rails + Webpack repository.
By importing the hypernova server module, it seems my globals are polluted.
The only difference in my script is the following line:
const hypernova = require('hypernova/server');
which produces the following error trace:
yarn run v1.6.0
$ node script/hypernova.js
/Users/juanca/workspace/project/node_modules/html-webpack-plugin/index.js:10
Promise.promisifyAll(fs);
^
TypeError: Promise.promisifyAll is not a function
at Object.<anonymous> (/Users/juanca/workspace/project/node_modules/html-webpack-plugin/index.js:10:9)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/Users/juanca/workspace/project/config/helpers/generate-error-pages.js:4:27)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
While the error is not in the hypernova source, it is being caused by a hypernova module -- since it works without processing the module.
I was wondering whether this is true, whether this is fixable, whether this is intended, etc. I would be happy to make a PR if it is an acceptable improvement: removing dependencies on the global Promise object.