Merge pull request #30 from ainame/github-action-release

Support matrix tests and deployment in GitHub action properly

Author: ainame

.github/workflows/deploy.yml

@@ -0,0 +1,31 @@
+name: Deploy prebuilt-framework for Carthage when tagged
+on:
+  push:
+    tags:
+      - '*'
+jobs:
+  deploy:
+    name: Deploy built-framework to GitHub releases
+    runs-on: macOS-latest
+    strategy:
+      matrix:
+        framework: [WebP]
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v1
+      - name: Archive prebuilt framework with Carthage
+        run: |
+          set -o pipefail
+          brew update
+          brew outdated carthage || brew upgrade carthage
+          git submodule update -i
+          carthage build --no-skip-current
+          carthage archive ${{ matrix.framework }}
+      - name: Upload built framework to GitHub Release
+        uses: svenstaro/upload-release-action@v1-release
+        with:
+          file: '${{ matrix.framework }}.framework.zip'
+          asset_name: '${{ matrix.framework }}.framework.zip'
+          tag: ${{ github.ref }}
+          overwrite: true
+          repo_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pr.yml

@@ -0,0 +1,43 @@
+name: PR checks
+on: [pull_request]
+jobs:
+  run_tests:
+    strategy:
+      matrix:
+        # os: [macOS-latest, ubuntu-18.04]
+        os: [macOS-latest]
+        platform: [iOS, macOS, SPM]
+        include:
+          - platform: iOS
+            destination: OS=latest,name=iPhone 8
+            scheme: WebP iOS
+            workspace: WebP.xcworkspace
+            sdk: iphonesimulator
+          - platform: macOS
+            destination: platform=OS X,arch=x86_64
+            scheme: WebP macOS
+            workspace: WebP.xcworkspace
+            sdk: macosx10.14
+         # exclude:
+         #   - os: ubuntu-18.04
+         #     platform: iOS
+         #   - os: ubuntu-18.04
+         #     platform: macOS
+    name: Run Tests
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v1
+      - name: Run Tests with xcodebuild
+        if: matrix.platform != 'SPM'
+        run: ./.github/bin/test.sh
+        env:
+          DESTINATION: ${{ matrix.destination }}
+          SCHEME: ${{ matrix.scheme }}
+          WORKSPACE: ${{ matrix.workspace }}
+          SDK: ${{ matrix.sdk }}
+      - name: Build package with swift package manager
+        if: matrix.platform == 'SPM'
+        run: |
+          set -o pipefail
+          brew install pkg-config webp
+          swift test

.github/workflows/push.yml

@@ -1,51 +1,21 @@
 language: objective-c
-osx_image: xcode10.2
+osx_image: xcode10.3
 env:
   global:
     - LC_CTYPE=en_US.UTF-8
     - LANG=en_US.UTF-8
     - WORKSPACE="WebP.xcworkspace"
-    - IOS_FRAMEWORK_SCHEME="WebP iOS"
-    - MACOS_FRAMEWORK_SCHEME="WebP macOS"
-    - IOS_SDK=iphonesimulator12.2
-    - MAC_OS_SDK="macosx10.14"
-    - FRAMEWORK_NAME="WebP"
   matrix:
-    # Deploy new built-framework during iOS's build
-    - DEPLOY=true EXAMPLE_SCHEME="iOS Example" DESTINATION="OS=latest,name=iPhone X" SCHEME="$IOS_FRAMEWORK_SCHEME" SDK="$IOS_SDK"
-    - EXAMPLE_SCHEME="macOS Example" DESTINATION="platform=OS X,arch=x86_64" SCHEME="$MACOS_FRAMEWORK_SCHEME" SDK="$MAC_OS_SDK"
+    - DESTINATION="OS=latest,name=iPhone X" SCHEME="WebP iOS" SDK="iphonesimulator"
+    - DESTINATION="platform=OS X,arch=x86_64" SCHEME="WebP macOS" SDK="macosx10.14"
 cache:
   directories:
     - $HOME/Library/Caches/Homebrew
 before_cache:
   - brew cleanup
 before_install:
   - brew install webp
-before_deploy:
-  - brew update
-  - brew outdated carthage || brew upgrade carthage
-  - carthage build --no-skip-current
-  - carthage archive $FRAMEWORK_NAME
 script:
-  - set -o pipefail
-  - xcrun simctl list
-  - xcodebuild -version
-  - xcodebuild -showsdks
-  - xcodebuild -list
-  - xcodebuild -workspace "$WORKSPACE" -list
-  - xcodebuild -workspace "$WORKSPACE" -scheme "$SCHEME" -sdk "$SDK" -destination "$DESTINATION" -configuration Debug ONLY_ACTIVE_ARCH=NO clean test | xcpretty
-  - xcodebuild -workspace "$WORKSPACE" -scheme "$SCHEME" -sdk "$SDK" -destination "$DESTINATION" -configuration ReleaseTest ONLY_ACTIVE_ARCH=NO clean build | xcpretty
-  - xcodebuild -workspace "$WORKSPACE" -scheme "$EXAMPLE_SCHEME" -sdk "$SDK" -destination "$DESTINATION" -configuration Debug ONLY_ACTIVE_ARCH=NO clean build | xcpretty
-  - swift build
+  - .github/bin/test.sh
 notifications:
   email: false
-deploy:
-  provider: releases
-  api_key:
-    secure: vYi+DMk6Pswlw/J0O1zkXfelAL9dcPmb4D6vnkzcTy4FUN7oiezoG/dZJ4IVD0XNb0hZqkXSsdNsWs0oenRdBhk/05t0eexQudjtKbCANRPaTpraLrBIZyw4l7/QXpC34MuENWS+G0D6Tvgi5v/dyByTnoa5UuPTtT5F40oNFOlLnWn3XSngROFhdXAXxbGtT5XB3vP4V45z1x8fHbDRqVvBa3UC0PBhOm0kQqm9nWa8kjfsx3d+e4G236egi+fnKfu4B0sU68lp6GIHgVtHhrYKYfU+uvxn3ZEcgxupL7cz+J2Z90ar1ORmHex7LeFP/41PvLZ1SGfUSvb1812oCntKLix5h9LJiQw4SR8+4TZGF51YHf5nPBsWyUqKBEAaRKCMc9BETZ7dj5nhC8gqtrcRLm36tNgVetDIGxfFpSTXvbFQMgRxFM1vOTjk4Gis+tYdDZ0/a7U86t6k7WWLMVcZsD1Ezx08b5R1xv/FUYS+N2WW/R2OkBOUrquHeXuWK1wppStcYJ2zwKmYbtMhE2Xo9WS/+S64YY8wW9qx2daq5/el3SOarzGmPzQdl6VsYX2YAsGbFOyFCurOpMK+SBSAhlNIgOuyzhMnWaEk8YfRfAFQLvr7evMO/YMuxV3dAR5IiO9mKjUhBDsDIxKHSG3p6m5X9pw1joM+yQJfNLE=
-  file: "$FRAMEWORK_NAME.framework.zip"
-  skip_cleanup: true
-  on:
-    repo: ainame/Swift-WebP
-    tags: true
-    condition: $DEPLOY = true

.travis.yml

@@ -24,8 +24,21 @@ class WebPEncoderMacOSTests: XCTestCase {
     }
 
     func testExample() throws {
-        let path = Bundle(for: self.classForCoder).resourcePath!.appendingFormat("/jiro.jpg")
-        let nsImage = NSImage(contentsOfFile: path)!
+        let currentFileURL = URL(fileURLWithPath: String(#file))
+        let imagePath = currentFileURL.deletingLastPathComponent()
+            .deletingLastPathComponent()
+            .deletingLastPathComponent()
+            .appendingPathComponent("iOS Example")
+            .appendingPathComponent("Resources")
+            .appendingPathComponent("jiro.jpg", isDirectory: false)
+            .path
+
+        guard FileManager.default.fileExists(atPath: imagePath) else {
+            XCTFail("Image couldn't be found at \(imagePath)")
+            return
+        }
+
+        let nsImage = NSImage(contentsOfFile: imagePath)!
         let encoder = WebPEncoder()
         let data = try encoder.encode(nsImage, config: .preset(.photo, quality: 10))
         XCTAssertTrue(data.count > 0)

Tests/CheckCocoaPodsQualityIndexes.rb

@@ -1487,6 +1487,7 @@
 				PRODUCT_NAME = WebP;
 				SDKROOT = macosx;
 				SKIP_INSTALL = YES;
+				SUPPORTED_PLATFORMS = macosx;
 				SWIFT_INCLUDE_PATHS = "$(SRCROOT)/Sources";
 				SWIFT_SWIFT3_OBJC_INFERENCE = Default;
 				SWIFT_VERSION = 5.0;
@@ -1510,7 +1511,9 @@
 				OTHER_LDFLAGS = "-all_load";
 				PRODUCT_BUNDLE_IDENTIFIER = me.ainam.WebP.macos;
 				PRODUCT_NAME = WebP;
+				SDKROOT = macosx;
 				SKIP_INSTALL = YES;
+				SUPPORTED_PLATFORMS = macosx;
 				SWIFT_INCLUDE_PATHS = "$(SRCROOT)/Sources";
 				SWIFT_SWIFT3_OBJC_INFERENCE = Default;
 				SWIFT_VERSION = 5.0;

Tests/LinuxMain.swift

@@ -27,6 +27,15 @@
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       shouldUseLaunchSchemeArgsEnv = "YES">
+      <MacroExpansion>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "BD5FC4CF1DB3EE2B000A0A38"
+            BuildableName = "WebP.framework"
+            BlueprintName = "WebP macOS"
+            ReferencedContainer = "container:WebP.xcodeproj">
+         </BuildableReference>
+      </MacroExpansion>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -39,17 +48,6 @@
             </BuildableReference>
          </TestableReference>
       </Testables>
-      <MacroExpansion>
-         <BuildableReference
-            BuildableIdentifier = "primary"
-            BlueprintIdentifier = "BD5FC4CF1DB3EE2B000A0A38"
-            BuildableName = "WebP.framework"
-            BlueprintName = "WebP macOS"
-            ReferencedContainer = "container:WebP.xcodeproj">
-         </BuildableReference>
-      </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </TestAction>
    <LaunchAction
       buildConfiguration = "Debug"
@@ -70,8 +68,6 @@
             ReferencedContainer = "container:WebP.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
-      <AdditionalOptions>
-      </AdditionalOptions>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"