Skip to content

Move `yes and `no to Reflection.Syntax #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

Conversation

WhatisRT
Copy link
Collaborator

These are generally useful for writing things involving Dec, so they should live in a more accessible place.

@WhatisRT WhatisRT requested a review from omelkonian June 25, 2025 09:36
@omelkonian
Copy link
Collaborator

I don't think that's the way to go with these things, due to the Fairbairn threshold: we cannot provide quoted version of every possible term in stdlib, hence why we define shorthands locally only when we need them (e.g. yes/no when deriving DecEq).

If it happens that multiple tactics work on, say, decidability proofs, it would make sense to keep a common score file just for this subset of tactics (e.g. living under Tactics.Dec.Core).

@WhatisRT
Copy link
Collaborator Author

I generally agree, but I think in this case it's an exception because it has so many potential use cases. Other examples I can think of are quoted equality and a quoted case_of_. These are just too useful not to share.

I do think that maybe this module is not the best place, but this library should get a proper reorganization anyway and I didn't want to spend too much time thinking about it right now.

@omelkonian
Copy link
Collaborator

But shouldn't we follow a more pull-based/on-demand approach, only introducing shorthands that have at least more than 1 use?

@WhatisRT
Copy link
Collaborator Author

You're right. In this case there are downstream use cases. They currently aren't relevant, but if something was useful in the past I think it's a good indication that it would be useful in the future.

I'll be a bit less lazy and add a few things & move them to a better location.

@omelkonian omelkonian merged commit 3f21999 into master Jun 30, 2025
1 check passed
@omelkonian omelkonian deleted the andre/move-quoted-yes-no branch June 30, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants