Skip to content

Commit e839a50

Browse files
authored
Remove unused width and height properties from flat and standard shaders (#5647)
1 parent 38d7e9f commit e839a50

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

src/shaders/flat.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,9 @@ export var Shader = registerShader('flat', {
99
schema: {
1010
color: {type: 'color'},
1111
fog: {default: true},
12-
height: {default: 256},
1312
offset: {type: 'vec2', default: {x: 0, y: 0}},
1413
repeat: {type: 'vec2', default: {x: 1, y: 1}},
1514
src: {type: 'map'},
16-
width: {default: 512},
1715
wireframe: {default: false},
1816
wireframeLinewidth: {default: 2},
1917
toneMapped: {default: true}

src/shaders/standard.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export var Shader = registerShader('standard', {
2626
envMap: {default: ''},
2727

2828
fog: {default: true},
29-
height: {default: 256},
3029

3130
metalness: {default: 0.0, min: 0.0, max: 1.0},
3231
metalnessMap: {type: 'map'},
@@ -48,7 +47,6 @@ export var Shader = registerShader('standard', {
4847

4948
sphericalEnvMap: {type: 'map'},
5049
src: {type: 'map'},
51-
width: {default: 512},
5250
wireframe: {default: false},
5351
wireframeLinewidth: {default: 2}
5452
},

tests/components/material.test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,8 @@ suite('material', function () {
212212
el.components.material.updateSchema({shader: 'flat'});
213213
assert.ok(el.components.material.schema.color);
214214
assert.ok(el.components.material.schema.fog);
215-
assert.ok(el.components.material.schema.height);
216215
assert.ok(el.components.material.schema.repeat);
217216
assert.ok(el.components.material.schema.src);
218-
assert.ok(el.components.material.schema.width);
219217
assert.notOk(el.components.material.schema.metalness);
220218
assert.notOk(el.components.material.schema.roughness);
221219
assert.notOk(el.components.material.schema.envMap);

0 commit comments

Comments
 (0)