Skip to content

Commit d49ddaa

Browse files
Webxr unit tests (#5227)
* Initial version of WebXR tests, running on Chrome * Don't run tests when navigator.xr is not available (e.g. on Firefox) * Adjust formatting per PR feedback
1 parent a2e350e commit d49ddaa

File tree

3 files changed

+498
-21
lines changed

3 files changed

+498
-21
lines changed

src/core/scene/a-scene.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ class AScene extends AEntity {
116116
this.pointerRestrictedBound = function () { self.pointerRestricted(); };
117117
this.pointerUnrestrictedBound = function () { self.pointerUnrestricted(); };
118118

119-
if (!isWebXRAvailable) {
119+
if (!self.hasWebXR) {
120120
// Exit VR on `vrdisplaydeactivate` (e.g. taking off Rift headset).
121121
window.addEventListener('vrdisplaydeactivate', this.exitVRBound);
122122

@@ -355,7 +355,7 @@ class AScene extends AEntity {
355355
}
356356
self.emit('enter-vr', {target: self});
357357
// Lock to landscape orientation on mobile.
358-
if (!isWebXRAvailable && self.isMobile && screen.orientation && screen.orientation.lock) {
358+
if (!self.hasWebXR && self.isMobile && screen.orientation && screen.orientation.lock) {
359359
screen.orientation.lock('landscape');
360360
}
361361
self.addFullScreenStyles();

tests/__init.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,11 @@ setup(function () {
3737
getDevice: function () { return {requestPresent: function () {}}; },
3838
isPresenting: function () { return true; },
3939
setDevice: function () {},
40+
setSession: function () { return Promise.resolve(); },
4041
setFoveation: function () {},
4142
setPoseTarget: function () {},
4243
dispose: function () {},
44+
setReferenceSpaceType: function () {},
4345
enabled: false
4446
},
4547
dispose: function () {},

0 commit comments

Comments
 (0)