Add SimpleCookie compatibility import fixer (#537)

Fixes #535

---------

Co-authored-by: Adam Johnson <[email protected]>

Author: UnknownPlatypus

CHANGELOG.rst

@@ -2,6 +2,10 @@
 Changelog
 =========
 
+* Add Django 2.0+ compatibility import rewrite of `django.http.cookie.SimpleCookie` to `http.cookies.SimpleCookie`.
+
+  Thanks to Thibaut Decombe in `PR #537 <https://github.com/adamchainz/django-upgrade/pull/537>`__.
+
 1.23.1 (2025-02-07)
 -------------------
 

README.rst

@@ -976,28 +976,28 @@ Thus, you should test affected paths after this fixer makes any changes.
 Note that ``[\w-]`` is sometimes used for slugs, but is not converted because it might be incompatible.
 That pattern matches all Unicode word characters, such as “α”, unlike Django's ``slug`` converter, which only matches Latin characters.
 
-``lru_cache``
-~~~~~~~~~~~~~
+Compatibility imports
+~~~~~~~~~~~~~~~~~~~~~
 
 **Name:** ``compatibility_imports``
 
-Rewrites imports of ``lru_cache`` from ``django.utils.functional`` to use ``functools``.
+Rewrites some compatibility imports:
+
+* ``lru_cache`` from ``django.utils.functional`` to use ``functools``.
+* ``ContextDecorator`` from ``django.utils.decorators`` to use ``contextlib``
+* ``SimpleCookie`` from ``django.http.cookie`` to use ``http.cookies``
 
 .. code-block:: diff
 
     -from django.utils.functional import lru_cache
     +from functools import lru_cache
 
-``ContextDecorator``
-~~~~~~~~~~~~~~~~~~~~
-
-Rewrites imports of ``ContextDecorator`` from ``django.utils.decorators`` to use ``contextlib``.
-
-.. code-block:: diff
-
     -from django.utils.decorators import ContextDecorator
     +from contextlib import ContextDecorator
 
+    -from django.http.cookie import SimpleCookie
+    +from http.cookies import SimpleCookie
+
 ``<func>.allow_tags = True``
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

src/django_upgrade/fixers/compatibility_imports.py

@@ -1,18 +1,3 @@
-"""
-- Replace compatibility imports for
-    - `django.core.exceptions.EmptyResultSet`
-    - `django.core.exceptions.FieldDoesNotExist`
-    - `django.forms.utils.pretty_name`
-    - `django.forms.boundfield.BoundField`
-  See https://docs.djangoproject.com/en/3.1/releases/3.1/#id1
-
-- Replace `JSONField` imports:
-  See https://docs.djangoproject.com/en/3.1/releases/3.1/#features-deprecated-in-3-1
-
-- Replace `django.utils.functional.lru_cache` with `functools.lru_cache`
-  Undocumented change
-"""
-
 from __future__ import annotations
 
 import ast
@@ -108,6 +93,7 @@
     (2, 0): {
         "django.utils.functional": {"lru_cache": "functools"},
         "django.utils.decorators": {"ContextDecorator": "contextlib"},
+        "django.http.cookie": {"SimpleCookie": "http.cookies"},
     },
     (3, 1): {
         "django.contrib.postgres.forms": {

tests/fixers/test_compatibility_imports.py

@@ -330,6 +330,7 @@ def test_exception_class_imported_as_other_name(self):
 def test_all_transformed():
     check_transformed(
         """\
+        from django.http.cookie import SimpleCookie
         from django.forms.forms import pretty_name
         from django.forms.forms import BoundField
         from django.db.models.fields import FieldDoesNotExist
@@ -341,6 +342,7 @@ def test_all_transformed():
         from django.contrib.postgres.forms.jsonb import JSONField
         """,
         """\
+        from http.cookies import SimpleCookie
         from django.forms.utils import pretty_name
         from django.forms.boundfield import BoundField
         from django.core.exceptions import FieldDoesNotExist