Skip to content

Commit 791aee1

Browse files
adam900710adam900710
committed
btrfs: do proper folio cleanup when cow_file_range() failed
[BUG] When testing with COW fixup marked as BUG_ON() (this is involved with the new pin_user_pages*() change, which should not result new out-of-band dirty pages), I hit a crash triggered by the BUG_ON() from hitting COW fixup path. This BUG_ON() happens just after a failed btrfs_run_delalloc_range(): BTRFS error (device dm-2): failed to run delalloc range, root 348 ino 405 folio 65536 submit_bitmap 6-15 start 90112 len 106496: -28 ------------[ cut here ]------------ kernel BUG at fs/btrfs/extent_io.c:1444! Internal error: Oops - BUG: 00000000f2000800 [#1] SMP CPU: 0 UID: 0 PID: 434621 Comm: kworker/u24:8 Tainted: G OE 6.12.0-rc7-custom+ torvalds#86 Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/2022 Workqueue: events_unbound btrfs_async_reclaim_data_space [btrfs] pc : extent_writepage_io+0x2d4/0x308 [btrfs] lr : extent_writepage_io+0x2d4/0x308 [btrfs] Call trace: extent_writepage_io+0x2d4/0x308 [btrfs] extent_writepage+0x218/0x330 [btrfs] extent_write_cache_pages+0x1d4/0x4b0 [btrfs] btrfs_writepages+0x94/0x150 [btrfs] do_writepages+0x74/0x190 filemap_fdatawrite_wbc+0x88/0xc8 start_delalloc_inodes+0x180/0x3b0 [btrfs] btrfs_start_delalloc_roots+0x174/0x280 [btrfs] shrink_delalloc+0x114/0x280 [btrfs] flush_space+0x250/0x2f8 [btrfs] btrfs_async_reclaim_data_space+0x180/0x228 [btrfs] process_one_work+0x164/0x408 worker_thread+0x25c/0x388 kthread+0x100/0x118 ret_from_fork+0x10/0x20 Code: aa1403e1 9402f3ef aa1403e0 9402f36f (d4210000) ---[ end trace 0000000000000000 ]--- [CAUSE] That failure is mostly from cow_file_range(), where we can hit -ENOSPC. Although the -ENOSPC is already a bug related to our space reservation code, let's just focus on the error handling. For example, we have the following dirty range [0, 64K) of an inode, with 4K sector size and 4K page size: 0 16K 32K 48K 64K |///////////////////////////////////////| |#######################################| Where |///| means page are still dirty, and |###| means the extent io tree has EXTENT_DELALLOC flag. - Enter extent_writepage() for page 0 - Enter btrfs_run_delalloc_range() for range [0, 64K) - Enter cow_file_range() for range [0, 64K) - Function btrfs_reserve_extent() only reserved one 16K extent So we created extent map and ordered extent for range [0, 16K) 0 16K 32K 48K 64K |////////|//////////////////////////////| |<- OE ->|##############################| And range [0, 16K) has its delalloc flag cleared. But since we haven't yet submit any bio, involved 4 pages are still dirty. - Function btrfs_reserve_extent() return with -ENOSPC Now we have to run error cleanup, which will clear all EXTENT_DELALLOC* flags and clear the dirty flags for the remaining ranges: 0 16K 32K 48K 64K |////////| | | | | Note that range [0, 16K) still has their pages dirty. - Some time later, writeback are triggered again for the range [0, 16K) since the page range still have dirty flags. - btrfs_run_delalloc_range() will do nothing because there is no EXTENT_DELALLOC flag. - extent_writepage_io() find page 0 has no ordered flag Which falls into the COW fixup path, triggering the BUG_ON(). Unfortunately this error handling bug dates back to the introduction of btrfs. Thankfully with the abuse of cow fixup, at least it won't crash the kernel. [FIX] Instead of immediately unlock the extent and folios, we keep the extent and folios locked until either erroring out or the whole delalloc range finished. When the whole delalloc range finished without error, we just unlock the whole range with PAGE_SET_ORDERED (and PAGE_UNLOCK for !keep_locked cases), with EXTENT_DELALLOC and EXTENT_LOCKED cleared. And those involved folios will be properly submitted, with their dirty flags cleared during submission. For the error path, it will be a little more complex: - The range with ordered extent allocated (range (1)) We only clear the EXTENT_DELALLOC and EXTENT_LOCKED, as the remaining flags are cleaned up by btrfs_mark_ordered_io_finished()->btrfs_finish_one_ordered(). For folios we finish the IO (clear dirty, start writeback and immediately finish the writeback) and unlock the folios. - The range with reserved extent but no ordered extent (range(2)) - The range we never touched (range(3)) For both range (2) and range(3) the behavior is not changed. Now even if cow_file_range() failed halfway with some successfully reserved extents/ordered extents, we will keep all folios clean, so there will be no future writeback triggered on them. Cc: [email protected] Reviewed-by: Boris Burkov <[email protected]> Signed-off-by: Qu Wenruo <[email protected]>
1 parent 45019a3 commit 791aee1

File tree

1 file changed

+32
-33
lines changed

1 file changed

+32
-33
lines changed

‎fs/btrfs/inode.c

Lines changed: 32 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,6 +1364,17 @@ static noinline int cow_file_range(struct btrfs_inode *inode,
13641364

13651365
alloc_hint = btrfs_get_extent_allocation_hint(inode, start, num_bytes);
13661366

1367+
/*
1368+
* We're not doing compressed IO, don't unlock the first page
1369+
* (which the caller expects to stay locked), don't clear any
1370+
* dirty bits and don't set any writeback bits
1371+
*
1372+
* Do set the Ordered (Private2) bit so we know this page was
1373+
* properly setup for writepage.
1374+
*/
1375+
page_ops = (keep_locked ? 0 : PAGE_UNLOCK);
1376+
page_ops |= PAGE_SET_ORDERED;
1377+
13671378
/*
13681379
* Relocation relies on the relocated extents to have exactly the same
13691380
* size as the original extents. Normally writeback for relocation data
@@ -1423,6 +1434,10 @@ static noinline int cow_file_range(struct btrfs_inode *inode,
14231434
file_extent.offset = 0;
14241435
file_extent.compression = BTRFS_COMPRESS_NONE;
14251436

1437+
/*
1438+
* Locked range will be released either during error clean up or
1439+
* after the whole range is finished.
1440+
*/
14261441
lock_extent(&inode->io_tree, start, start + cur_alloc_size - 1,
14271442
&cached);
14281443

@@ -1468,21 +1483,6 @@ static noinline int cow_file_range(struct btrfs_inode *inode,
14681483

14691484
btrfs_dec_block_group_reservations(fs_info, ins.objectid);
14701485

1471-
/*
1472-
* We're not doing compressed IO, don't unlock the first page
1473-
* (which the caller expects to stay locked), don't clear any
1474-
* dirty bits and don't set any writeback bits
1475-
*
1476-
* Do set the Ordered flag so we know this page was
1477-
* properly setup for writepage.
1478-
*/
1479-
page_ops = (keep_locked ? 0 : PAGE_UNLOCK);
1480-
page_ops |= PAGE_SET_ORDERED;
1481-
1482-
extent_clear_unlock_delalloc(inode, start, start + cur_alloc_size - 1,
1483-
locked_folio, &cached,
1484-
EXTENT_LOCKED | EXTENT_DELALLOC,
1485-
page_ops);
14861486
if (num_bytes < cur_alloc_size)
14871487
num_bytes = 0;
14881488
else
@@ -1499,6 +1499,9 @@ static noinline int cow_file_range(struct btrfs_inode *inode,
14991499
if (ret)
15001500
goto out_unlock;
15011501
}
1502+
extent_clear_unlock_delalloc(inode, orig_start, end, locked_folio, &cached,
1503+
EXTENT_LOCKED | EXTENT_DELALLOC,
1504+
page_ops);
15021505
done:
15031506
if (done_offset)
15041507
*done_offset = end;
@@ -1519,35 +1522,31 @@ static noinline int cow_file_range(struct btrfs_inode *inode,
15191522
* We process each region below.
15201523
*/
15211524

1522-
clear_bits = EXTENT_LOCKED | EXTENT_DELALLOC | EXTENT_DELALLOC_NEW |
1523-
EXTENT_DEFRAG | EXTENT_CLEAR_META_RESV;
1524-
page_ops = PAGE_UNLOCK | PAGE_START_WRITEBACK | PAGE_END_WRITEBACK;
1525-
15261525
/*
15271526
* For the range (1). We have already instantiated the ordered extents
15281527
* for this region. They are cleaned up by
15291528
* btrfs_cleanup_ordered_extents() in e.g,
1530-
* btrfs_run_delalloc_range(). EXTENT_LOCKED | EXTENT_DELALLOC are
1531-
* already cleared in the above loop. And, EXTENT_DELALLOC_NEW |
1532-
* EXTENT_DEFRAG | EXTENT_CLEAR_META_RESV are handled by the cleanup
1533-
* function.
1529+
* btrfs_run_delalloc_range().
1530+
* EXTENT_DELALLOC_NEW | EXTENT_DEFRAG | EXTENT_CLEAR_META_RESV
1531+
* are also handled by the cleanup function.
15341532
*
1535-
* However, in case of @keep_locked, we still need to unlock the pages
1536-
* (except @locked_folio) to ensure all the pages are unlocked.
1533+
* So here we only clear EXTENT_LOCKED and EXTENT_DELALLOC flag,
1534+
* and finish the writeback of the involved folios, which will be
1535+
* never submitted.
15371536
*/
1538-
if (keep_locked && orig_start < start) {
1537+
if (orig_start < start) {
1538+
clear_bits = EXTENT_LOCKED | EXTENT_DELALLOC;
1539+
page_ops = PAGE_UNLOCK | PAGE_START_WRITEBACK | PAGE_END_WRITEBACK;
1540+
15391541
if (!locked_folio)
15401542
mapping_set_error(inode->vfs_inode.i_mapping, ret);
15411543
extent_clear_unlock_delalloc(inode, orig_start, start - 1,
1542-
locked_folio, NULL, 0, page_ops);
1544+
locked_folio, NULL, clear_bits, page_ops);
15431545
}
15441546

1545-
/*
1546-
* At this point we're unlocked, we want to make sure we're only
1547-
* clearing these flags under the extent lock, so lock the rest of the
1548-
* range and clear everything up.
1549-
*/
1550-
lock_extent(&inode->io_tree, start, end, NULL);
1547+
clear_bits = EXTENT_LOCKED | EXTENT_DELALLOC | EXTENT_DELALLOC_NEW |
1548+
EXTENT_DEFRAG | EXTENT_CLEAR_META_RESV;
1549+
page_ops = PAGE_UNLOCK | PAGE_START_WRITEBACK | PAGE_END_WRITEBACK;
15511550

15521551
/*
15531552
* For the range (2). If we reserved an extent for our delalloc range

0 commit comments

Comments
 (0)