Skip to content

Commit 26d2998

Browse files
authored
Merge pull request #203 from acep-uaf/nicole/event_timest_msg_file
Add event_timestamp to message file
2 parents 142003f + 9ffd8a6 commit 26d2998

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

cli_meter/meters/sel735/create_message.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# Description: This script creates a .message file with a JSON payload.
55
#
66
# Usage: ./create_message.sh <event_id> <zip_filename> <md5sum_value>
7-
# <data_type> <output_dir>
7+
# <data_type> <output_dir> <event_timestamp>
88
#
99
# Arguments:
1010
# meter_id Meter ID
@@ -13,6 +13,7 @@
1313
# md5sum_value md5sum of the zipped file
1414
# data_type Type of data
1515
# output_dir Directory where the message file will be stored
16+
# event_timestamp Timestamp of the event from the meter
1617
#
1718
# Requirements: jq
1819
# common_utils.sh
@@ -21,15 +22,16 @@ current_dir=$(dirname "$(readlink -f "$0")")
2122
script_name=$(basename "$0")
2223
source "$current_dir/../../common_utils.sh"
2324

24-
# Check for exactly 6 arguments
25-
[ "$#" -ne 6 ] && failure $STREAMS_INVALID_ARGS "Usage: $script_name <meter_id> <event_id> <zip_filename> <md5sum_value> <data_type> <output_dir>"
25+
# Check for exactly 7 arguments
26+
[ "$#" -ne 7 ] && failure $STREAMS_INVALID_ARGS "Usage: $script_name <meter_id> <event_id> <zip_filename> <md5sum_value> <data_type> <output_dir> <event_timestamp>"
2627

2728
meter_id="$1"
2829
event_id="$2"
2930
zip_filename="$3"
3031
md5sum_value="$4"
3132
data_type="$5"
3233
output_dir="$6"
34+
event_timestamp="$7"
3335
message_file="$output_dir/${zip_filename}.message"
3436

3537
# Create the JSON payload
@@ -39,7 +41,8 @@ json_payload=$(jq -n \
3941
--arg fn "$zip_filename" \
4042
--arg md5s "$md5sum_value" \
4143
--arg dt "$data_type" \
42-
'{meter_id: $mid, event_id: $eid, filename: $fn, md5sum: $md5s, data_type: $dt}')
44+
--arg et "$event_timestamp" \
45+
'{meter_id: $mid, event_id: $eid, filename: $fn, md5sum: $md5s, data_type: $dt, event_timestamp: $et}')
4346

4447
# Write the JSON payload to the .message file
4548
echo "$json_payload" > "$message_file" && log "Created message file: $message_file" || failure $STREAMS_FILE_CREATION_FAIL "Failed to write to message file: $message_file"

cli_meter/meters/sel735/download.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ for event_info in $events; do
147147
md5sum_value=$(md5sum "$event_zipped_output_dir/$zip_filename" | awk '{print $1}')
148148

149149
# Create the message file (JSON) for the event
150-
"$current_dir/create_message.sh" "$meter_id" "$event_id" "$zip_filename" "$md5sum_value" "$data_type" "$event_zipped_output_dir" || {
150+
"$current_dir/create_message.sh" "$meter_id" "$event_id" "$zip_filename" "$md5sum_value" "$data_type" "$event_zipped_output_dir" "$event_timestamp" || {
151151
handle_fail "$event_id" "$output_dir" "$STREAMS_FILE_CREATION_FAIL" "Failed to create message file for event: $event_id" "$meter_id" "$download_start" "$download_end"
152152
continue
153153
}

cli_meter/test/test_helper/common.bash

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ _common_setup() {
2020
DATA_TYPE="events"
2121
SYMLINK_NAME="$LOCATION-$METER_TYPE-$METER_ID-YYYYMM-$EVENT_ID"
2222
ZIP_FILENAME="${SYMLINK_NAME}.zip"
23+
EVENT_TIMESTAMP="2021-01-01T00:00:00Z"
2324
}
2425

2526
_common_teardown() {

cli_meter/test/test_scripts.bats

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ teardown() {
1313
}
1414

1515
@test "create_message.sh execution test" {
16-
run ./create_message.sh "$METER_ID" "$EVENT_ID" "$ZIP_FILENAME" "$MD5SUM_VALUE" "$DATA_TYPE" "$TMP_DIR"
16+
run ./create_message.sh "$METER_ID" "$EVENT_ID" "$ZIP_FILENAME" "$MD5SUM_VALUE" "$DATA_TYPE" "$TMP_DIR" "$EVENT_TIMESTAMP"
1717
assert_success
1818
assert [ -f "$TMP_DIR/$ZIP_FILENAME.message" ]
1919
}
@@ -26,7 +26,7 @@ teardown() {
2626
}
2727

2828
@test "create_message.sh test too many arguments" {
29-
run ./create_message.sh "$METER_ID" "$EVENT_ID" "$ZIP_FILENAME" "$MD5SUM_VALUE" "$DATA_TYPE" "$TMP_DIR" "extra_argument"
29+
run ./create_message.sh "$METER_ID" "$EVENT_ID" "$ZIP_FILENAME" "$MD5SUM_VALUE" "$DATA_TYPE" "$TMP_DIR" "$EVENT_TIMESTAMP" "extra_argument"
3030
assert_failure $(($STREAMS_INVALID_ARGS % 256))
3131
assert_output --partial "Usage: create_message.sh <meter_id> <event_id> <zip_filename> <md5sum_value> <data_type> <output_dir>"
3232
}

0 commit comments

Comments
 (0)