Skip to content

@accounts/mongo : Monorepo integration #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 89 commits into from
Mar 13, 2018
Merged

Conversation

Aetherall
Copy link
Member

No description provided.

pradel and others added 30 commits March 13, 2018 11:02
bugfix(object-id): added conversion to ObjectID when needed
Add functions for email verification and password change
Add reason param to addResetPasswordToken
Added a flag that allows for user collection to have simple string ids
@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #176 into master will increase coverage by 1.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   92.16%   93.19%   +1.03%     
==========================================
  Files          42       44       +2     
  Lines        1034     1191     +157     
  Branches      124      167      +43     
==========================================
+ Hits          953     1110     +157     
  Misses         70       70              
  Partials       11       11
Impacted Files Coverage Δ
packages/database-mongo/src/index.ts 100% <100%> (ø)
packages/database-mongo/src/mongo.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56e753...1fb9ffb. Read the comment docs.

Copy link
Member

@pradel pradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -0,0 +1,5 @@
{
Copy link
Member

@pradel pradel Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops done :)

"coverage": "yarn testonly --coverage",
"prepublishOnly": "yarn compile"
},
"renovate": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove renovate config also please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also done, along with the circleci folder and the .gitignore

@pradel
Copy link
Member

pradel commented Mar 13, 2018

Good to merge @Aetherall

@Aetherall Aetherall merged commit 4709486 into master Mar 13, 2018
@Aetherall Aetherall deleted the package/database-mongo branch March 13, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants