fix regex related parsing route name #1284
Conversation
|
ghg070
force-pushed
the
feature/colon-issue
branch
from
a0516dc to
1513e43
Compare
ghg070
force-pushed
the
feature/colon-issue
branch
from
1513e43 to
cb2ec8b
Compare
ghg070
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Hello @ghg070 |
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on September 2, 2025
Learn more in the Cursor dashboard.
| @@ -98,7 +98,7 @@ export class SchemaRoutes { | |||
|
|
|||
| // TODO forbid leading symbols [\]^` in a major release (allowed yet for backwards compatibility) | |||
| const pathParamMatches = (routeName || "").match( | |||
| /({[\w[\\\]^`][-_.\w]*})|(:[\w[\\\]^`][-_.\w]*:?)/g, | |||
| /(?<=\/|\.\.\.)({[\w[\\\]^`][-_.\w]*})|(?<=\/|\.\.\.)(:[\w[\\\]^`][-_.\w]*:?)/g, | |||
There was a problem hiding this comment.
Bug: Regex Lookbehind Compatibility Issue
The regex in parseRouteName now uses positive lookbehind assertions. As an ES2018 feature, these cause a SyntaxError in older JavaScript environments (e.g., Safari <16.4, Firefox <78, Node.js <8.10), which breaks route parsing functionality.
We used swagger-typescript-api to parse and encountered the same issue as this developer (#532). Is it possible to modify the regex in parseRouteName to ensure that there is always a "/" or "..." at the beginning before treating it as a parameter?