Skip to content

Commit f3ca796

Browse files
committed
docs(adr): mark completed steps in ADR-007 with ✅
Step 1 (jaegertracing#8215) and Step 2a (jaegertracing#8216) are merged; mark them done. Step 3 (jaegertracing#8240) is in review. Update status from Proposed → In progress. Signed-off-by: Abhay Chaurasiya <abhay.chaurasiya2003@gmail.com>
1 parent debd614 commit f3ca796

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

docs/adr/007-grafana-dashboards-modernization.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# ADR-007: Grafana Dashboard Modernization and SPM Example Validation
22

3-
* **Status**: Proposed
3+
* **Status**: In progress
44
* **Date**: 2026-03-20
55
* **Related Issues**: [#5833](https://github.com/jaegertracing/jaeger/issues/5833)
66

@@ -73,17 +73,17 @@ There are three problems, addressed in the order below:
7373

7474
We will work incrementally, establishing live validation first and replacing the toolchain along with fixing the dashboard content:
7575

76-
1. **Restore Grafana to `docker-compose/monitor/`**, mounting `dashboard-for-grafana.json` directly from its canonical location. Grafana 11.x is used initially to tolerate the existing Angular panels.
76+
1. **Restore Grafana to `docker-compose/monitor/`**, mounting `dashboard-for-grafana.json` directly from its canonical location. Grafana 11.x is used initially to tolerate the existing Angular panels. _(Merged: [#8215](https://github.com/jaegertracing/jaeger/pull/8215))_
7777
2. **Migrate dashboard source to `grafana-foundation-sdk/go`**, done in two parts:
78-
- **2a** — Write the Go generator, produce `dashboard-for-grafana-v2.json`, and mount both dashboards in Grafana for manual side-by-side comparison against live data.
78+
- **2a** — Write the Go generator, produce `dashboard-for-grafana-v2.json`, and mount both dashboards in Grafana for manual side-by-side comparison against live data. _(Merged: [#8216](https://github.com/jaegertracing/jaeger/pull/8216))_
7979
- **2b** — After validation, delete the Jsonnet toolchain, promote the v2 file to `dashboard-for-grafana.json`, and upgrade Grafana to 12.x.
8080
3. **Add CI validation** to keep `dashboard-for-grafana.json` in sync with the Go source and lint its structure.
8181

8282
---
8383

8484
## Implementation Plan
8585

86-
### Step 1: Restore Grafana to the SPM docker-compose example
86+
### Step 1: Restore Grafana to the SPM docker-compose example _(Merged: [#8215](https://github.com/jaegertracing/jaeger/pull/8215))_
8787

8888
This step restores visibility and validation capability. The dashboard loaded at this point will still have Angular panels, so Grafana 11.x is used — the last series with Angular support enabled by default.
8989

@@ -144,7 +144,7 @@ This step restores visibility and validation capability. The dashboard loaded at
144144

145145
**Validation:** Run `docker compose up` and confirm the Grafana dashboard loads and panels show data from microsim-generated traces. Angular deprecation warnings are expected at this stage.
146146

147-
### Step 2a: Introduce the Go SDK generator alongside the existing dashboard
147+
### Step 2a: Introduce the Go SDK generator alongside the existing dashboard _(Merged: [#8216](https://github.com/jaegertracing/jaeger/pull/8216))_
148148

149149
Write the Go generator and mount its output in Grafana alongside the existing Jsonnet-generated dashboard for side-by-side comparison. The Jsonnet source and `dashboard-for-grafana.json` are left untouched at this stage.
150150

@@ -231,7 +231,7 @@ monitoring/jaeger-mixin/
231231
232232
**Validation:** Run `docker compose up` with the single dashboard mount and Grafana 12.x. Confirm all panels render with no Angular deprecation warnings.
233233
234-
### Step 3: Add CI validation
234+
### Step 3: Add CI validation _(In review: [#8240](https://github.com/jaegertracing/jaeger/pull/8240))_
235235
236236
Create `scripts/lint/lint-monitoring.sh`:
237237

0 commit comments

Comments
 (0)