5 full testsuite for the mcp server (#6)

* Add testsuite with MCP typescript SDK

Author: wommel0

.gitignore

@@ -0,0 +1,67 @@
+node_modules/
+.node_modules/
+built/*
+tests/cases/rwc/*
+tests/cases/perf/*
+!tests/cases/webharness/compilerToString.js
+test-args.txt
+~*.docx
+\#*\#
+.\#*
+tests/baselines/local/*
+tests/baselines/local.old/*
+tests/services/baselines/local/*
+tests/baselines/prototyping/local/*
+tests/baselines/rwc/*
+tests/baselines/reference/projectOutput/*
+tests/baselines/local/projectOutput/*
+tests/baselines/reference/testresults.tap
+tests/baselines/symlinks/*
+tests/services/baselines/prototyping/local/*
+tests/services/browser/typescriptServices.js
+src/harness/*.js
+src/compiler/diagnosticInformationMap.generated.ts
+src/compiler/diagnosticMessages.generated.json
+src/parser/diagnosticInformationMap.generated.ts
+src/parser/diagnosticMessages.generated.json
+rwc-report.html
+*.swp
+build.json
+*.actual
+tests/webTestServer.js
+tests/webTestServer.js.map
+tests/webhost/*.d.ts
+tests/webhost/webtsc.js
+tests/cases/**/*.js
+tests/cases/**/*.js.map
+*.config
+scripts/eslint/built/
+scripts/debug.bat
+scripts/run.bat
+scripts/**/*.js
+scripts/**/*.js.map
+coverage/
+internal/
+**/.DS_Store
+.settings
+**/.vs
+**/.vscode/*
+!**/.vscode/tasks.json
+!**/.vscode/settings.template.json
+!**/.vscode/launch.template.json
+!**/.vscode/extensions.json
+!tests/cases/projects/projectOption/**/node_modules
+!tests/cases/projects/NodeModulesSearch/**/*
+!tests/baselines/reference/project/nodeModules*/**/*
+.idea
+yarn.lock
+yarn-error.log
+.parallelperf.*
+tests/baselines/reference/dt
+.failed-tests
+TEST-results.xml
+package-lock.json
+.eslintcache
+*v8.log
+/lib/
+.env

README.md

@@ -46,7 +46,7 @@ Not implmented:
 
 See currently open issues for details. In general the following topics are prioritized:
 
-- Full test suite especially covering session handling and error scenarios
+- ✅ Test suite using an MCP client --> exists via TypeScript SDK in folder test [Test](/test/README.md)
 - Demonstrate ways to use OAuth reducing challenges with only standard compliant clients
 - Cleanup batch job / report to delete outdated sessions
 - Improve logging by increasing the logged scope

abaplint.json

@@ -846,7 +846,7 @@
       "severity": "Error"
     },
     "unused_types": {
-      "exclude": [],
+      "exclude": ["zcl_mcp_resp_get_prompt"],
       "severity": "Error",
       "skipNames": []
     },

src/ajson/zcl_mcp_ajson.clas.abap

@@ -34,7 +34,8 @@ class zcl_mcp_ajson definition
       delete for zif_mcp_ajson~delete,
       touch_array for zif_mcp_ajson~touch_array,
       push for zif_mcp_ajson~push,
-      stringify for zif_mcp_ajson~stringify.
+      stringify for zif_mcp_ajson~stringify,
+      touch_object for zif_mcp_ajson~touch_object.
 
     aliases:
       clone for zif_mcp_ajson~clone,
@@ -967,4 +968,61 @@ CLASS zcl_mcp_ajson IMPLEMENTATION.
     ms_opts-to_abap_corresponding_only = iv_enable.
     ri_json = me.
   endmethod.
+
+  method zif_mcp_ajson~touch_object.
+
+  data lr_node type ref to zif_mcp_ajson_types=>ty_node.
+  data ls_deleted_node type zif_mcp_ajson_types=>ty_node.
+  data ls_new_node like line of mt_json_tree.
+  data ls_split_path type zif_mcp_ajson_types=>ty_path_name.
+
+  read_only_watchdog( ).
+
+  ls_split_path = lcl_utils=>split_path( iv_path ).
+  if ls_split_path is initial. " Assign root, exceptional processing
+    ls_new_node-path = ls_split_path-path.
+    ls_new_node-name = ls_split_path-name.
+    ls_new_node-type = zif_mcp_ajson_types=>node_type-object.
+    insert ls_new_node into table mt_json_tree.
+    return.
+  endif.
+
+  if iv_clear = abap_true.
+    ls_deleted_node = delete_subtree(
+      iv_path = ls_split_path-path
+      iv_name = ls_split_path-name ).
+  else.
+    lr_node = get_item( iv_path ).
+  endif.
+
+  if lr_node is initial. " Or node was cleared
+
+    data lr_parent type ref to zif_mcp_ajson_types=>ty_node.
+    lr_parent = prove_path_exists( ls_split_path-path ).
+    assert lr_parent is not initial.
+
+    lr_parent->children = lr_parent->children + 1.
+
+    ls_new_node-path = ls_split_path-path.
+    ls_new_node-name = ls_split_path-name.
+    ls_new_node-type = zif_mcp_ajson_types=>node_type-object.
+
+    if ms_opts-keep_item_order = abap_true.
+      if ls_deleted_node is not initial.
+        ls_new_node-order = ls_deleted_node-order.
+      else.
+        ls_new_node-order = lr_parent->children.
+      endif.
+    endif.
+
+    insert ls_new_node into table mt_json_tree.
+
+  elseif lr_node->type <> zif_mcp_ajson_types=>node_type-object.
+    zcx_mcp_ajson_error=>raise( |Path [{ iv_path }] already used and is not object| ) ##NO_TEXT.
+  endif.
+
+  ri_json = me.
+
+endmethod.
+
 ENDCLASS.

src/ajson/zcl_mcp_ajson.clas.testclasses.abap

@@ -2488,6 +2488,7 @@ class ltcl_writer_test definition final
     methods setx_float for testing raising zcx_mcp_ajson_error.
     methods setx_complex for testing raising zcx_mcp_ajson_error.
     methods setx_complex_w_keep_order for testing raising zcx_mcp_ajson_error.
+    methods touch_object for testing raising zcx_mcp_ajson_error.
 
     methods set_with_type_slice
       importing
@@ -3800,6 +3801,125 @@ class ltcl_writer_test implementation.
 
   endmethod.
 
+method touch_object.
+
+  data lo_cut type ref to zcl_mcp_ajson.
+  data lo_nodes_exp type ref to lcl_nodes_helper.
+  data li_writer type ref to zif_mcp_ajson.
+
+  " Test 1: Create empty object at path
+  lo_cut = zcl_mcp_ajson=>create_empty( ).
+  li_writer = lo_cut.
+
+  create object lo_nodes_exp.
+  lo_nodes_exp->add( '        |      |object |     ||1' ).
+  lo_nodes_exp->add( '/       |a     |object |     ||0' ).
+
+  li_writer->touch_object( iv_path = '/a' ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->mt_json_tree
+    exp = lo_nodes_exp->sorted( ) ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->stringify( )
+    exp = '{"a":{}}' ).
+
+  " Test 2: Create empty object at root level
+  lo_cut = zcl_mcp_ajson=>create_empty( ).
+  li_writer = lo_cut.
+
+  create object lo_nodes_exp.
+  lo_nodes_exp->add( '        |      |object |     ||0' ).
+
+  li_writer->touch_object( iv_path = '/' ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->mt_json_tree
+    exp = lo_nodes_exp->sorted( ) ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->stringify( )
+    exp = '{}' ).
+
+  " Test 3: Create nested objects
+  lo_cut = zcl_mcp_ajson=>create_empty( ).
+  li_writer = lo_cut.
+
+  create object lo_nodes_exp.
+  lo_nodes_exp->add( '        |      |object |     ||1' ).
+  lo_nodes_exp->add( '/       |a     |object |     ||1' ).
+  lo_nodes_exp->add( '/a/     |b     |object |     ||1' ).
+  lo_nodes_exp->add( '/a/b/   |c     |object |     ||0' ).
+
+  li_writer->touch_object( iv_path = '/a' ).
+  li_writer->touch_object( iv_path = '/a/b' ).
+  li_writer->touch_object( iv_path = '/a/b/c' ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->mt_json_tree
+    exp = lo_nodes_exp->sorted( ) ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->stringify( )
+    exp = '{"a":{"b":{"c":{}}}}' ).
+
+  " Test 4: Clear existing content
+  lo_cut = zcl_mcp_ajson=>create_empty( ).
+  li_writer = lo_cut.
+
+  li_writer->set(
+    iv_path = '/a/x'
+    iv_val  = 'abc' ).
+
+  create object lo_nodes_exp.
+  lo_nodes_exp->add( '        |      |object |     ||1' ).
+  lo_nodes_exp->add( '/       |a     |object |     ||0' ).
+
+  li_writer->touch_object(
+    iv_path  = '/a'
+    iv_clear = abap_true ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->mt_json_tree
+    exp = lo_nodes_exp->sorted( ) ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->stringify( )
+    exp = '{"a":{}}' ).
+
+  " Test 5: Error when existing node isn't an object
+  lo_cut = zcl_mcp_ajson=>create_empty( ).
+  li_writer = lo_cut.
+
+  li_writer->touch_array( iv_path = '/a' ).
+
+  data lx type ref to zcx_mcp_ajson_error.
+  try.
+    li_writer->touch_object( iv_path = '/a' ).
+    cl_abap_unit_assert=>fail( ).
+  catch zcx_mcp_ajson_error into lx.
+    cl_abap_unit_assert=>assert_equals(
+      act = lx->message
+      exp = 'Path [/a] already used and is not object' ).
+  endtry.
+
+  " Test 6: With item ordering - FIXED TYPE ISSUE
+  lo_cut = zcl_mcp_ajson=>create_empty( ).
+  li_writer = lo_cut.
+  li_writer->keep_item_order( ).
+
+  li_writer->set(
+    iv_path = '/b'
+    iv_val  = 1 ).
+  li_writer->touch_object( '/a' ).
+
+  cl_abap_unit_assert=>assert_equals(
+    act = lo_cut->stringify( )
+    exp = '{"b":1,"a":{}}' ).
+
+endmethod.
+
 endclass.
 
 

src/ajson/zif_mcp_ajson.intf.abap

@@ -259,4 +259,14 @@ interface zif_mcp_ajson
     raising
       zcx_mcp_ajson_error.
 
+  methods touch_object
+    importing
+      iv_path type string
+      iv_clear type abap_bool default abap_false
+    returning
+      value(ri_json) type ref to zif_mcp_ajson
+    raising
+      zcx_mcp_ajson_error.
+
+
 endinterface.

src/data/zcl_mcp_req_call_tool.clas.testclasses.abap

@@ -98,8 +98,9 @@ CLASS ltcl_mcp_req_call_tool IMPLEMENTATION.
         " Expected - name is required but missing
         cl_abap_unit_assert=>assert_equals( exp = 'ZMCP'
                                             act = lx_error->if_t100_message~t100key-msgid ).
+        " required_params message number
         cl_abap_unit_assert=>assert_equals( exp = '002'
-                                            act = lx_error->if_t100_message~t100key-msgno ). " required_params message number
+                                            act = lx_error->if_t100_message~t100key-msgno ).
     ENDTRY.
   ENDMETHOD.
 
@@ -120,8 +121,9 @@ CLASS ltcl_mcp_req_call_tool IMPLEMENTATION.
         " Expected - name is empty
         cl_abap_unit_assert=>assert_equals( exp = 'ZMCP'
                                             act = lx_error->if_t100_message~t100key-msgid ).
+        " unknown_tool message number
         cl_abap_unit_assert=>assert_equals( exp = '009'
-                                            act = lx_error->if_t100_message~t100key-msgno ). " unknown_tool message number
+                                            act = lx_error->if_t100_message~t100key-msgno ).
     ENDTRY.
   ENDMETHOD.
 ENDCLASS.

src/data/zcl_mcp_req_get_prompt.clas.testclasses.abap

@@ -102,8 +102,9 @@ CLASS ltcl_mcp_req_get_prompt IMPLEMENTATION.
         " Expected - name is required but missing
         cl_abap_unit_assert=>assert_equals( exp = 'ZMCP'
                                             act = lx_error->if_t100_message~t100key-msgid ).
+        " required_params message number
         cl_abap_unit_assert=>assert_equals( exp = '002'
-                                            act = lx_error->if_t100_message~t100key-msgno ). " required_params message number
+                                            act = lx_error->if_t100_message~t100key-msgno ).
     ENDTRY.
   ENDMETHOD.
 
@@ -122,8 +123,9 @@ CLASS ltcl_mcp_req_get_prompt IMPLEMENTATION.
         " Expected - name is empty
         cl_abap_unit_assert=>assert_equals( exp = 'ZMCP'
                                             act = lx_error->if_t100_message~t100key-msgid ).
+        " prompt_name_invalid message number
         cl_abap_unit_assert=>assert_equals( exp = '001'
-                                            act = lx_error->if_t100_message~t100key-msgno ). " prompt_name_invalid message number
+                                            act = lx_error->if_t100_message~t100key-msgno ).
     ENDTRY.
   ENDMETHOD.
 ENDCLASS.

src/data/zcl_mcp_req_read_resource.clas.testclasses.abap

@@ -36,6 +36,6 @@ CLASS ltcl_mcp_req_read_resource IMPLEMENTATION.
         cl_abap_unit_assert=>fail( 'Expected exception for missing URI' ).
       CATCH zcx_mcp_server.
         " Expected - URI is required but missing
-    ENDTRY.
+    ENDTRY. "#EC EMPTY_CATCH
   ENDMETHOD.
 ENDCLASS.