forked from getsentry/sentry-javascript
-
Notifications
You must be signed in to change notification settings - Fork 0
PR fixes #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Zen-cronic
merged 7 commits into
Zen-cronic:feat/graphqlClientIntegration
from
getsentry:fn/graphql-client-pr-fixes
Feb 5, 2025
Merged
PR fixes #1
Zen-cronic
merged 7 commits into
Zen-cronic:feat/graphqlClientIntegration
from
getsentry:fn/graphql-client-pr-fixes
Feb 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.
Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixes #15244
- adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option:  Without annotation option (to confirm that it looks the same as before):  Closes #15252
…15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: 
5 tasks
Zen-cronic
reviewed
Feb 5, 2025
@@ -1,12 +1,14 @@ | |||
import * as Sentry from '@sentry/browser'; | |||
// Must import this like this to ensure the test transformation for CDN bundles works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't aware of that, thanks!
c8f69fe
into
Zen-cronic:feat/graphqlClientIntegration
33 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged in latest develop, but more importantly I fixed the CDN bundle tests here: 67b7b0b, which was the missing piece for CI :)