Removed Pyrcrack class

With the new airmon-ng and airodump-ng APIs with async context managers,
proper properties for results and interfaces and callable objects, the
"simplified" interface that exposed the Pyrcrack class is no longer
needed.

Usage is more comprehensive now, and cleanup afterwards should work.
Altough examples seem to not wait for __aexit__ to cleanup (thus
airmon-ng's created interface would prevail) upon KeyboardInterrupt.

Might be caused by https://bugs.python.org/issue29988 wich relates to
bpo-29988 ( python/cpython#18334 )

Author: XayOn

docs/examples/scan_for_targets.py

@@ -1,26 +1,28 @@
 """Scan for targets and and pretty print some data."""
 import asyncio
-import sys
 
 import pyrcrack
 
 from rich.console import Console
+from rich.prompt import Prompt
 
 
 async def scan_for_targets():
     """Scan for targets, return json."""
     console = Console()
     console.clear()
     console.show_cursor(False)
-    async with pyrcrack.AirodumpNg() as pdump:
-        async for result in pdump(sys.argv[1]):
-            # Current running process will be stored in self.proc
-            # Be careful, the process will only start when you iter trough
-            # results. A simple await anext(pdump(...)) would do if you don't
-            # reallywant to gather results.
-            console.clear()
-            console.print(result.table)
-            await asyncio.sleep(2)
+    airmon = pyrcrack.AirmonNg()
+
+    interface = Prompt.ask(
+        'Select an interface',
+        choices=[a['interface'] for a in await airmon.interfaces])
+    async with airmon(interface) as mon:
+        async with pyrcrack.AirodumpNg() as pdump:
+            async for result in pdump(mon.monitor_interface):
+                console.clear()
+                console.print(result.table)
+                await asyncio.sleep(2)
 
 
 asyncio.run(scan_for_targets())

docs/examples/scan_for_targets_simplified.py

@@ -2,7 +2,6 @@
 
 Aircrack-NG python bindings
 """
-import asyncio
 import subprocess
 
 from .aircrack import AircrackNg  # noqa
@@ -17,53 +16,3 @@
 def check():
     """Check if aircrack-ng is compatible."""
     assert '1.6' in subprocess.check_output(['aircrack-ng', '-v'])
-
-
-class Pyrcrack:
-    """High level aircrack-ng interface.
-
-    Arguments:
-
-        list_waiting_time: Time (in seconds) to wait for a network scan
-    """
-    def __init__(self):
-        """Set up pyrcrack instance."""
-        self.iface = None
-
-    @property
-    async def interfaces(self):
-        """List of currently available interfaces as reported by airmon-ng
-
-        This is an awaitable property, use it as in::
-
-            await Pyrcrack().interfaces
-
-        Returns: None
-        """
-        return [a['interface'] for a in await AirmonNg().list_wifis()]
-
-    async def set_interface(self, interface):
-        """Select an interface, set it on monitor mode
-
-        Will set `iface` property.
-        """
-        assert interface in await self.interfaces
-        async with AirmonNg() as airmon:
-            interface = await airmon.set_monitor(interface)
-            self.iface = interface[0]['monitor']['interface']
-
-    @property
-    async def access_points(self) -> list:
-        """Return a list of access points by scanning with airodump-ng
-
-        This is a basic, hihg-level scan, for 10 seconds, on all channels
-        without extra options, for more custom searches uses directly the
-        AirodumpNg async context manager.
-
-        Returns: List `AccessPoint` instances
-        """
-        async with AirodumpNg() as pdump:
-            async for res in pdump(self.iface):
-                if res:
-                    return res
-                asyncio.sleep(10)

pyrcrack/__init__.py

@@ -20,6 +20,7 @@ class AirmonNg(ExecutorHelper):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.monitor_enabled = []
+        self.interface = None
 
     async def run(self, *args, **kwargs):
         """Check argument position. Forced for this one."""

pyrcrack/airmon.py

@@ -7,22 +7,20 @@ async def test_run_airmon():
     import asynctest
     from pyrcrack import AirmonNg
 
-    async with AirmonNg() as airmong:
-        with asynctest.mock.patch("asyncio.create_subprocess_exec") as runmock:
-            with pytest.raises(AssertionError):
-                await airmong.run('foo')
-            await airmong.run('start')
+    with asynctest.mock.patch("asyncio.create_subprocess_exec") as runmock:
+        with pytest.raises(AssertionError):
+            await AirmonNg().run('foo')
+        await AirmonNg().run('start')
 
-            runmock.assert_called_with('airmon-ng',
-                                       'start',
-                                       stderr=-1,
-                                       stdout=-1,
-                                       stdin=-1)
+        runmock.assert_called_with('airmon-ng',
+                                   'start',
+                                   stderr=-1,
+                                   stdout=-1,
+                                   stdin=-1)
 
-    async with AirmonNg() as airmong:
-        with asynctest.mock.patch("asyncio.create_subprocess_exec") as runmock:
-            await airmong.run()
-            runmock.assert_called_with('airmon-ng',
-                                       stderr=-1,
-                                       stdout=-1,
-                                       stdin=-1)
+    with asynctest.mock.patch("asyncio.create_subprocess_exec") as runmock:
+        await AirmonNg().run()
+        runmock.assert_called_with('airmon-ng',
+                                   stderr=-1,
+                                   stdout=-1,
+                                   stdin=-1)