Skip to content

Commit b2ca719

Browse files
Merge pull request #253 from cleandart/CPLAT-7226-deprecate-setClientConfiguration-v2
CPLAT-7226 Deprecate setClientConfiguration
2 parents 8b482c8 + bfd44cd commit b2ca719

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+1706
-1656
lines changed

README.md

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,10 @@ in the `main` entrypoint of your Dart application.
7171
```dart
7272
import 'dart:html';
7373
74-
import 'package:react/react_client.dart' as react_client;
7574
import 'package:react/react.dart';
7675
import 'package:react/react_dom.dart' as react_dom;
7776
7877
main() {
79-
// This should be called once at the beginning of the application.
80-
react_client.setClientConfiguration();
81-
8278
// Something to render... in this case a simple <div> with no props, and a string as its children.
8379
var component = div({}, "Hello world!");
8480
@@ -137,16 +133,12 @@ var aButton = button({"onClick": (SyntheticMouseEvent event) => print(event)});
137133
138134
import 'dart:html';
139135
140-
import 'package:react/react_client.dart' as react_client;
141136
import 'package:react/react.dart';
142137
import 'package:react/react_dom.dart' as react_dom;
143138
144139
import 'cool_widget.dart';
145140
146141
main() {
147-
// This should be called once at the beginning of the application.
148-
react_client.setClientConfiguration();
149-
150142
react_dom.render(CoolWidget({}), querySelector('#react_mount_point'));
151143
}
152144
```
@@ -173,16 +165,12 @@ var CoolWidget = registerComponent(() => new CoolWidgetComponent());
173165
174166
import 'dart:html';
175167
176-
import 'package:react/react_client.dart' as react_client;
177168
import 'package:react/react.dart';
178169
import 'package:react/react_dom.dart' as react_dom;
179170
180171
import 'cool_widget.dart';
181172
182173
main() {
183-
// This should be called once at the beginning of the application.
184-
react_client.setClientConfiguration();
185-
186174
react_dom.render(CoolWidget({"text": "Something"}), querySelector('#react_mount_point'));
187175
}
188176
```
@@ -225,16 +213,12 @@ class CoolWidgetComponent extends Component {
225213
226214
import 'dart:html';
227215
228-
import 'package:react/react_client.dart' as react_client;
229216
import 'package:react/react.dart';
230217
import 'package:react/react_dom.dart' as react_dom;
231218
232219
import 'cool_widget.dart';
233220
234221
void main() {
235-
// This should be called once at the beginning of the application.
236-
react_client.setClientConfiguration();
237-
238222
react_dom.render(
239223
myComponent(
240224
headline: "My custom headline",
@@ -352,7 +336,6 @@ Here is an example of how to use React React.addons.TestUtils. within a Dart tes
352336
```dart
353337
import 'package:test/test.dart';
354338
import 'package:react/react.dart' as react;
355-
import 'package:react/react_client.dart' as react_client;
356339
import 'package:react/react_dom.dart' as react_dom;
357340
import 'package:react/react_test_utils.dart' as react_test_utils;
358341
@@ -372,8 +355,6 @@ class MyTestComponent extends react.Component {
372355
var myTestComponent = react.registerComponent(() => new MyTestComponent());
373356
374357
void main() {
375-
react_client.setClientConfiguration();
376-
377358
test('should click button and set span text to "success"', () {
378359
var component = react_test_utils.renderIntoDocument(myTestComponent({}));
379360

example/geocodes/geocodes.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import 'dart:html';
55

66
import 'package:react/react.dart' as react;
77
import 'package:react/react_dom.dart' as react_dom;
8-
import 'package:react/react_client.dart';
98

109
/**
1110
* Hello,
@@ -331,6 +330,5 @@ var geocodesApp = react.registerComponent(() => new _GeocodesApp());
331330
///
332331
/// Select the root of the app and the place in the DOM where it should be mounted.
333332
void main() {
334-
setClientConfiguration();
335333
react_dom.render(geocodesApp({}), querySelector('#content'));
336334
}

example/js_components/js_components.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ import 'package:react/react_client/react_interop.dart';
1010
import 'package:react/react_dom.dart' as react_dom;
1111

1212
main() {
13-
setClientConfiguration();
14-
1513
var content = IndexComponent({});
1614

1715
react_dom.render(content, querySelector('#content'));

example/test/call_and_nosuchmethod_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import "dart:html";
33

44
import "package:react/react_dom.dart" as react_dom;
55
import "package:react/react.dart" as react;
6-
import "package:react/react_client.dart";
76

87
class _CustomComponent extends react.Component {
98
render() {
@@ -14,8 +13,6 @@ class _CustomComponent extends react.Component {
1413
var customComponent = react.registerComponent(() => new _CustomComponent());
1514

1615
void main() {
17-
setClientConfiguration();
18-
1916
react_dom.render(
2017
react.div({}, [
2118
react.div({'key': 'noChildren'}),

example/test/context_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@ import 'dart:html';
22

33
import 'package:react/react.dart' as react;
44
import 'package:react/react_dom.dart' as react_dom;
5-
import 'package:react/react_client.dart';
65

76
import 'react_test_components.dart';
87

98
void main() {
10-
setClientConfiguration();
11-
129
react_dom.render(
1310
react.div({}, [
1411
react.h1({}, ['React Legacy Context API']),

example/test/false_and_null_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'dart:html';
33

44
import 'package:react/react.dart' as react;
55
import 'package:react/react_dom.dart' as react_dom;
6-
import 'package:react/react_client.dart';
76

87
class _Component extends react.Component {
98
render() {
@@ -18,8 +17,6 @@ class _Component extends react.Component {
1817
var component = react.registerComponent(() => new _Component());
1918

2019
void main() {
21-
setClientConfiguration();
22-
2320
var content = react.div({}, [
2421
react.p({}, 'Testing a dynamic return value of "null"...'),
2522
component({'returnValue': null, 'key': 0}),

example/test/function_component_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import 'dart:math';
33

44
import 'package:react/hooks.dart';
55
import 'package:react/react.dart' as react;
6+
import 'package:react/react_client/react_interop.dart';
67
import 'package:react/react_dom.dart' as react_dom;
7-
import 'package:react/react_client.dart';
88

99
var hookTestFunctionComponent = react.registerFunctionComponent(HookTestComponent, displayName: 'useStateTest');
1010

@@ -406,8 +406,6 @@ UseImperativeHandleTestComponent2(Map props) {
406406
}
407407

408408
void main() {
409-
setClientConfiguration();
410-
411409
render() {
412410
react_dom.render(
413411
react.Fragment({}, [

example/test/get_dom_node_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import "dart:html";
33

44
import "package:react/react.dart" as react;
55
import "package:react/react_dom.dart" as react_dom;
6-
import "package:react/react_client.dart";
76

87
customAssert(text, condition) {
98
if (condition)
@@ -83,7 +82,6 @@ class SimpleComponent extends react.Component {
8382
var mountedNode = querySelector('#content');
8483

8584
void main() {
86-
setClientConfiguration();
8785
var component = simpleComponent({});
8886
react_dom.render(component, mountedNode);
8987
}

example/test/order_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'dart:html';
33

44
import "package:react/react.dart" as react;
55
import "package:react/react_dom.dart" as react_dom;
6-
import "package:react/react_client.dart";
76

87
class _Item extends react.Component {
98
componentWillReceiveProps(newProps) {
@@ -38,6 +37,5 @@ class _List extends react.Component {
3837
var list = react.registerComponent(() => new _List());
3938

4039
void main() {
41-
setClientConfiguration();
4240
react_dom.render(list({}), querySelector('#content'));
4341
}

example/test/react_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
import "dart:html";
22

33
import "package:react/react_dom.dart" as react_dom;
4-
import "package:react/react_client.dart";
54

65
import "react_test_components.dart";
76

87
void main() {
9-
setClientConfiguration();
108
react_dom.render(
119
mainComponent({}, [
1210
helloGreeter({'key': 'hello'}, []),

0 commit comments

Comments
 (0)