Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Commit 73051c9

Browse files
ngzhianngzhian
committed
Rename SIMD load splats
Following suggestions in #297, renaming load splats to something more consistent.
1 parent b89087d commit 73051c9

File tree

6 files changed

+144
-144
lines changed

6 files changed

+144
-144
lines changed

‎proposals/simd/BinarySIMD.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ For example, `ImmLaneIdx16` is a byte with values in the range 0-15 (inclusive).
3939
| `i32x4.load16x4_u` | `0x04`| m:memarg |
4040
| `i64x2.load32x2_s` | `0x05`| m:memarg |
4141
| `i64x2.load32x2_u` | `0x06`| m:memarg |
42-
| `v8x16.load_splat` | `0x07`| m:memarg |
43-
| `v16x8.load_splat` | `0x08`| m:memarg |
44-
| `v32x4.load_splat` | `0x09`| m:memarg |
45-
| `v64x2.load_splat` | `0x0a`| m:memarg |
42+
| `v128.load8_splat` | `0x07`| m:memarg |
43+
| `v128.load16_splat` | `0x08`| m:memarg |
44+
| `v128.load32_splat` | `0x09`| m:memarg |
45+
| `v128.load64_splat` | `0x0a`| m:memarg |
4646
| `v128.store` | `0x0b`| m:memarg |
4747
| `v128.const` | `0x0c`| i:ImmByte[16] |
4848
| `v8x16.shuffle` | `0x0d`| s:ImmLaneIdx32[16] |

‎proposals/simd/ImplementationStatus.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
| `i32x4.load16x4_u` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
88
| `i64x2.load32x2_s` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
99
| `i64x2.load32x2_u` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
10-
| `v8x16.load_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
11-
| `v16x8.load_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
12-
| `v32x4.load_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
13-
| `v64x2.load_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
10+
| `v128.load8_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
11+
| `v128.load16_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
12+
| `v128.load32_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
13+
| `v128.load64_splat` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
1414
| `v128.store` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |
1515
| `v128.const` | `-munimplemented-simd128` | :heavy_check_mark: [6] | | | :heavy_check_mark: |
1616
| `v8x16.shuffle` | `-msimd128` | :heavy_check_mark: | | | :heavy_check_mark: |

‎proposals/simd/NewOpcodes.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
| i32x4.load16x4_u | 0x04 |
88
| i64x2.load32x2_s | 0x05 |
99
| i64x2.load32x2_u | 0x06 |
10-
| v8x16.load_splat | 0x07 |
11-
| v16x8.load_splat | 0x08 |
12-
| v32x4.load_splat | 0x09 |
13-
| v64x2.load_splat | 0x0a |
10+
| v128.load8_splat | 0x07 |
11+
| v128.load16_splat | 0x08 |
12+
| v128.load32_splat | 0x09 |
13+
| v128.load64_splat | 0x0a |
1414
| v128.store | 0x0b |
1515

1616
| Basic operation | opcode |

‎proposals/simd/SIMD.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -768,10 +768,10 @@ def S.load(memarg):
768768

769769
### Load and Splat
770770

771-
* `v8x16.load_splat(memarg) -> v128`
772-
* `v16x8.load_splat(memarg) -> v128`
773-
* `v32x4.load_splat(memarg) -> v128`
774-
* `v64x2.load_splat(memarg) -> v128`
771+
* `v128.load8_splat(memarg) -> v128`
772+
* `v128.load16_splat(memarg) -> v128`
773+
* `v128.load32_splat(memarg) -> v128`
774+
* `v128.load64_splat(memarg) -> v128`
775775

776776
Load a single element and splat to all lanes of a `v128` vector. The natural
777777
alignment is the size of the element loaded.

‎test/core/simd/simd_align.wast

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@
3737
(module (memory 1) (func (drop (i64x2.load32x2_u align=4 (i32.const 0)))))
3838
(module (memory 1) (func (drop (i64x2.load32x2_u align=8 (i32.const 0)))))
3939

40-
(module (memory 1) (func (drop (v8x16.load_splat align=1 (i32.const 0)))))
41-
(module (memory 1) (func (drop (v16x8.load_splat align=1 (i32.const 0)))))
42-
(module (memory 1) (func (drop (v16x8.load_splat align=2 (i32.const 0)))))
43-
(module (memory 1) (func (drop (v32x4.load_splat align=1 (i32.const 0)))))
44-
(module (memory 1) (func (drop (v32x4.load_splat align=2 (i32.const 0)))))
45-
(module (memory 1) (func (drop (v32x4.load_splat align=4 (i32.const 0)))))
46-
(module (memory 1) (func (drop (v64x2.load_splat align=1 (i32.const 0)))))
47-
(module (memory 1) (func (drop (v64x2.load_splat align=2 (i32.const 0)))))
48-
(module (memory 1) (func (drop (v64x2.load_splat align=4 (i32.const 0)))))
49-
(module (memory 1) (func (drop (v64x2.load_splat align=8 (i32.const 0)))))
40+
(module (memory 1) (func (drop (v128.load8_splat align=1 (i32.const 0)))))
41+
(module (memory 1) (func (drop (v128.load16_splat align=1 (i32.const 0)))))
42+
(module (memory 1) (func (drop (v128.load16_splat align=2 (i32.const 0)))))
43+
(module (memory 1) (func (drop (v128.load32_splat align=1 (i32.const 0)))))
44+
(module (memory 1) (func (drop (v128.load32_splat align=2 (i32.const 0)))))
45+
(module (memory 1) (func (drop (v128.load32_splat align=4 (i32.const 0)))))
46+
(module (memory 1) (func (drop (v128.load64_splat align=1 (i32.const 0)))))
47+
(module (memory 1) (func (drop (v128.load64_splat align=2 (i32.const 0)))))
48+
(module (memory 1) (func (drop (v128.load64_splat align=4 (i32.const 0)))))
49+
(module (memory 1) (func (drop (v128.load64_splat align=8 (i32.const 0)))))
5050

5151
;; Invalid alignment
5252

@@ -83,19 +83,19 @@
8383
"alignment must not be larger than natural"
8484
)
8585
(assert_invalid
86-
(module (memory 1) (func (result v128) (v8x16.load_splat align=2 (i32.const 0))))
86+
(module (memory 1) (func (result v128) (v128.load8_splat align=2 (i32.const 0))))
8787
"alignment must not be larger than natural"
8888
)
8989
(assert_invalid
90-
(module (memory 1) (func (result v128) (v16x8.load_splat align=4 (i32.const 0))))
90+
(module (memory 1) (func (result v128) (v128.load16_splat align=4 (i32.const 0))))
9191
"alignment must not be larger than natural"
9292
)
9393
(assert_invalid
94-
(module (memory 1) (func (result v128) (v32x4.load_splat align=8 (i32.const 0))))
94+
(module (memory 1) (func (result v128) (v128.load32_splat align=8 (i32.const 0))))
9595
"alignment must not be larger than natural"
9696
)
9797
(assert_invalid
98-
(module (memory 1) (func (result v128) (v64x2.load_splat align=16 (i32.const 0))))
98+
(module (memory 1) (func (result v128) (v128.load64_splat align=16 (i32.const 0))))
9999
"alignment must not be larger than natural"
100100
)
101101

@@ -247,61 +247,61 @@
247247
)
248248
(assert_malformed
249249
(module quote
250-
"(memory 1) (func (result v128) (v8x16.load_splat align=-1 (i32.const 0)))"
250+
"(memory 1) (func (result v128) (v128.load8_splat align=-1 (i32.const 0)))"
251251
)
252252
"alignment must be a power of two"
253253
)
254254
(assert_malformed
255255
(module quote
256-
"(memory 1) (func (result v128) (v8x16.load_splat align=0 (i32.const 0)))"
256+
"(memory 1) (func (result v128) (v128.load8_splat align=0 (i32.const 0)))"
257257
)
258258
"alignment must be a power of two"
259259
)
260260
(assert_malformed
261261
(module quote
262-
"(memory 1) (func (result v128) (v16x8.load_splat align=-1 (i32.const 0)))"
262+
"(memory 1) (func (result v128) (v128.load16_splat align=-1 (i32.const 0)))"
263263
)
264264
"alignment must be a power of two"
265265
)
266266
(assert_malformed
267267
(module quote
268-
"(memory 1) (func (result v128) (v16x8.load_splat align=0 (i32.const 0)))"
268+
"(memory 1) (func (result v128) (v128.load16_splat align=0 (i32.const 0)))"
269269
)
270270
"alignment must be a power of two"
271271
)
272272
(assert_malformed
273273
(module quote
274-
"(memory 1) (func (result v128) (v32x4.load_splat align=-1 (i32.const 0)))"
274+
"(memory 1) (func (result v128) (v128.load32_splat align=-1 (i32.const 0)))"
275275
)
276276
"alignment must be a power of two"
277277
)
278278
(assert_malformed
279279
(module quote
280-
"(memory 1) (func (result v128) (v32x4.load_splat align=0 (i32.const 0)))"
280+
"(memory 1) (func (result v128) (v128.load32_splat align=0 (i32.const 0)))"
281281
)
282282
"alignment must be a power of two"
283283
)
284284
(assert_malformed
285285
(module quote
286-
"(memory 1) (func (result v128) (v32x4.load_splat align=3 (i32.const 0)))"
286+
"(memory 1) (func (result v128) (v128.load32_splat align=3 (i32.const 0)))"
287287
)
288288
"alignment must be a power of two"
289289
)
290290
(assert_malformed
291291
(module quote
292-
"(memory 1) (func (result v128) (v64x2.load_splat align=-1 (i32.const 0)))"
292+
"(memory 1) (func (result v128) (v128.load64_splat align=-1 (i32.const 0)))"
293293
)
294294
"alignment must be a power of two"
295295
)
296296
(assert_malformed
297297
(module quote
298-
"(memory 1) (func (result v128) (v64x2.load_splat align=0 (i32.const 0)))"
298+
"(memory 1) (func (result v128) (v128.load64_splat align=0 (i32.const 0)))"
299299
)
300300
"alignment must be a power of two"
301301
)
302302
(assert_malformed
303303
(module quote
304-
"(memory 1) (func (result v128) (v64x2.load_splat align=7 (i32.const 0)))"
304+
"(memory 1) (func (result v128) (v128.load64_splat align=7 (i32.const 0)))"
305305
)
306306
"alignment must be a power of two"
307307
)

0 commit comments

Comments
 (0)