Skip to content

Commit 170f171

Browse files
WasiqBWasiqB
committed
fix: 🐛 fixed dark mode issue with CDN
1 parent 1bbcd5e commit 170f171

File tree

2 files changed

+49
-38
lines changed

2 files changed

+49
-38
lines changed

‎templates/feature-overview.index.tmpl

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,42 @@
1111
<title><%= pageTitle %></title>
1212

1313
<% if (useCDN) { %>
14-
<!-- Bootstrap -->
15-
<link href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/5.3.0/css/bootstrap.min.css" rel="stylesheet">
16-
<link href="https://cdn.datatables.net/2.2.2/css/dataTables.bootstrap5.min.css" rel="stylesheet">
17-
<link href="https://cdn.datatables.net/responsive/3.0.4/css/responsive.bootstrap5.min.css" rel="stylesheet">
14+
<!-- Bootstrap -->
15+
<link href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/5.3.0/css/bootstrap.min.css" rel="stylesheet">
16+
<link href="https://cdn.datatables.net/2.2.2/css/dataTables.bootstrap5.min.css" rel="stylesheet">
17+
<link href="https://cdn.datatables.net/responsive/3.0.4/css/responsive.bootstrap5.min.css" rel="stylesheet">
1818

19-
<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
20-
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
19+
<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
20+
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
2121

22-
<!--[if lt IE 9]>
23-
<script src="https://cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.3/html5shiv.min.js"></script>
24-
<script src="https://cdnjs.cloudflare.com/ajax/libs/respond.js/1.4.2/respond.min.js"></script>
25-
<![endif]-->
22+
<!--[if lt IE 9]>
23+
<script src="https://cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.3/html5shiv.min.js"></script>
24+
<script src="https://cdnjs.cloudflare.com/ajax/libs/respond.js/1.4.2/respond.min.js"></script>
25+
<![endif]-->
2626

27-
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" />
27+
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" />
28+
29+
<!-- Darkmode -->
30+
<script>
31+
<%= darkmodeScript %>
32+
</script>
2833
<% } else { %>
29-
<!-- Bootstrap -->
30-
<link rel="stylesheet" href="../assets/css/bootstrap.min.css" >
31-
<link rel="stylesheet" href="../assets/css/dataTables.bootstrap.min.css" >
32-
<link rel="stylesheet" href="../assets/css/responsive.bootstrap5.min.css" >
34+
<script src="../assets/js/darkmode.js"></script>
35+
36+
<!-- Bootstrap -->
37+
<link rel="stylesheet" href="../assets/css/bootstrap.min.css" >
38+
<link rel="stylesheet" href="../assets/css/dataTables.bootstrap.min.css" >
39+
<link rel="stylesheet" href="../assets/css/responsive.bootstrap5.min.css" >
3340

34-
<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
35-
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
41+
<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
42+
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
3643

37-
<!--[if lt IE 9]>
38-
<script src="../assets/js/html5shiv.min.js"></script>
39-
<script src="../assets/js/respond.min.js"></script>
40-
<![endif]-->
44+
<!--[if lt IE 9]>
45+
<script src="../assets/js/html5shiv.min.js"></script>
46+
<script src="../assets/js/respond.min.js"></script>
47+
<![endif]-->
4148

42-
<link href="../assets/css/font-awesome.min.css" rel="stylesheet">
49+
<link href="../assets/css/font-awesome.min.css" rel="stylesheet">
4350
<% } %>
4451

4552
<!-- Custom Theme Style -->
@@ -147,7 +154,7 @@
147154
<% if (!pageFooter) { %>
148155
<div class="created-by">
149156
<p>Maintained by Wasiq Bhamla. Find me on:</p>
150-
<a href="https://www.youtube.com/@WasiqBhamla" target="_blank"><i class="fa fa-rss-square fa-2x"></i></a>
157+
<a href="https://www.youtube.com/@WasiqBhamla" target="_blank"><i class="fa fa-youtube-square fa-2x"></i></a>
151158
<a href="https://github.com/WasiqB/" target="_blank"><i class="fa fa-github-square fa-2x"></i></a>
152159
<a href="https://www.linkedin.com/in/wasiqbhamla/" target="_blank"><i class="fa fa-linkedin-square fa-2x"></i></a>
153160
<a href="https://stackoverflow.com/users/5320558/wasiq-bhamla" target="_blank"><i class="fa fa-stack-overflow fa-2x"></i></a>

‎templates/features-overview.index.tmpl

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<!DOCTYPE html>
22
<html lang="en">
33
<head>
4-
<script src="assets/js/darkmode.js"></script>
54
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
65
<!-- Meta, title, CSS, favicons, etc. -->
76
<meta charset="utf-8">
@@ -25,20 +24,25 @@
2524

2625
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" />
2726

27+
<!-- Darkmode -->
28+
<script>
29+
<%= darkmodeScript %>
30+
</script>
2831
<% } else { %>
29-
<!-- Bootstrap -->
30-
<link rel="stylesheet" href="assets/css/bootstrap.min.css" >
31-
<link rel="stylesheet" href="assets/css/dataTables.bootstrap.min.css" >
32-
<link rel="stylesheet" href="assets/css/responsive.bootstrap5.min.css" >
33-
34-
<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
35-
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
36-
37-
<!--[if lt IE 9]>
38-
<script src="assets/js/html5shiv.min.js"></script>
39-
<script src="assets/js/respond.min.js"></script>
40-
<![endif]-->
41-
<link href="assets/css/font-awesome.min.css" rel="stylesheet">
32+
<script src="assets/js/darkmode.js"></script>
33+
<!-- Bootstrap -->
34+
<link rel="stylesheet" href="assets/css/bootstrap.min.css" >
35+
<link rel="stylesheet" href="assets/css/dataTables.bootstrap.min.css" >
36+
<link rel="stylesheet" href="assets/css/responsive.bootstrap5.min.css" >
37+
38+
<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->
39+
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
40+
41+
<!--[if lt IE 9]>
42+
<script src="assets/js/html5shiv.min.js"></script>
43+
<script src="assets/js/respond.min.js"></script>
44+
<![endif]-->
45+
<link href="assets/css/font-awesome.min.css" rel="stylesheet">
4246
<% } %>
4347

4448
<!-- Custom Theme Style -->
@@ -91,7 +95,7 @@
9195
<% if (!pageFooter) { %>
9296
<div class="created-by">
9397
<p>Maintained by Wasiq Bhamla. Find me on:</p>
94-
<a href="https://www.youtube.com/@WasiqBhamla" target="_blank"><i class="fa fa-rss-square fa-2x"></i></a>
98+
<a href="https://www.youtube.com/@WasiqBhamla" target="_blank"><i class="fa fa-youtube-square fa-2x"></i></a>
9599
<a href="https://github.com/WasiqB/" target="_blank"><i class="fa fa-github-square fa-2x"></i></a>
96100
<a href="https://www.linkedin.com/in/wasiqbhamla/" target="_blank"><i class="fa fa-linkedin-square fa-2x"></i></a>
97101
<a href="https://stackoverflow.com/users/5320558/wasiq-bhamla" target="_blank"><i class="fa fa-stack-overflow fa-2x"></i></a>

0 commit comments

Comments
 (0)