removed extraneous logging imports and loggers

Author: anupambhatnagar

ml-agents-envs/mlagents_envs/communicator.py

@@ -1,11 +1,7 @@
-import logging
 from typing import Optional
-
 from mlagents_envs.communicator_objects.unity_output_pb2 import UnityOutputProto
 from mlagents_envs.communicator_objects.unity_input_pb2 import UnityInputProto
 
-logger = logging.getLogger("mlagents_envs")
-
 
 class Communicator(object):
     def __init__(self, worker_id=0, base_port=5005):

ml-agents-envs/mlagents_envs/exception.py

@@ -1,8 +1,3 @@
-import logging
-
-logger = logging.getLogger("mlagents_envs")
-
-
 class UnityException(Exception):
     """
     Any error related to ml-agents environment.

ml-agents-envs/mlagents_envs/rpc_communicator.py

@@ -1,4 +1,3 @@
-import logging
 import grpc
 from typing import Optional
 
@@ -16,8 +15,6 @@
 from mlagents_envs.communicator_objects.unity_output_pb2 import UnityOutputProto
 from .exception import UnityTimeOutException, UnityWorkerInUseException
 
-logger = logging.getLogger("mlagents_envs")
-
 
 class UnityToExternalServicerImplementation(UnityToExternalProtoServicer):
     def __init__(self):

ml-agents-envs/mlagents_envs/rpc_utils.py

@@ -7,14 +7,11 @@
     NONE as COMPRESSION_NONE,
 )
 from mlagents_envs.communicator_objects.brain_parameters_pb2 import BrainParametersProto
-import logging
 import numpy as np
 import io
 from typing import cast, List, Tuple, Union, Collection, Optional, Iterable
 from PIL import Image
 
-logger = logging.getLogger("mlagents_envs")
-
 
 def agent_group_spec_from_proto(
     brain_param_proto: BrainParametersProto, agent_info: AgentInfoProto

ml-agents/mlagents/logging_util.py

@@ -3,15 +3,9 @@
 
 def create_logger(name):
     log_level = logging.INFO
+    date_format = "%Y-%m-%d %H:%M:%S"
     log_format = "%(asctime)s %(levelname)s [%(filename)s:%(lineno)d] %(message)s"
-    logging.basicConfig(level=log_level, format=log_format, datefmt="%Y-%m-%d %H:%M:%S")
+
+    logging.basicConfig(level=log_level, format=log_format, datefmt=date_format)
     logger = logging.getLogger(name=name)
     return logger
-
-
-# TODO
-"""
-1. change mlagents.trainers to mlagents_trainers
-2. logger should be in lowercase in all files
-3. if logger is not used in a file then it should be deleted
-"""

ml-agents/mlagents/trainers/brain.py

@@ -1,11 +1,7 @@
-import logging
-
 from mlagents_envs.communicator_objects.agent_info_pb2 import AgentInfoProto
 from mlagents_envs.communicator_objects.brain_parameters_pb2 import BrainParametersProto
 from typing import List, NamedTuple
 
-logger = logging.getLogger("mlagents.trainers")
-
 
 class CameraResolution(NamedTuple):
     height: int

ml-agents/mlagents/trainers/components/reward_signals/gail/signal.py

@@ -1,5 +1,4 @@
 from typing import Any, Dict, List
-import logging
 import numpy as np
 from mlagents.tf_utils import tf
 
@@ -8,8 +7,6 @@
 from .model import GAILModel
 from mlagents.trainers.demo_loader import demo_to_buffer
 
-LOGGER = logging.getLogger("mlagents.trainers")
-
 
 class GAILRewardSignal(RewardSignal):
     def __init__(

ml-agents/mlagents/trainers/components/reward_signals/reward_signal_factory.py

@@ -1,6 +1,4 @@
-import logging
 from typing import Any, Dict, Type
-
 from mlagents.trainers.exception import UnityTrainerException
 from mlagents.trainers.components.reward_signals import RewardSignal
 from mlagents.trainers.components.reward_signals.extrinsic.signal import (
@@ -12,8 +10,6 @@
 )
 from mlagents.trainers.policy.tf_policy import TFPolicy
 
-logger = logging.getLogger("mlagents.trainers")
-
 
 NAME_TO_CLASS: Dict[str, Type[RewardSignal]] = {
     "extrinsic": ExtrinsicRewardSignal,

ml-agents/mlagents/trainers/demo_loader.py

@@ -1,4 +1,3 @@
-import logging
 import os
 from typing import List, Tuple
 import numpy as np
@@ -22,9 +21,6 @@
 from google.protobuf.internal.decoder import _DecodeVarint32  # type: ignore
 
 
-logger = logging.getLogger("mlagents.trainers")
-
-
 @timed
 def make_demo_buffer(
     pair_infos: List[AgentInfoActionPairProto],

ml-agents/mlagents/trainers/ghost/trainer.py

@@ -1,7 +1,6 @@
 # # Unity ML-Agents Toolkit
 # ## ML-Agent Learning (Ghost Trainer)
 
-# import logging
 from typing import Deque, Dict, List, Any, cast
 
 import numpy as np
@@ -15,7 +14,7 @@
 from mlagents.trainers.trajectory import Trajectory
 from mlagents.trainers.agent_processor import AgentManagerQueue
 
-LOGGER = logging.getLogger("mlagents.trainers")
+logger = logging.getLogger("mlagents.trainers")
 
 
 class GhostTrainer(Trainer):
@@ -93,7 +92,7 @@ def _write_summary(self, step: int) -> None:
         Saves training statistics to Tensorboard.
         """
         opponents = np.array(self.policy_elos, dtype=np.float32)
-        LOGGER.info(
+        logger.info(
             " Learning brain {} ELO: {:0.3f}\n"
             "Mean Opponent ELO: {:0.3f}"
             " Std Opponent ELO: {:0.3f}".format(
@@ -234,7 +233,7 @@ def _swap_snapshots(self) -> None:
                 x = "current"
                 self.policy_elos[-1] = self.current_elo
             self.current_opponent = -1 if x == "current" else x
-            LOGGER.debug(
+            logger.debug(
                 "Step {}: Swapping snapshot {} to id {} with {} learning".format(
                     self.get_step, x, name_behavior_id, self.learning_behavior_name
                 )