Revert "fix(storage): resolve race condition in memory store" (#1271)

Revert "fix(storage): resolve race condition in memory store (#1270)"

This reverts commit 83c4fac.

Author: TwiN

storage/store/memory/memory.go

@@ -49,7 +49,7 @@ func (s *Store) GetAllEndpointStatuses(params *paging.EndpointStatusParams) ([]*
 	pagedEndpointStatuses := make([]*endpoint.Status, 0, len(allStatuses))
 	for _, v := range allStatuses {
 		if status, ok := v.(*endpoint.Status); ok {
-			pagedEndpointStatuses = append(pagedEndpointStatuses, CopyEndpointStatus(status, params))
+			pagedEndpointStatuses = append(pagedEndpointStatuses, ShallowCopyEndpointStatus(status, params))
 		}
 	}
 	sort.Slice(pagedEndpointStatuses, func(i, j int) bool {
@@ -87,7 +87,7 @@ func (s *Store) GetEndpointStatusByKey(key string, params *paging.EndpointStatus
 	if endpointStatus == nil {
 		return nil, common.ErrEndpointNotFound
 	}
-	return CopyEndpointStatus(endpointStatus.(*endpoint.Status), params), nil
+	return ShallowCopyEndpointStatus(endpointStatus.(*endpoint.Status), params), nil
 }
 
 // GetSuiteStatusByKey returns the suite status for a given key

storage/store/memory/util.go

@@ -6,47 +6,35 @@ import (
 	"github.com/TwiN/gatus/v5/storage/store/common/paging"
 )
 
-// CopyEndpointStatus returns a safe copy of a Status with only the results
-// within the range defined by the page and pageSize parameters.
-// This function performs deep copying of slices to prevent race conditions
-// when the original slice is modified concurrently.
-func CopyEndpointStatus(ss *endpoint.Status, params *paging.EndpointStatusParams) *endpoint.Status {
-	statusCopy := &endpoint.Status{
+// ShallowCopyEndpointStatus returns a shallow copy of a Status with only the results
+// within the range defined by the page and pageSize parameters
+func ShallowCopyEndpointStatus(ss *endpoint.Status, params *paging.EndpointStatusParams) *endpoint.Status {
+	shallowCopy := &endpoint.Status{
 		Name:   ss.Name,
 		Group:  ss.Group,
 		Key:    ss.Key,
 		Uptime: endpoint.NewUptime(),
 	}
 	if params == nil || (params.ResultsPage == 0 && params.ResultsPageSize == 0 && params.EventsPage == 0 && params.EventsPageSize == 0) {
-		// Deep copy all results to prevent race conditions
-		statusCopy.Results = make([]*endpoint.Result, len(ss.Results))
-		copy(statusCopy.Results, ss.Results)
-		// Deep copy all events to prevent race conditions
-		statusCopy.Events = make([]*endpoint.Event, len(ss.Events))
-		copy(statusCopy.Events, ss.Events)
+		shallowCopy.Results = ss.Results
+		shallowCopy.Events = ss.Events
 	} else {
 		numberOfResults := len(ss.Results)
 		resultsStart, resultsEnd := getStartAndEndIndex(numberOfResults, params.ResultsPage, params.ResultsPageSize)
 		if resultsStart < 0 || resultsEnd < 0 {
-			statusCopy.Results = []*endpoint.Result{}
+			shallowCopy.Results = []*endpoint.Result{}
 		} else {
-			// Deep copy the slice range to prevent race conditions
-			resultRange := ss.Results[resultsStart:resultsEnd]
-			statusCopy.Results = make([]*endpoint.Result, len(resultRange))
-			copy(statusCopy.Results, resultRange)
+			shallowCopy.Results = ss.Results[resultsStart:resultsEnd]
 		}
 		numberOfEvents := len(ss.Events)
 		eventsStart, eventsEnd := getStartAndEndIndex(numberOfEvents, params.EventsPage, params.EventsPageSize)
 		if eventsStart < 0 || eventsEnd < 0 {
-			statusCopy.Events = []*endpoint.Event{}
+			shallowCopy.Events = []*endpoint.Event{}
 		} else {
-			// Deep copy the slice range to prevent race conditions
-			eventRange := ss.Events[eventsStart:eventsEnd]
-			statusCopy.Events = make([]*endpoint.Event, len(eventRange))
-			copy(statusCopy.Events, eventRange)
+			shallowCopy.Events = ss.Events[eventsStart:eventsEnd]
 		}
 	}
-	return statusCopy
+	return shallowCopy
 }
 
 // ShallowCopySuiteStatus returns a shallow copy of a suite Status with only the results

storage/store/memory/util_bench_test.go

@@ -8,14 +8,14 @@ import (
 	"github.com/TwiN/gatus/v5/storage/store/common/paging"
 )
 
-func BenchmarkCopyEndpointStatus(b *testing.B) {
+func BenchmarkShallowCopyEndpointStatus(b *testing.B) {
 	ep := &testEndpoint
 	status := endpoint.NewStatus(ep.Group, ep.Name)
 	for i := 0; i < storage.DefaultMaximumNumberOfResults; i++ {
 		AddResult(status, &testSuccessfulResult, storage.DefaultMaximumNumberOfResults, storage.DefaultMaximumNumberOfEvents)
 	}
 	for n := 0; n < b.N; n++ {
-		CopyEndpointStatus(status, paging.NewEndpointStatusParams().WithResults(1, 20))
+		ShallowCopyEndpointStatus(status, paging.NewEndpointStatusParams().WithResults(1, 20))
 	}
 	b.ReportAllocs()
 }

storage/store/memory/util_test.go

@@ -26,42 +26,42 @@ func TestAddResult(t *testing.T) {
 	AddResult(nil, &endpoint.Result{Timestamp: time.Now()}, storage.DefaultMaximumNumberOfResults, storage.DefaultMaximumNumberOfEvents)
 }
 
-func TestCopyEndpointStatus(t *testing.T) {
+func TestShallowCopyEndpointStatus(t *testing.T) {
 	ep := &endpoint.Endpoint{Name: "name", Group: "group"}
 	endpointStatus := endpoint.NewStatus(ep.Group, ep.Name)
 	ts := time.Now().Add(-25 * time.Hour)
 	for i := 0; i < 25; i++ {
 		AddResult(endpointStatus, &endpoint.Result{Success: i%2 == 0, Timestamp: ts}, storage.DefaultMaximumNumberOfResults, storage.DefaultMaximumNumberOfEvents)
 		ts = ts.Add(time.Hour)
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(-1, -1)).Results) != 0 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(-1, -1)).Results) != 0 {
 		t.Error("expected to have 0 result")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, 1)).Results) != 1 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, 1)).Results) != 1 {
 		t.Error("expected to have 1 result")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(5, 0)).Results) != 0 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(5, 0)).Results) != 0 {
 		t.Error("expected to have 0 results")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(-1, 20)).Results) != 0 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(-1, 20)).Results) != 0 {
 		t.Error("expected to have 0 result, because the page was invalid")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, -1)).Results) != 0 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, -1)).Results) != 0 {
 		t.Error("expected to have 0 result, because the page size was invalid")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, 10)).Results) != 10 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, 10)).Results) != 10 {
 		t.Error("expected to have 10 results, because given a page size of 10, page 1 should have 10 elements")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(2, 10)).Results) != 10 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(2, 10)).Results) != 10 {
 		t.Error("expected to have 10 results, because given a page size of 10, page 2 should have 10 elements")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(3, 10)).Results) != 5 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(3, 10)).Results) != 5 {
 		t.Error("expected to have 5 results, because given a page size of 10, page 3 should have 5 elements")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(4, 10)).Results) != 0 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(4, 10)).Results) != 0 {
 		t.Error("expected to have 0 results, because given a page size of 10, page 4 should have 0 elements")
 	}
-	if len(CopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, 50)).Results) != 25 {
+	if len(ShallowCopyEndpointStatus(endpointStatus, paging.NewEndpointStatusParams().WithResults(1, 50)).Results) != 25 {
 		t.Error("expected to have 25 results, because there's only 25 results")
 	}
 }