Skip to content

Commit 65c30db

Browse files
committed
fix: upgrade proto to v0.2.37
1 parent dddc3f4 commit 65c30db

30 files changed

Lines changed: 105 additions & 438 deletions

File tree

app/porter/internal/service/librarianporterservice.go

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,15 @@ func (s *LibrarianPorterServiceService) PullApp(
125125
Type: ToPBAppType(a.Type),
126126
ShortDescription: a.ShortDescription,
127127
IconImageUrl: "",
128+
HeroImageUrl: a.HeroImageURL,
128129
Tags: nil,
130+
AppCategoryIds: nil,
129131
Details: &librarian.AppDetails{ // TODO
130-
Description: a.Description,
131-
ReleaseDate: a.ReleaseDate,
132-
Developer: a.Developer,
133-
Publisher: a.Publisher,
134-
Version: "",
135-
HeroImageUrl: a.HeroImageURL,
136-
LogoImageUrl: "",
132+
Description: a.Description,
133+
ReleaseDate: a.ReleaseDate,
134+
Developer: a.Developer,
135+
Publisher: a.Publisher,
136+
Version: "",
137137
},
138138
}}, nil
139139
default:
@@ -163,16 +163,10 @@ func (s *LibrarianPorterServiceService) PullAccountAppRelation(
163163
Type: 0,
164164
ShortDescription: "",
165165
IconImageUrl: a.IconImageURL,
166+
HeroImageUrl: a.HeroImageURL,
166167
Tags: nil,
167-
Details: &librarian.AppDetails{
168-
Description: "",
169-
ReleaseDate: "",
170-
Developer: "",
171-
Publisher: "",
172-
Version: "",
173-
HeroImageUrl: "",
174-
LogoImageUrl: a.LogoImageURL,
175-
},
168+
AppCategoryIds: nil,
169+
Details: nil,
176170
}
177171
}
178172
return &pb.PullAccountAppRelationResponse{AppList: appList}, nil

app/searcher/internal/biz/searcher.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
type SearcherRepo interface {
1010
NewID(context.Context) (int64, error)
11-
DescribeID(context.Context, model.InternalID, string) error
11+
DescribeID(context.Context, model.InternalID, bool, string) error
1212
SearchID(context.Context, model.Paging, string) ([]*SearchResult, error)
1313
}
1414

@@ -41,8 +41,8 @@ func (g *Searcher) NewBatchIDs(ctx context.Context, num int) ([]int64, error) {
4141
return res, nil
4242
}
4343

44-
func (g *Searcher) DescribeID(ctx context.Context, id model.InternalID, description string) error {
45-
return g.repo.DescribeID(ctx, id, description)
44+
func (g *Searcher) DescribeID(ctx context.Context, id model.InternalID, append_ bool, description string) error {
45+
return g.repo.DescribeID(ctx, id, append_, description)
4646
}
4747

4848
func (g *Searcher) SearchID(ctx context.Context, paging model.Paging, keyword string) ([]*SearchResult, error) {

app/searcher/internal/data/bleve.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewBleve(conf *conf.Searcher_Data, app *libapp.Settings) (bleve.Index, erro
4141
return index, nil
4242
}
4343

44-
func (r *bleveSearcherRepo) DescribeID(ctx context.Context, id model.InternalID, description string) error {
44+
func (r *bleveSearcherRepo) DescribeID(ctx context.Context, id model.InternalID, _ bool, description string) error {
4545
var jsonDesc interface{}
4646
err := libcodec.Unmarshal(libcodec.JSON, []byte(description), &jsonDesc)
4747
if err == nil {

app/searcher/internal/data/bleve_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ func Test_bleveSearcherRepo_SearchID(t *testing.T) {
6767
if err != nil {
6868
return
6969
}
70-
if err = r.DescribeID(context.Background(), model.InternalID(i), string(str)); err != nil {
70+
if err = r.DescribeID(context.Background(), model.InternalID(i), false, string(str)); err != nil {
7171
t.Errorf("DescribeID() error = %v", err)
7272
}
7373
}

app/searcher/internal/data/meili.go

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,23 +37,29 @@ type document struct {
3737
Description interface{}
3838
}
3939

40-
func (m *meiliSearcherRepo) DescribeID(ctx context.Context, id model.InternalID, description string) error {
40+
func (m *meiliSearcherRepo) DescribeID(
41+
ctx context.Context, id model.InternalID, append_ bool, description string,
42+
) error {
4143
var jsonDesc interface{}
4244
err := libcodec.Unmarshal(libcodec.JSON, []byte(description), &jsonDesc)
45+
var documents map[string]interface{}
4346
if err == nil {
44-
documents := map[string]interface{}{
47+
documents = map[string]interface{}{
4548
"id": id,
4649
"description": jsonDesc,
4750
}
48-
_, err = m.search.Index(IndexName).AddDocuments(documents)
49-
if err != nil {
50-
return err
51-
}
5251
} else {
53-
documents := map[string]interface{}{
52+
documents = map[string]interface{}{
5453
"id": id,
5554
"description": description,
5655
}
56+
}
57+
if append_ {
58+
_, err = m.search.Index(IndexName).UpdateDocuments(documents)
59+
if err != nil {
60+
return err
61+
}
62+
} else {
5763
_, err = m.search.Index(IndexName).AddDocuments(documents)
5864
if err != nil {
5965
return err

app/searcher/internal/service/librariansearcherservice.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,12 @@ func (s *LibrarianSearcherServiceService) NewBatchIDs(ctx context.Context, req *
4848
}
4949
func (s *LibrarianSearcherServiceService) DescribeID(ctx context.Context, req *pb.DescribeIDRequest) (
5050
*pb.DescribeIDResponse, error) {
51-
err := s.uc.DescribeID(ctx, model.InternalID(req.GetId().GetId()), req.GetDescription())
51+
err := s.uc.DescribeID(
52+
ctx,
53+
model.InternalID(req.GetId().GetId()),
54+
req.GetMode() == pb.DescribeIDRequest_DESCRIBE_MODE_APPEND,
55+
req.GetDescription(),
56+
)
5257
if err != nil {
5358
return nil, err
5459
}

app/searcher/internal/service/service_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func (m *mockedSearcherRepo) NewID(ctx context.Context) (int64, error) {
2323
return args.Get(0).(int64), args.Error(1)
2424
}
2525

26-
func (m *mockedSearcherRepo) DescribeID(ctx context.Context, id model.InternalID, s string) error {
26+
func (m *mockedSearcherRepo) DescribeID(ctx context.Context, id model.InternalID, b bool, s string) error {
2727
// TODO implement me
2828
panic("implement me")
2929
}

app/sephirah/internal/biz/bizchesed/chesed.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ func (c *Chesed) ScanImage(ctx context.Context) {
181181
Id: converter.ToPBInternalID(image.ID),
182182
Description: string(desReqStr),
183183
Mode: searcher.DescribeIDRequest_DESCRIBE_MODE_APPEND,
184+
Index: searcher.Index_INDEX_CHESED_IMAGE,
184185
})
185186
if err != nil {
186187
return
@@ -223,6 +224,7 @@ func (c *Chesed) SearchImages(ctx context.Context, paging model.Paging, keywords
223224
PageSize: int32(paging.PageSize),
224225
},
225226
Keyword: keywords,
227+
Index: searcher.Index_INDEX_CHESED_IMAGE,
226228
},
227229
)
228230
if err != nil {

app/sephirah/internal/biz/bizgebura/app.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,9 @@ func (g *Gebura) GetApp(ctx context.Context, id model.InternalID) (*modelgebura.
126126
if len(internalApp.IconImageURL) == 0 {
127127
internalApp.IconImageURL = steamApp.IconImageURL
128128
}
129+
if len(internalApp.HeroImageURL) == 0 {
130+
internalApp.HeroImageURL = steamApp.HeroImageURL
131+
}
129132
if internalApp.Details == nil { //nolint:nestif //TODO
130133
internalApp.Details = steamApp.Details
131134
} else if steamApp.Details != nil {
@@ -144,12 +147,6 @@ func (g *Gebura) GetApp(ctx context.Context, id model.InternalID) (*modelgebura.
144147
if len(internalApp.Details.Version) == 0 {
145148
internalApp.Details.Version = steamApp.Details.Version
146149
}
147-
if len(internalApp.Details.HeroImageURL) == 0 {
148-
internalApp.Details.HeroImageURL = steamApp.Details.HeroImageURL
149-
}
150-
if len(internalApp.Details.LogoImageURL) == 0 {
151-
internalApp.Details.LogoImageURL = steamApp.Details.LogoImageURL
152-
}
153150
}
154151
return internalApp, nil
155152
}

app/sephirah/internal/biz/biztiphereth/tiphereth.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type TipherethRepo interface {
2727
*model.InternalID) ([]*modeltiphereth.User, int64, error)
2828
LinkAccount(context.Context, modeltiphereth.Account, model.InternalID) error
2929
UnLinkAccount(context.Context, modeltiphereth.Account, model.InternalID) error
30-
ListLinkAccounts(context.Context, model.Paging, model.InternalID) ([]*modeltiphereth.Account, int64, error)
30+
ListLinkAccounts(context.Context, model.InternalID) ([]*modeltiphereth.Account, error)
3131
GetUser(context.Context, model.InternalID) (*modeltiphereth.User, error)
3232
}
3333

@@ -356,21 +356,21 @@ func (t *Tiphereth) UnLinkAccount(ctx context.Context, a modeltiphereth.Account)
356356
}
357357

358358
func (t *Tiphereth) ListLinkAccounts(
359-
ctx context.Context, paging model.Paging, id model.InternalID,
360-
) ([]*modeltiphereth.Account, int64, *errors.Error) {
359+
ctx context.Context, id model.InternalID,
360+
) ([]*modeltiphereth.Account, *errors.Error) {
361361
if !libauth.FromContextAssertUserType(ctx, libauth.UserTypeAdmin, libauth.UserTypeNormal) {
362-
return nil, 0, pb.ErrorErrorReasonForbidden("no permission")
362+
return nil, pb.ErrorErrorReasonForbidden("no permission")
363363
}
364364
claims, exist := libauth.FromContext(ctx)
365365
if !exist {
366-
return nil, 0, pb.ErrorErrorReasonUnauthorized("invalid token")
366+
return nil, pb.ErrorErrorReasonUnauthorized("invalid token")
367367
}
368368
if id == 0 {
369369
id = claims.InternalID
370370
}
371-
a, total, err := t.repo.ListLinkAccounts(ctx, paging, id)
371+
a, err := t.repo.ListLinkAccounts(ctx, id)
372372
if err != nil {
373-
return nil, 0, pb.ErrorErrorReasonUnspecified("%s", err.Error())
373+
return nil, pb.ErrorErrorReasonUnspecified("%s", err.Error())
374374
}
375-
return a, total, nil
375+
return a, nil
376376
}

0 commit comments

Comments
 (0)