Skip to content

Commit 3e32080

Browse files
committed
fix(angela): check publishParsed before sort
1 parent a4ea50a commit 3e32080

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

app/sephirah/internal/biz/bizangela/angela.go

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -313,11 +313,6 @@ func NewPullFeedTopic( //nolint:gocognit // TODO
313313
}
314314
feed := modelfeed.NewConverter().FromPBFeed(resp.GetData())
315315
feed.ID = p.InternalID
316-
sort.Sort(feed)
317-
err = a.y.UpsertFeed(ctx, feed)
318-
if err != nil {
319-
return err
320-
}
321316
for _, item := range feed.Items {
322317
// generate internal_id
323318
var res *searcher.NewIDResponse
@@ -341,6 +336,10 @@ func NewPullFeedTopic( //nolint:gocognit // TODO
341336
item.PublishedParsed = &t
342337
}
343338
}
339+
sort.Sort(feed)
340+
if err = a.y.UpsertFeed(ctx, feed); err != nil {
341+
return err
342+
}
344343
newItemGUIDs, err := a.y.UpsertFeedItems(ctx, feed.Items, feed.ID)
345344
if err != nil {
346345
return err
@@ -357,10 +356,7 @@ func NewPullFeedTopic( //nolint:gocognit // TODO
357356
Messages: newItems,
358357
})
359358
}
360-
if err != nil {
361-
return err
362-
}
363-
return nil
359+
return err
364360
},
365361
)
366362
}

0 commit comments

Comments
 (0)