Skip to content

Commit ddc0e54

Browse files
committed
Restored log key prefixes in structured outbox log messages
1 parent b4b9bb5 commit ddc0e54

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

ghost/core/core/server/services/outbox/handlers/member-created.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ async function handle({payload}) {
1717
event: 'outbox.member_created.no_slug_mapping',
1818
member_status: payload.status
1919
}
20-
}, 'No automated email slug found for member status');
20+
}, `${LOG_KEY} No automated email slug found for member status`);
2121
return;
2222
}
2323

@@ -40,7 +40,7 @@ async function handle({payload}) {
4040
event: 'outbox.member_created.track_send_failed'
4141
},
4242
err
43-
}, 'Failed to track automated email send');
43+
}, `${LOG_KEY} Failed to track automated email send`);
4444
}
4545
}
4646

ghost/core/core/server/services/outbox/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class OutboxServiceWrapper {
2828
system: {
2929
event: 'outbox.processing.skipped_already_running'
3030
}
31-
}, 'Outbox job already running, skipping');
31+
}, `${OUTBOX_LOG_KEY}: Outbox job already running, skipping`);
3232
return;
3333
}
3434
this.processing = true;

ghost/core/test/unit/server/services/outbox/handlers/member-created.test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ describe('member-created handler', function () {
5555
sinon.assert.calledOnce(memberWelcomeEmailServiceStub.api.send);
5656
const errorLog = findByEvent(logCapture.output, 'outbox.member_created.track_send_failed');
5757
assert.ok(errorLog);
58-
assert.ok(errorLog.msg.startsWith('Failed to track automated email send'));
5958
});
6059

6160
it('logs error when tracking fails', async function () {
@@ -74,8 +73,6 @@ describe('member-created handler', function () {
7473

7574
const errorLog = findByEvent(logCapture.output, 'outbox.member_created.track_send_failed');
7675
assert.ok(errorLog);
77-
assert.ok(errorLog.msg.startsWith('Failed to track automated email send'));
78-
assert.ok(errorLog.msg.includes(dbError.message));
7976
});
8077

8178
it('logs warning when status has no slug mapping', async function () {

0 commit comments

Comments
 (0)