🐛 Fixed 404 when navigating between post stats and editor

Author: troyciesco

apps/stats/src/views/Stats/Overview/components/latest-post.tsx

@@ -46,6 +46,21 @@ const LatestPost: React.FC<LatestPostProps> = ({
 
     const metricClassName = 'group mr-2 flex flex-col gap-1.5 hover:cursor-pointer';
 
+    // Determine if we should navigate to editor instead of post analytics
+    // Posts with no email data (never sent as newsletter) have no analytics when webAnalytics and membersTrackSources are disabled
+    // Posts that were emailed (email-only OR published+sent) have newsletter stats, so they should go to analytics
+    const hasEmailData = Boolean(latestPostStats?.email);
+    const shouldGoToEditor = !hasEmailData && 
+                             !appSettings?.analytics.webAnalytics && 
+                             !appSettings?.analytics.membersTrackSources;
+
+    const getPostDestination = (postId: string) => {
+        if (shouldGoToEditor) {
+            return `/editor/post/${postId}`;
+        }
+        return `/posts/analytics/${postId}`;
+    };
+
     return (
         <Card className='group/card bg-gradient-to-tr from-muted/40 to-muted/0 to-50%' data-testid='latest-post'>
             <CardHeader>
@@ -99,7 +114,7 @@ const LatestPost: React.FC<LatestPostProps> = ({
                             <div className='flex grow flex-col items-start justify-center self-stretch'>
                                 <div className='text-lg font-semibold leading-tighter tracking-tight hover:cursor-pointer hover:opacity-75' onClick={() => {
                                     if (!isLoading && latestPostStats) {
-                                        navigate(`/posts/analytics/${latestPostStats.id}`, {crossApp: true});
+                                        navigate(getPostDestination(latestPostStats.id), {crossApp: true});
                                     }
                                 }}>
                                     {latestPostStats.title}
@@ -136,13 +151,22 @@ const LatestPost: React.FC<LatestPostProps> = ({
                                         className={latestPostStats.email_only ? 'w-full' : ''}
                                         variant='outline'
                                         onClick={() => {
-                                            navigate(`/posts/analytics/${latestPostStats.id}`, {crossApp: true});
+                                            navigate(getPostDestination(latestPostStats.id), {crossApp: true});
                                         }}
                                     >
-                                        <LucideIcon.ChartNoAxesColumn />
-                                        <span className='hidden md:!visible md:!block'>
-                                            {!latestPostStats.email_only ? 'Analytics' : 'Post analytics' }
-                                        </span>
+                                        {shouldGoToEditor ? (
+                                            <>
+                                                <LucideIcon.Pen />
+                                                <span className='hidden md:!visible md:!block'>Edit post</span>
+                                            </>
+                                        ) : (
+                                            <>
+                                                <LucideIcon.ChartNoAxesColumn />
+                                                <span className='hidden md:!visible md:!block'>
+                                                    {!latestPostStats.email_only ? 'Analytics' : 'Post analytics'}
+                                                </span>
+                                            </>
+                                        )}
                                     </Button>
                                 </div>
                             </div>

apps/stats/src/views/Stats/Overview/components/top-posts.tsx

@@ -71,6 +71,19 @@ const TopPosts: React.FC<TopPostsProps> = ({
 
     const metricClass = 'flex items-center justify-end gap-1 rounded-md px-2 py-1 font-mono text-gray-800 hover:bg-muted-foreground/10 group-hover:text-foreground';
 
+    // Helper to determine navigation destination based on post type and analytics settings
+    // Posts with no email data (never sent as newsletter) have no analytics when webAnalytics and membersTrackSources are disabled
+    // Posts that were emailed (email-only OR published+sent) have newsletter stats, so they should go to analytics
+    const getPostDestination = (postId: string, hasEmailData: boolean) => {
+        const analyticsDisabled = !appSettings?.analytics.webAnalytics && 
+                                  !appSettings?.analytics.membersTrackSources;
+        
+        if (analyticsDisabled && !hasEmailData) {
+            return `/editor/post/${postId}`;
+        }
+        return `/posts/analytics/${postId}`;
+    };
+
     return (
         <Card className='group/card w-full lg:col-span-2' data-testid='top-posts-card'>
             <CardHeader>
@@ -89,7 +102,7 @@ const TopPosts: React.FC<TopPostsProps> = ({
                                 return (
                                     <div key={post.post_id} className='group relative flex w-full items-start justify-between gap-5 border-t border-border/50 py-4 before:absolute before:-inset-x-4 before:inset-y-0 before:z-0 before:hidden before:rounded-md before:bg-accent before:opacity-80 before:content-[""] first:!border-border hover:cursor-pointer hover:border-transparent hover:before:block md:items-center dark:before:bg-accent/50 [&+div]:hover:border-transparent'>
                                         <div className='z-10 flex min-w-[160px] grow items-start gap-4 md:items-center lg:min-w-[320px]' onClick={() => {
-                                            navigate(`/posts/analytics/${post.post_id}`, {crossApp: true});
+                                            navigate(getPostDestination(post.post_id, post.sent_count !== null), {crossApp: true});
                                         }}>
                                             {post.feature_image ?
                                                 <div className='hidden aspect-[16/10] w-[80px] shrink-0 rounded-sm bg-cover bg-center sm:!visible sm:!block lg:w-[100px]' style={{

ghost/admin/app/routes/lexical-editor.js

@@ -17,13 +17,25 @@ export default AuthenticatedRoute.extend({
     },
 
     setupController(controller, model, transition) {
-        if (transition.from?.name?.startsWith('posts-x') && transition.to?.name !== 'lexical-editor.new') {
-            // Extract the analytics path from window.location.href to preserve the exact tab
-            let currentUrl = window.location.href;
-            // Convert editor URL back to analytics URL and extract just the hash portion
-            let analyticsUrl = currentUrl.replace('/editor/', '/').replace(/\/edit$/, '');
-            let hashMatch = analyticsUrl.match(/#(.+)/);
-            controller.fromAnalytics = hashMatch ? hashMatch[1] : 'posts-x';
+        if (transition.to?.name === 'lexical-editor.new') {
+            return;
+        }
+
+        if (transition.from?.name?.includes('posts-x')) {
+            // Came from post analytics - reconstruct the full analytics URL including tab
+            let postId = transition.from?.parent?.params?.post_id || transition.from?.params?.post_id;
+            if (!postId) {
+                // Fallback: extract post ID from the editor URL hash
+                let hashMatch = window.location.hash.match(/\/editor\/\w+\/([a-f0-9]+)/);
+                postId = hashMatch?.[1] || model?.id;
+            }
+            let sub = transition.from?.params?.sub;
+            controller.fromAnalytics = sub
+                ? `/posts/analytics/${postId}/${sub}`
+                : `/posts/analytics/${postId}`;
+        } else if (transition.from?.name?.includes('stats-x')) {
+            // Came from stats overview
+            controller.fromAnalytics = '/analytics';
         }
     },
 

ghost/admin/tests/acceptance/editor-test.js

@@ -620,7 +620,7 @@ describe('Acceptance: Editor', function () {
             expect(
                 find('[data-test-breadcrumb]').getAttribute('href'),
                 'breadcrumb link'
-            ).to.equal(`#posts-x`);
+            ).to.equal(`#/posts/analytics/${post.id}`);
         });
 
         it('does not render analytics breadcrumb for a new post', async function () {