"serialization rulez" second attempt

Author: chorobin

packages/react-router/tests/router.test.tsx

@@ -59,7 +59,7 @@ export function validateSearchParams<
 }
 
 function createTestRouter(
-  options: RouterOptions<AnyRoute, 'never'> &
+  options: RouterOptions<AnyRoute, 'never', any, any, any, any, any> &
     Required<Pick<RouterOptions<AnyRoute, 'never'>, 'history'>>,
 ) {
   const rootRoute = createRootRoute({

packages/solid-router/tests/router.test.tsx

@@ -47,7 +47,9 @@ export function validateSearchParams<
   expect(router.state.location.search).toEqual(expected)
 }
 
-function createTestRouter(options?: RouterOptions<AnyRoute, 'never'>) {
+function createTestRouter(
+  options?: RouterOptions<AnyRoute, 'never', any, any, any, any, any>,
+) {
   const rootRoute = createRootRoute({
     validateSearch: z.object({ root: z.string().optional() }),
     component: () => {

packages/start-client-core/src/serializer/ServerFunctionSerializationAdapter.ts

@@ -4,7 +4,13 @@ import { TSS_SERVER_FUNCTION } from '../constants'
 
 export const ServerFunctionSerializationAdapter = createSerializationAdapter({
   key: '$TSS/serverfn',
-  test: (v): v is { functionId: string } => v[TSS_SERVER_FUNCTION],
+  test: (v): v is { functionId: string } => {
+    if (typeof v !== 'object' || v === null) return false
+
+    if (!(TSS_SERVER_FUNCTION in v)) return false
+
+    return !!v[TSS_SERVER_FUNCTION]
+  },
   toSerializable: ({ functionId }) => ({ functionId }),
   fromSerializable: ({ functionId }) => createClientRpc(functionId),
 })

packages/start-server-core/src/serializer/ServerFunctionSerializationAdapter.ts

@@ -5,7 +5,13 @@ import { getServerFnById } from '../getServerFnById'
 
 export const ServerFunctionSerializationAdapter = createSerializationAdapter({
   key: '$TSS/serverfn',
-  test: (v): v is { functionId: string } => v[TSS_SERVER_FUNCTION],
+  test: (v): v is { functionId: string } => {
+    if (typeof v !== 'object' || v === null) return false
+
+    if (!(TSS_SERVER_FUNCTION in v)) return false
+
+    return !!v[TSS_SERVER_FUNCTION]
+  },
   toSerializable: ({ functionId }) => ({ functionId }),
   fromSerializable: ({ functionId }) => {
     const fn = async (opts: any, signal: any): Promise<any> => {