Skip to content

Commit 41bf26b

Browse files
fix: allow createRouter to be async (#4652)
1 parent 1746c08 commit 41bf26b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/router-core/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,7 @@ export type {
311311
StrictOrFrom,
312312
LooseReturnType,
313313
LooseAsyncReturnType,
314+
Awaitable,
314315
} from './utils'
315316

316317
export type {

packages/start-server-core/src/createStartHandler.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import type { RequestHandler } from './h3'
2626
import type {
2727
AnyRoute,
2828
AnyRouter,
29+
Awaitable,
2930
Manifest,
3031
ProcessRouteTreeResult,
3132
} from '@tanstack/router-core'
@@ -53,7 +54,7 @@ function getStartResponseHeaders(opts: { router: AnyRouter }) {
5354
export function createStartHandler<TRouter extends AnyRouter>({
5455
createRouter,
5556
}: {
56-
createRouter: () => TRouter
57+
createRouter: () => Awaitable<TRouter>
5758
}): CustomizeStartHandler<TRouter> {
5859
let routeTreeModule: {
5960
serverRouteTree: AnyServerRouteWithTypes | undefined
@@ -112,7 +113,7 @@ export function createStartHandler<TRouter extends AnyRouter>({
112113
const APP_BASE = process.env.TSS_APP_BASE || '/'
113114

114115
// TODO how does this work with base path? does the router need to be configured the same as APP_BASE?
115-
const router = createRouter()
116+
const router = await createRouter()
116117
// Create a history for the client-side router
117118
const history = createMemoryHistory({
118119
initialEntries: [href],

0 commit comments

Comments
 (0)