fix: only re-execute beforeLoad if previous run failed (#4433)

schiller-manuel · autofix-ci[bot] · web-flow · commit 0ce89c3d29f0 · 2025-06-15T23:48:35.000+02:00
Co-authored-by: autofix-ci[bot] &lt;114827586+autofix-ci[bot]@users.noreply.github.com&gt;
diff --git a/packages/router-core/src/router.ts b/packages/router-core/src/router.ts
@@ -2182,7 +2182,7 @@ export class RouterCore<
 
                 // Wait for the beforeLoad to resolve before we continue
                 await existingMatch.beforeLoadPromise
-                executeBeforeLoad = this.getMatch(matchId)!.status !== 'success'
+                executeBeforeLoad = this.getMatch(matchId)!.status === 'error'
               }
               if (executeBeforeLoad) {
                 // If we are not in the middle of a load OR the previous load failed, start it

Original file line number	Diff line number	Diff line change
`@@ -2182,7 +2182,7 @@ export class RouterCore<`
`2182`	`2182`
`2183`	`2183`	`// Wait for the beforeLoad to resolve before we continue`
`2184`	`2184`	`await existingMatch.beforeLoadPromise`
`2185`		`- executeBeforeLoad = this.getMatch(matchId)!.status !== 'success'`
	`2185`	`+ executeBeforeLoad = this.getMatch(matchId)!.status === 'error'`
`2186`	`2186`	`}`
`2187`	`2187`	`if (executeBeforeLoad) {`
`2188`	`2188`	`// If we are not in the middle of a load OR the previous load failed, start it`