(gpu) fix swapchain using Extent3 instead of Extent2

Author: Arthapz

modules/stormkit/gpu/execution/swapchain.mpp

@@ -32,12 +32,12 @@ export namespace stormkit::gpu {
 
         static auto create(const Device&             device,
                            const Surface&            surface,
-                           const math::Extent3<u32>& extent,
+                           const math::Extent2<u32>& extent,
                            OptionalRef<SwapChain>    old_swapchain = std::nullopt) noexcept
           -> Expected<SwapChain>;
         static auto allocate(const Device&             device,
                              const Surface&            surface,
-                             const math::Extent3<u32>& extent,
+                             const math::Extent2<u32>& extent,
                              OptionalRef<SwapChain>    old_swapchain = std::nullopt) noexcept
           -> Expected<Heap<SwapChain>>;
         ~SwapChain();
@@ -64,10 +64,10 @@ export namespace stormkit::gpu {
       private:
         auto do_init(const Device&,
                      const Surface&,
-                     const math::Extent3<u32>&,
+                     const math::Extent2<u32>&,
                      VkSwapchainKHR) noexcept -> Expected<void>;
 
-        math::Extent3<u32> m_extent;
+        math::Extent2<u32> m_extent;
         PixelFormat        m_pixel_format;
         u32                m_image_count;
 
@@ -113,7 +113,7 @@ namespace stormkit::gpu {
     STORMKIT_FORCE_INLINE
     inline auto SwapChain::create(const Device&             device,
                                   const Surface&            surface,
-                                  const math::Extent3<u32>& extent,
+                                  const math::Extent2<u32>& extent,
                                   OptionalRef<SwapChain>    old_swapchain) noexcept
       -> Expected<SwapChain> {
         auto swapchain = SwapChain { device, PrivateFuncTag {} };
@@ -130,7 +130,7 @@ namespace stormkit::gpu {
     STORMKIT_FORCE_INLINE
     inline auto SwapChain::allocate(const Device&             device,
                                     const Surface&            surface,
-                                    const math::Extent3<u32>& extent,
+                                    const math::Extent2<u32>& extent,
                                     OptionalRef<SwapChain>    old_swapchain) noexcept
       -> Expected<Heap<SwapChain>> {
         auto swapchain = std::make_unique<SwapChain>(device, PrivateFuncTag {});

src/gpu/execution/swapchain.cpp

@@ -55,8 +55,8 @@ namespace stormkit::gpu {
 
             auto actual_extent = to_vk(extent);
             actual_extent
-              .width             = std::max(capabilities.minImageExtent.width,
-                                            std::min(capabilities.maxImageExtent.width, actual_extent.width));
+              .width = std::max(capabilities.minImageExtent.width,
+                                std::min(capabilities.maxImageExtent.width, actual_extent.width));
             actual_extent.height = std::max(capabilities.minImageExtent.height,
                                             std::min(capabilities.maxImageExtent.height,
                                                      actual_extent.height));
@@ -80,7 +80,7 @@ namespace stormkit::gpu {
     /////////////////////////////////////
     auto SwapChain::do_init(const Device&             device,
                             const Surface&            surface,
-                            const math::Extent3<u32>& extent,
+                            const math::Extent2<u32>& extent,
                             VkSwapchainKHR            old_swapchain) noexcept -> Expected<void> {
         const auto& physical_device = device.physical_device();
 
@@ -115,7 +115,7 @@ namespace stormkit::gpu {
               const auto image_usage        = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
                                        | VK_IMAGE_USAGE_TRANSFER_DST_BIT;
 
-              m_extent       = extent.to<u32>();
+              m_extent       = extent;
               m_pixel_format = from_vk<PixelFormat>(format.format);
 
               const auto create_info = VkSwapchainCreateInfoKHR {
@@ -158,7 +158,7 @@ namespace stormkit::gpu {
               m_images      = vk_images
                          | std::views::transform([this, &device](auto&& image) noexcept {
                                const auto create_info = Image::CreateInfo {
-                                   .extent = m_extent,
+                                   .extent = { m_extent.width, m_extent.height, 1_u32 },
                                    .format = m_pixel_format
                                };
                                return Image::create(device, create_info, std::move(image));