Skip to content

Commit 8e54fba

Browse files
glbrnttbimawa
authored andcommitted
Update allocation counter limits (grpc#1347)
Motivation: A recent NIO release reduced allocations which has thrown off our expected counts. Modifications: Update allocation limits. Result: Limits are more appropriate.
1 parent cdd9fa9 commit 8e54fba

File tree

1 file changed

+37
-24
lines changed

1 file changed

+37
-24
lines changed

.github/workflows/ci.yaml

Lines changed: 37 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
fail-fast: false
2525
matrix:
2626
include:
27+
- image: swift:5.5-focal
28+
swift-test-flags: "--enable-test-discovery --sanitize=thread"
2729
- image: swift:5.4-focal
2830
swift-test-flags: "--enable-test-discovery --sanitize=thread"
2931
- image: swift:5.3-focal
@@ -49,36 +51,46 @@ jobs:
4951
fail-fast: false
5052
matrix:
5153
include:
54+
- image: swift:5.5-focal
55+
env:
56+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 480000
57+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 201000
58+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 110000
59+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 65000
60+
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 61000
61+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 194000
62+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 201000
63+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 201000
5264
- image: swift:5.4-focal
5365
env:
54-
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 504000
55-
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 216000
56-
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 112000
57-
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 67000
58-
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 63000
59-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 205000
60-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 212000
61-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 212000
66+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 480000
67+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 201000
68+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 110000
69+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 65000
70+
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 61000
71+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 194000
72+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 201000
73+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 201000
6274
- image: swift:5.3-focal
6375
env:
64-
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 505000
65-
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 217000
66-
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 112000
67-
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 67000
68-
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 63000
69-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 206000
70-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 213000
71-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 213000
76+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 481000
77+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 202000
78+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 110000
79+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 65000
80+
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 61000
81+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 195000
82+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 202000
83+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 202000
7284
- image: swift:5.2-bionic
7385
env:
74-
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 516000
75-
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 219000
76-
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 112000
77-
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 67000
78-
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 63000
79-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 207000
80-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 214000
81-
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 214000
86+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_10_requests: 492000
87+
MAX_ALLOCS_ALLOWED_bidi_1k_rpcs_1_request: 204000
88+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_10_small_requests: 110000
89+
MAX_ALLOCS_ALLOWED_embedded_server_bidi_1k_rpcs_1_small_request: 65000
90+
MAX_ALLOCS_ALLOWED_embedded_server_unary_1k_rpcs_1_small_request: 61000
91+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong: 196000
92+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_client: 203000
93+
MAX_ALLOCS_ALLOWED_unary_1k_ping_pong_interceptors_server: 203000
8294
name: Performance Tests on ${{ matrix.image }}
8395
runs-on: ubuntu-latest
8496
container:
@@ -94,6 +106,7 @@ jobs:
94106
fail-fast: false
95107
matrix:
96108
include:
109+
- image: swift:5.5-focal
97110
- image: swift:5.4-focal
98111
- image: swift:5.3-focal
99112
- image: swift:5.2-bionic

0 commit comments

Comments
 (0)