Skip to content

Add expiration time to JWT. Escape base64. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add expiration time to JWT. Escape base64. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/jwt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,17 @@ jwt.decode = function jwt_decode(token, key, noVerify, algorithm) {
* @return {String} token
* @api public
*/
jwt.encode = function jwt_encode(payload, key, algorithm, options) {
jwt.encode = function jwt_encode(payload, key, options, algorithm) {
// Check key
if (!key) {
throw new Error('Require key');
}

if(options.expiresIn != undefined) {
payload.iat = Date.now();
payload.exp = Date.now()+options.expiresIn;
}

// Check algorithm, default is HS256
algorithm = algorithm || 'HS256';

Expand Down Expand Up @@ -135,8 +140,8 @@ function verify(input, key, method, type, signature) {

else if(type == "sign") {
return crypto.createVerify(method)
.update(input)
.verify(key, base64urlUnescape(signature), 'base64');
.update(input)
.verify(key, base64urlUnescape(signature), 'base64');
}

else {
Expand Down Expand Up @@ -171,7 +176,7 @@ function base64urlUnescape(str) {
}

function base64urlEncode(str) {
return base64.encode(str);
return base64urlEscape(base64.encode(str));
}

function base64urlEscape(str) {
Expand Down