Skip to content

Commit c30fa12

Browse files
committed
Implement keyword suggestion routine
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <[email protected]>
1 parent a4e69dc commit c30fa12

File tree

3 files changed

+178
-1
lines changed

3 files changed

+178
-1
lines changed

vm/src/builtins/code.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ impl PyRef<PyCode> {
256256
}
257257

258258
#[pyproperty]
259-
fn co_varnames(self, vm: &VirtualMachine) -> PyTupleRef {
259+
pub fn co_varnames(self, vm: &VirtualMachine) -> PyTupleRef {
260260
let varnames = self
261261
.code
262262
.varnames

vm/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ mod sequence;
7070
mod signal;
7171
pub mod sliceable;
7272
pub mod stdlib;
73+
pub mod suggestion;
7374
pub mod types;
7475
pub mod utils;
7576
pub mod version;

vm/src/suggestion.rs

Lines changed: 176 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,176 @@
1+
use crate::{
2+
builtins::{PyList, PyStrRef},
3+
exceptions::types::PyBaseExceptionRef,
4+
sliceable::PySliceableSequence,
5+
IdProtocol, PyObjectRef, TryFromObject, TypeProtocol, VirtualMachine,
6+
};
7+
use std::cell::RefCell;
8+
use std::thread_local;
9+
10+
const MAX_CANDIDATE_ITEMS: usize = 750;
11+
const MAX_STRING_SIZE: usize = 40;
12+
13+
const MOVE_COST: usize = 2;
14+
const CASE_COST: usize = 1;
15+
16+
fn substitution_cost(mut a: u8, mut b: u8) -> usize {
17+
if (a & 31) != (b & 31) {
18+
return MOVE_COST;
19+
}
20+
if a == b {
21+
return 0usize;
22+
}
23+
if (b'A'..=b'Z').contains(&a) {
24+
a += b'a' - b'A';
25+
}
26+
if (b'A'..=b'Z').contains(&b) {
27+
b += b'a' - b'A';
28+
}
29+
if a == b {
30+
CASE_COST
31+
} else {
32+
MOVE_COST
33+
}
34+
}
35+
36+
fn levenshtein_distance(a: &str, b: &str, max_cost: usize) -> usize {
37+
thread_local! {
38+
static BUFFER: RefCell<[usize; MAX_STRING_SIZE]> = RefCell::new([0usize; MAX_STRING_SIZE]);
39+
}
40+
41+
if a == b {
42+
return 0;
43+
}
44+
45+
let (mut a_bytes, mut b_bytes) = (a.as_bytes(), b.as_bytes());
46+
let (mut a_begin, mut a_end) = (0usize, a.len());
47+
let (mut b_begin, mut b_end) = (0usize, b.len());
48+
49+
while a_end > 0 && b_end > 0 && (a_bytes[a_begin] == b_bytes[b_begin]) {
50+
a_begin += 1;
51+
b_begin += 1;
52+
a_end -= 1;
53+
b_end -= 1;
54+
}
55+
while a_end > 0 && b_end > 0 && (a_bytes[a_begin + a_end - 1] == b_bytes[b_begin + b_end - 1]) {
56+
a_end -= 1;
57+
b_end -= 1;
58+
}
59+
if a_end == 0 || b_end == 0 {
60+
return (a_end + b_end) * MOVE_COST;
61+
}
62+
if a_end > MAX_STRING_SIZE || b_end > MAX_STRING_SIZE {
63+
return max_cost + 1;
64+
}
65+
66+
if b_end < a_end {
67+
std::mem::swap(&mut a_bytes, &mut b_bytes);
68+
std::mem::swap(&mut a_begin, &mut b_begin);
69+
std::mem::swap(&mut a_end, &mut b_end);
70+
}
71+
72+
if (b_end - a_end) * MOVE_COST > max_cost {
73+
return max_cost + 1;
74+
}
75+
76+
BUFFER.with(|buffer| {
77+
for i in 0..a_end {
78+
buffer.borrow_mut()[i] = (i + 1) * MOVE_COST;
79+
}
80+
81+
let mut result = 0usize;
82+
for (b_index, b_code) in b_bytes[b_begin..(b_begin + b_end)].iter().enumerate() {
83+
result = b_index * MOVE_COST;
84+
let mut distance = result;
85+
let mut minimum = usize::MAX;
86+
for (a_index, a_code) in a_bytes[a_begin..(a_begin + a_end)].iter().enumerate() {
87+
let substitute = distance + substitution_cost(*b_code, *a_code);
88+
distance = buffer.borrow()[a_index];
89+
let insert_delete = usize::min(result, distance) + MOVE_COST;
90+
result = usize::min(insert_delete, substitute);
91+
92+
buffer.borrow_mut()[a_index] = result;
93+
if result < minimum {
94+
minimum = result;
95+
}
96+
}
97+
if minimum > max_cost {
98+
return max_cost + 1;
99+
}
100+
}
101+
result
102+
})
103+
}
104+
105+
fn calculate_suggestions(dir: PyList, name: &PyObjectRef, vm: &VirtualMachine) -> Option<PyStrRef> {
106+
let dir = dir.borrow_vec();
107+
if dir.len() >= MAX_CANDIDATE_ITEMS {
108+
return None;
109+
}
110+
111+
let mut suggestion: Option<PyStrRef> = None;
112+
let mut suggestion_distance = usize::MAX;
113+
let name = match PyStrRef::try_from_object(vm, name.clone()) {
114+
Ok(name) => name,
115+
Err(_) => return None,
116+
};
117+
118+
for item in dir.iter() {
119+
let item_name = match PyStrRef::try_from_object(vm, item.clone()) {
120+
Ok(name) => name,
121+
Err(_) => return None,
122+
};
123+
if name.to_string() == item_name.to_string() {
124+
continue;
125+
}
126+
let max_distance = usize::min(
127+
(name.len() + item_name.len() + 3) * MOVE_COST / 6,
128+
suggestion_distance - 1,
129+
);
130+
let current_distance =
131+
levenshtein_distance(name.as_str(), item_name.as_str(), max_distance);
132+
if current_distance > max_distance {
133+
continue;
134+
}
135+
if suggestion.is_none() || current_distance < suggestion_distance {
136+
suggestion = Some(item_name);
137+
suggestion_distance = current_distance;
138+
}
139+
}
140+
suggestion
141+
}
142+
143+
pub fn offer_suggestions(exc: &PyBaseExceptionRef, vm: &VirtualMachine) -> Option<PyStrRef> {
144+
if exc.class().is(&vm.ctx.exceptions.attribute_error) {
145+
let name = vm.get_attribute(exc.as_object().clone(), "name").unwrap();
146+
let obj = vm.get_attribute(exc.as_object().clone(), "obj").unwrap();
147+
148+
match vm.dir(Some(obj)) {
149+
Ok(dir_list) => calculate_suggestions(dir_list, &name, vm),
150+
Err(_) => None,
151+
}
152+
} else if exc.class().is(&vm.ctx.exceptions.name_error) {
153+
let name = vm.get_attribute(exc.as_object().clone(), "name").unwrap();
154+
let mut tb = exc.traceback().unwrap();
155+
while let Some(traceback) = tb.next.clone() {
156+
tb = traceback;
157+
}
158+
159+
let frame = tb.frame.clone();
160+
let code = frame.code.clone();
161+
let varnames = PyList::from(code.co_varnames(vm).as_slice().to_vec());
162+
if let Some(suggestions) = calculate_suggestions(varnames, &name, vm) {
163+
return Some(suggestions);
164+
};
165+
166+
let globals = PyList::from(vm.extract_elements(frame.globals.as_object()).unwrap());
167+
if let Some(suggestions) = calculate_suggestions(globals, &name, vm) {
168+
return Some(suggestions);
169+
};
170+
171+
let builtins = PyList::from(vm.extract_elements(frame.builtins.as_object()).unwrap());
172+
calculate_suggestions(builtins, &name, vm)
173+
} else {
174+
None
175+
}
176+
}

0 commit comments

Comments
 (0)