Fix metrics initialization in compute_validation_metrics for proper label handling

SimoneBendazzoli93 · SimoneBendazzoli93 · commit 1cd4312fed75 · 2025-05-27T08:20:35.000Z
diff --git a/monai/nvflare/utils.py b/monai/nvflare/utils.py
@@ -378,7 +378,6 @@ def compute_validation_metrics(gt_folder, pred_folder, n_labels=1):
                     {
                         "prediction_file": os.path.join(pred_folder, file),
                         "metrics": {
-                        "1": {}
                         }
                     }
                 )
@@ -408,6 +407,7 @@ def compute_validation_metrics(gt_folder, pred_folder, n_labels=1):
         )
         dice = dice_fn(to_onehot(pred_array[None])[None], to_onehot(gt_array[None])[None])
         for label_id in range(1,1+n_labels):
+            summary['metric_per_case'][idx]["metrics"][str(label_id)] = {}
             summary['metric_per_case'][idx]["metrics"][str(label_id)]["HD95"] = hd_95[label_id-1][0].item()
             summary['metric_per_case'][idx]["metrics"][str(label_id)]["ASD"] = asd[label_id-1][0].item()
             summary['metric_per_case'][idx]["metrics"][str(label_id)]["Dice"] = dice[label_id-1][0].item()

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,6 @@ def compute_validation_metrics(gt_folder, pred_folder, n_labels=1):`
`378`	`378`	`{`
`379`	`379`	`"prediction_file": os.path.join(pred_folder, file),`
`380`	`380`	`"metrics": {`
`381`		`- "1": {}`
`382`	`381`	`}`
`383`	`382`	`}`
`384`	`383`	`)`
`@@ -408,6 +407,7 @@ def compute_validation_metrics(gt_folder, pred_folder, n_labels=1):`
`408`	`407`	`)`
`409`	`408`	`dice = dice_fn(to_onehot(pred_array[None])[None], to_onehot(gt_array[None])[None])`
`410`	`409`	`for label_id in range(1,1+n_labels):`
	`410`	`+ summary['metric_per_case'][idx]["metrics"][str(label_id)] = {}`
`411`	`411`	`summary['metric_per_case'][idx]["metrics"][str(label_id)]["HD95"] = hd_95[label_id-1][0].item()`
`412`	`412`	`summary['metric_per_case'][idx]["metrics"][str(label_id)]["ASD"] = asd[label_id-1][0].item()`
`413`	`413`	`summary['metric_per_case'][idx]["metrics"][str(label_id)]["Dice"] = dice[label_id-1][0].item()`