Skip to content

Commit c7ebfe1

Browse files
committed
fix: JSDOM no longer calls setAttribute
1 parent d05c432 commit c7ebfe1

File tree

1 file changed

+7
-21
lines changed

1 file changed

+7
-21
lines changed

packages/react-dom/src/__tests__/ReactDOMInput-test.js

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,25 +1579,13 @@ describe('ReactDOMInput', () => {
15791579
container,
15801580
);
15811581

1582-
if (disableInputAttributeSyncing) {
1583-
expect(log).toEqual([
1584-
'set attribute type',
1585-
'set attribute min',
1586-
'set attribute max',
1587-
'set attribute step',
1588-
'set property value',
1589-
]);
1590-
} else {
1591-
expect(log).toEqual([
1592-
'set attribute type',
1593-
'set attribute min',
1594-
'set attribute max',
1595-
'set attribute step',
1596-
'set property value',
1597-
'set attribute value',
1598-
'set attribute checked',
1599-
]);
1600-
}
1582+
expect(log).toEqual([
1583+
'set attribute type',
1584+
'set attribute min',
1585+
'set attribute max',
1586+
'set attribute step',
1587+
'set property value',
1588+
]);
16011589
});
16021590

16031591
it('sets value properly with type coming later in props', () => {
@@ -1662,8 +1650,6 @@ describe('ReactDOMInput', () => {
16621650
expect(log).toEqual([
16631651
'node.setAttribute("type", "date")',
16641652
'node.value = "1980-01-01"',
1665-
'node.setAttribute("value", "1980-01-01")',
1666-
'node.setAttribute("checked", "")',
16671653
]);
16681654
}
16691655
});

0 commit comments

Comments
 (0)