Merge pull request #500 from yileicn/OptimizeTranslate

Oceania2018 · web-flow · commit 7d99ad845ba5 · 2024-06-13T09:24:15.000-05:00
Update TranslationService.cs
diff --git a/src/Infrastructure/BotSharp.Core/Translation/TranslationService.cs b/src/Infrastructure/BotSharp.Core/Translation/TranslationService.cs
@@ -121,7 +121,7 @@ private void Collect<T>(T data, ref HashSet<string> res) where T : class
         if (data == null) return;
 
         var dataType = data.GetType();
-        if (IsStringType(dataType))
+        if (IsStringType(dataType) && !string.IsNullOrWhiteSpace(data.ToString()))
         {
             res.Add(data.ToString());
             return;
@@ -139,7 +139,7 @@ private void Collect<T>(T data, ref HashSet<string> res) where T : class
             {
                 foreach (var item in (data as IEnumerable<string>))
                 {
-                    if (item == null) continue;
+                    if (string.IsNullOrWhiteSpace(item)) continue;
                     res.Add(item);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ private void Collect<T>(T data, ref HashSet<string> res) where T : class`
`121`	`121`	`if (data == null) return;`
`122`	`122`
`123`	`123`	`var dataType = data.GetType();`
`124`		`- if (IsStringType(dataType))`
	`124`	`+ if (IsStringType(dataType) && !string.IsNullOrWhiteSpace(data.ToString()))`
`125`	`125`	`{`
`126`	`126`	`res.Add(data.ToString());`
`127`	`127`	`return;`
`@@ -139,7 +139,7 @@ private void Collect<T>(T data, ref HashSet<string> res) where T : class`
`139`	`139`	`{`
`140`	`140`	`foreach (var item in (data as IEnumerable<string>))`
`141`	`141`	`{`
`142`		`- if (item == null) continue;`
	`142`	`+ if (string.IsNullOrWhiteSpace(item)) continue;`
`143`	`143`	`res.Add(item);`
`144`	`144`	`}`
`145`	`145`	`}`