This repository was archived by the owner on May 15, 2025. It is now read-only.
Fix ITP for problems with flipped sign #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some problems, there's a potential bug as the current ITP implementation follows the pseudocode in the Oliveira - Takahashi paper, which assumes f(left) < 0 < f(right), and thus it may wrongly contract the interval for problems with the reverse sign configuration (
surprisingly enough, it sometimes works with the wrong signs[1]). This PR fixes the issue and adds a basic test for it.[1] Did not realize that's only the case if one of the edges is the solution already