diff --git a/.gitignore b/.gitignore index e4cfbfe..42affce 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,3 @@ Manifest.toml - +.vscode wip \ No newline at end of file diff --git a/Project.toml b/Project.toml index 0be4041..a0becaa 100644 --- a/Project.toml +++ b/Project.toml @@ -23,7 +23,7 @@ SimpleBatchedNonlinearSolveExt = "NNlib" [compat] ArrayInterface = "6, 7" -DiffEqBase = "6.119" +DiffEqBase = "6.123.0" FiniteDiff = "2" ForwardDiff = "0.10.3" NNlib = "0.8" diff --git a/ext/SimpleBatchedNonlinearSolveExt.jl b/ext/SimpleBatchedNonlinearSolveExt.jl index 07c117f..e3f394c 100644 --- a/ext/SimpleBatchedNonlinearSolveExt.jl +++ b/ext/SimpleBatchedNonlinearSolveExt.jl @@ -59,7 +59,8 @@ function SciMLBase.__solve(prob::NonlinearProblem, alg::Broyden{true}, args...; error("Broyden currently doesn't support SAFE_BEST termination modes") end - storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? Dict() : nothing + storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? NLSolveSafeTerminationResult() : + nothing termination_condition = tc(storage) xₙ = x diff --git a/src/broyden.jl b/src/broyden.jl index e8d339c..e464696 100644 --- a/src/broyden.jl +++ b/src/broyden.jl @@ -48,7 +48,8 @@ function SciMLBase.__solve(prob::NonlinearProblem, alg::Broyden{false}, args...; error("Broyden currently doesn't support SAFE_BEST termination modes") end - storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? Dict() : nothing + storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? NLSolveSafeTerminationResult() : + nothing termination_condition = tc(storage) xₙ = x diff --git a/src/lbroyden.jl b/src/lbroyden.jl index 6a3fc09..6cca7c1 100644 --- a/src/lbroyden.jl +++ b/src/lbroyden.jl @@ -63,7 +63,8 @@ end error("LBroyden currently doesn't support SAFE_BEST termination modes") end - storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? Dict() : nothing + storage = mode ∈ DiffEqBase.SAFE_TERMINATION_MODES ? NLSolveSafeTerminationResult() : + nothing termination_condition = tc(storage) xₙ = x