Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Commit e77dbbd

Browse files
Merge pull request #1 from SciML/tols
fix tolerances
2 parents 2bdfe64 + 2231b49 commit e77dbbd

File tree

5 files changed

+8
-37
lines changed

5 files changed

+8
-37
lines changed

.github/workflows/CI.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ name: CI
22
on:
33
pull_request:
44
branches:
5-
- master
5+
- main
66
push:
77
branches:
8-
- master
8+
- main
99
jobs:
1010
test:
1111
runs-on: ubuntu-latest

.github/workflows/Documentation.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

.github/workflows/Downstream.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: IntegrationTest
22
on:
33
push:
4-
branches: [master]
4+
branches: [main]
55
tags: [v*]
66
pull_request:
77

.github/workflows/FormatCheck.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: format-check
33
on:
44
push:
55
branches:
6-
- 'master'
6+
- 'main'
77
- 'release-'
88
tags: '*'
99
pull_request:

src/raphson.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ struct SimpleNewtonRaphson{CS, AD, FDT} <: AbstractNewtonAlgorithm{CS, AD, FDT}
77
end
88

99
function SciMLBase.solve(prob::NonlinearProblem,
10-
alg::SimpleNewtonRaphson, args...; xatol = nothing,
11-
xrtol = nothing,
10+
alg::SimpleNewtonRaphson, args...; abstol = nothing,
11+
reltol = nothing,
1212
maxiters = 1000, kwargs...)
1313
f = Base.Fix2(prob.f, prob.p)
1414
x = float(prob.u0)
@@ -19,8 +19,8 @@ function SciMLBase.solve(prob::NonlinearProblem,
1919
error("SimpleNewtonRaphson currently only supports out-of-place nonlinear problems")
2020
end
2121

22-
atol = xatol !== nothing ? xatol : oneunit(eltype(T)) * (eps(one(eltype(T))))^(4 // 5)
23-
rtol = xrtol !== nothing ? xrtol : eps(one(eltype(T)))^(4 // 5)
22+
atol = abstol !== nothing ? abstol : oneunit(eltype(T)) * (eps(one(eltype(T))))^(4 // 5)
23+
rtol = reltol !== nothing ? reltol : eps(one(eltype(T)))^(4 // 5)
2424

2525
if typeof(x) <: Number
2626
xo = oftype(one(eltype(x)), Inf)

0 commit comments

Comments
 (0)