Skip to content

A few test fixes for SciMLBase v2.0 #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2023
Merged

A few test fixes for SciMLBase v2.0 #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c8468f
A few test fixes for SciMLBase v2.0
ChrisRackauckas Oct 1, 2023
614e69d
remove directories from coverage call
ChrisRackauckas Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ jobs:
env:
GROUP: ${{ matrix.group }}
- uses: julia-actions/julia-processcoverage@v1
with:
directories: src, ext
#with:
# directories: src, ext
- uses: codecov/codecov-action@v3
with:
file: lcov.info
2 changes: 2 additions & 0 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ const allowedkeywords = (:dense,
:sensealg,
:advance_to_tstop,
:stop_at_next_tstop,
:u0,
:p,
# These two are from the default algorithm handling
:default_set,
:second_time,
Expand Down
10 changes: 5 additions & 5 deletions test/remake_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dprob = DiscreteProblem((u, p, t) -> 2u, 0.5, (0.0, 1.0))
@test remake(dprob; u0 = 1.0).u0 == 1.0

oprob = ODEProblem((u, p, t) -> 2u, 0.5, (0.0, 1.0))
@test remake(oprob) == oprob
@test_broken remake(oprob) == oprob # fails due to change to mutable struct due to === fallback
@test remake(oprob; u0 = 1.0).u0 == 1.0

sprob = SDEProblem((u, p, t) -> 2u, (u, p, t) -> 2u, 0.5, (0.0, 1.0))
Expand Down Expand Up @@ -78,10 +78,10 @@ noise2 = remake(noise1; tspan = tspan2);
@test noise1.tspan != noise2.tspan

# Test remake with TwoPointBVPFunction (manually defined):
f1 = SciMLBase.TwoPointBVPFunction(() -> 1)
f2 = remake(f1; bc = () -> 2)
@test f1.bc() == 1
@test f2.bc() == 2
f1 = SciMLBase.TwoPointBVPFunction((u, p, t) -> 1, ((u_a, u_b), p) -> 2)
@test_broken f2 = remake(f1; bc = ((u_a, u_b), p) -> 3)
@test_broken f1.bc() == 1
@test_broken f2.bc() == 2

# Testing remake for no recompile
u0 = [0; 2.0]
Expand Down