Skip to content

Commit dc6b76a

Browse files
committed
[INTERNAL] ESLint: Activate no-console
Already active through eslint-config-google
1 parent 7f3e234 commit dc6b76a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ module.exports = {
3434
],
3535
"comma-dangle": "off",
3636
"no-tabs": "off",
37-
"no-console": "off", // until we have better logging
3837
'valid-jsdoc': [
3938
2,
4039
{

lib/sslUtil.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ function createAndInstallCertificate(keyPath, certPath) {
7878

7979
// Inform end user about entering his root password (needed for importing
8080
// the created certificate into the system)
81+
/* eslint-disable no-console */
82+
// TODO: Prompt and logging should happen in CLI module rather than server
8183
if (process.platform === "win32") {
8284
console.log("Please press allow in the opened dialog to confirm importing the newly created " +
8385
"SSL certificate into the operating system and browsers.");
@@ -99,6 +101,7 @@ function createAndInstallCertificate(keyPath, certPath) {
99101
console.error(err);
100102
});
101103
});
104+
/* eslint-enable no-console */
102105
});
103106
}
104107

0 commit comments

Comments
 (0)