From a8ec8b75890715e5247aa9ccbebc18b20f6f40af Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Mon, 27 Jan 2025 13:15:53 +0100 Subject: [PATCH 01/16] Add files for EDOI & EDOT --- file-formats/edoi/.DS_Store | Bin 0 -> 6148 bytes file-formats/edoi/README.md | 5 + file-formats/edoi/edoi-v1.json | 209 ++++++++++++++++++ .../edoi/type/zif_aff_edoi_v1.intf.abap | 121 ++++++++++ .../edoi/type/zif_aff_edoi_v1.intf.json | 7 + file-formats/edot/.DS_Store | Bin 0 -> 6148 bytes file-formats/edot/README.md | 5 + file-formats/edot/edot-v1.json | 185 ++++++++++++++++ .../edot/type/zif_aff_edot_v1.intf.abap | 105 +++++++++ .../edot/type/zif_aff_edot_v1.intf.json | 7 + 10 files changed, 644 insertions(+) create mode 100644 file-formats/edoi/.DS_Store create mode 100644 file-formats/edoi/README.md create mode 100644 file-formats/edoi/edoi-v1.json create mode 100644 file-formats/edoi/type/zif_aff_edoi_v1.intf.abap create mode 100644 file-formats/edoi/type/zif_aff_edoi_v1.intf.json create mode 100644 file-formats/edot/.DS_Store create mode 100644 file-formats/edot/README.md create mode 100644 file-formats/edot/edot-v1.json create mode 100644 file-formats/edot/type/zif_aff_edot_v1.intf.abap create mode 100644 file-formats/edot/type/zif_aff_edot_v1.intf.json diff --git a/file-formats/edoi/.DS_Store b/file-formats/edoi/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..15c04208536080b609881173172966e05394ceb5 GIT binary patch literal 6148 zcmeH~F>b>!3`IW^4*{}x?5L#&$PI)bIYBQ_H0~B40n!fLbo72wTb%_`(ma_?&L1^T*|K_9AW70Z-{8X8XAOSd_o2|8HQ74j)4>oU06DN6#&ygRWbp!7ldY2#n&tFh z*=jL{cs<(5lGoK_>+J2Y96l`XY(B-%thd7o6Pne4f)tPfGX>T?AN~A4(jU$LvlgXN zKnnab1#CFH9rk>wJX`Nx&+G45^>w3@aXG`Ep8zI)6u;2JxLET HJXL{T_8Ah# literal 0 HcmV?d00001 diff --git a/file-formats/edoi/README.md b/file-formats/edoi/README.md new file mode 100644 index 000000000..4061063fc --- /dev/null +++ b/file-formats/edoi/README.md @@ -0,0 +1,5 @@ +# EDOI File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.edoi.json` | 1 | [`zif_aff_edoi_v1.intf.abap`](./type/zif_aff_edoi_v1.intf.abap) | [`edoi-v1.json`](./edoi-v1.json) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json new file mode 100644 index 000000000..1ad363d6e --- /dev/null +++ b/file-formats/edoi/edoi-v1.json @@ -0,0 +1,209 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edoi/edoi-v1.json", + "title": "eDocument Interface", + "description": "eDocument Interface", + "type": "object", + "properties": { + "formatVersion": { + "title": "Format Version", + "description": "Format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2 + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "keyUser", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP for Key Users", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP for key user extensibility", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "generalInformation": { + "title": "eDocument Interface", + "description": "eDocument Interface", + "type": "object", + "properties": { + "edocumentInterfaceId": { + "title": "eDocument Interface", + "description": "eDocument Interface", + "type": "string", + "maxLength": 30 + }, + "interfaceDescription": { + "title": "eDocument Interface Description", + "description": "Interface Description.", + "type": "string", + "maxLength": 100 + }, + "interfaceDirection": { + "title": "eDocument Interface Direction", + "description": "Interface Direction.", + "type": "string", + "enum": [ + "outbound", + "inbound" + ], + "enumTitles": [ + "Outbound", + "Inbound" + ], + "enumDescriptions": [ + "Outbound", + "Inbound" + ], + "default": "outbound" + }, + "edocumentInterfaceVersion": { + "title": "Interface Version", + "description": "Interface Version", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Interface Version", + "description": "eDocument Interface Version", + "type": "object", + "properties": { + "intVersion": { + "title": "Interface Version", + "description": "Interface Version", + "type": "string", + "maxLength": 4, + "pattern": "^[0-9]+$" + }, + "intVersionDesc": { + "title": "Interface Version Description", + "description": "Interface Version Description", + "type": "string", + "maxLength": 30 + }, + "activeFrom": { + "title": "Active From", + "description": "Active from", + "type": "string", + "format": "date-time" + } + }, + "additionalProperties": false, + "required": [ + "intVersion", + "intVersionDesc", + "activeFrom" + ] + } + }, + "edocSpecAdditionalTable": { + "title": "Attribute Determination for Communication with Cloud Edition", + "description": "DRC Integration Attribute Determination", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Attribute Determination for Communication with Cloud Edition", + "description": "DRC Integration Attribute Determination", + "type": "object", + "properties": { + "processType": { + "title": "Process Type", + "description": "DRC Process Type", + "type": "string", + "maxLength": 50 + }, + "processVersion": { + "title": "Process Version", + "description": "DRC Process Version", + "type": "string", + "maxLength": 20 + }, + "processSubtype": { + "title": "Process Subtype", + "description": "DRC Process Subtype", + "type": "string", + "maxLength": 50 + }, + "drcAction": { + "title": "Action", + "description": "DRC Process Action", + "type": "string", + "maxLength": 30 + }, + "respInterfaceId": { + "title": "Response Interface", + "description": "eDoc Response Interface", + "type": "string", + "maxLength": 30 + }, + "respIntVersion": { + "title": "Response Interface Version", + "description": "Response Interface Version", + "type": "string", + "maxLength": 4, + "pattern": "^[0-9]+$" + } + }, + "additionalProperties": false, + "required": [ + "processType", + "processVersion", + "processSubtype", + "drcAction", + "respInterfaceId", + "respIntVersion" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "edocumentInterfaceId", + "interfaceDescription", + "interfaceDirection", + "edocumentInterfaceVersion", + "edocSpecAdditionalTable" + ] + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header", + "generalInformation" + ] +} diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap new file mode 100644 index 000000000..3a77f0aef --- /dev/null +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -0,0 +1,121 @@ +INTERFACE zif_aff_edoi_v1 + PUBLIC. + + "!

Interface direction

+ "! Interface direction + "! $required + "! $values {@link zif_aff_edoi_v1.data:co_edoc_int_direction} + "! $default {@link zif_aff_edoi_v1.data:co_edoc_int_direction.outbound} + TYPES ty_int_direction TYPE c LENGTH 1. + TYPES: + "!

Interface Version

+ "! eDocument Interface Version + BEGIN OF ty_edoc_interface_version, + "!

Interface Version

+ "! Interface Version + "! $required + int_version TYPE numc04, + "!

Interface Version Description

+ "! Interface Version Description + "! $required + int_version_desc TYPE c LENGTH 30, + "!

Active From

+ "! Active from + "! $required + active_from TYPE sy-datum, + + END OF ty_edoc_interface_version. + "!

Interface Versions

+ "! eDocument Interface Versions + TYPES tt_edoc_interface_version TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version. + TYPES: + "!

Attribute Determination for Communication with Cloud Edition

+ "! DRC Integration Attribute Determination + BEGIN OF ty_edoc_int_drc_attr, + "!

Process Type

+ "! DRC Process Type + "! $required + process_type TYPE c LENGTH 50, + "!

Process Version

+ "! DRC Process Version + "! $required + process_version TYPE c LENGTH 20, + "!

Process Subtype

+ "! DRC Process Subtype + "! $required + process_subtype TYPE c LENGTH 50, + "!

Action

+ "! DRC Process Action + "! $required + drc_action TYPE c LENGTH 30, + "!

Response Interface

+ "! eDoc Response Interface + "! $required + resp_interface_id TYPE c LENGTH 30, + "!

Response Interface Version

+ "! Response Interface Version + "! $required + resp_int_version TYPE numc04, + + END OF ty_edoc_int_drc_attr. + "!

Interface Versions

+ "! eDocument Interface Versions + TYPES tt_edoc_int_drc_attr TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. + TYPES: + "!

General Information

+ "! eDocument Interface + BEGIN OF ty_edoc_interface, + "!

eDocument Interface

+ "! eDocument Interface + "! $required + edocument_interface_id TYPE c LENGTH 30, + "!

eDocument Interface Description

+ "! Interface Description. + "! $required + interface_description TYPE c LENGTH 100, + + "!

eDocument Interface Direction

+ "! Interface Direction. + "! $required + interface_direction TYPE ty_int_direction, + + "!

Interface Version

+ "! Interface Version + "! $required + edocument_interface_version TYPE tt_edoc_interface_version, + "!

Attribute Determination for Communication with Cloud Edition

+ "! DRC Integration Attribute Determination + "! $required + edoc_spec_additional_table TYPE tt_edoc_int_drc_attr, + END OF ty_edoc_interface. + TYPES: + "!

eDocument Interface

+ "! eDocument Interface + BEGIN OF ty_main, + "!

Format Version

+ "! Format version + "! $required + format_version TYPE zif_aff_types_v1=>ty_format_version, + "!

Header

+ "! Header + "! $required + header TYPE zif_aff_types_v1=>ty_header_60, + "!

eDocument Interface

+ "! eDocument Interface + "! $required + general_information TYPE ty_edoc_interface, + + END OF ty_main. + + CONSTANTS: + "!

Interface Direction

+ "! Interface Direction + BEGIN OF co_edoc_int_direction, + "!

Outbound

+ "! Outbound + outbound TYPE ty_int_direction VALUE 'O', + "!

Inbound

+ "! Inbound + inbound TYPE ty_int_direction VALUE 'I', + END OF co_edoc_int_direction. +ENDINTERFACE. diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.json b/file-formats/edoi/type/zif_aff_edoi_v1.intf.json new file mode 100644 index 000000000..77d2b8841 --- /dev/null +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "Create eDocument Types", + "originalLanguage": "en" + } +} diff --git a/file-formats/edot/.DS_Store b/file-formats/edot/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..15c04208536080b609881173172966e05394ceb5 GIT binary patch literal 6148 zcmeH~F>b>!3`IW^4*{}x?5L#&$PI)bIYBQ_H0~B40n!fLbo72wTb%_`(ma_?&L1^T*|K_9AW70Z-{8X8XAOSd_o2|8HQ74j)4>oU06DN6#&ygRWbp!7ldY2#n&tFh z*=jL{cs<(5lGoK_>+J2Y96l`XY(B-%thd7o6Pne4f)tPfGX>T?AN~A4(jU$LvlgXN zKnnab1#CFH9rk>wJX`Nx&+G45^>w3@aXG`Ep8zI)6u;2JxLET HJXL{T_8Ah# literal 0 HcmV?d00001 diff --git a/file-formats/edot/README.md b/file-formats/edot/README.md new file mode 100644 index 000000000..23a553e6b --- /dev/null +++ b/file-formats/edot/README.md @@ -0,0 +1,5 @@ +# EDOT File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.edot.json` | 1 | [`zif_aff_edot_v1.intf.abap`](./type/zif_aff_edot_v1.intf.abap) | [`edot-v1.json`](./edot-v1.json) diff --git a/file-formats/edot/edot-v1.json b/file-formats/edot/edot-v1.json new file mode 100644 index 000000000..35fe1e474 --- /dev/null +++ b/file-formats/edot/edot-v1.json @@ -0,0 +1,185 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edot/edot-v1.json", + "title": "eDocument Type", + "description": "eDocument Type", + "type": "object", + "properties": { + "formatVersion": { + "title": "Format Version", + "description": "Format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2 + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "keyUser", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP for Key Users", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP for key user extensibility", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "generalInformation": { + "title": "eDocument Type", + "description": "eDocument Type", + "type": "object", + "properties": { + "edocumentType": { + "title": "eDocument Type", + "description": "eDoc Type", + "type": "string", + "maxLength": 10 + }, + "edocTypeDesc": { + "title": "Description", + "description": "eDocument Type Description", + "type": "string", + "maxLength": 30 + }, + "contingency": { + "title": "Created in Contingency Mode", + "description": "Contingency", + "type": "boolean" + }, + "contingencyType": { + "title": "eDocument Type Created Using Contingency", + "description": "Contingency Type", + "type": "string", + "maxLength": 10 + }, + "tableName": { + "title": "Table Name", + "description": "Table name", + "type": "string", + "maxLength": 30 + }, + "archivePrepReqType": { + "title": "Preprocess Before Archiving", + "description": "Archive Prep Req Type", + "type": "boolean" + }, + "edocumentSralConfiguration": { + "title": "Additional Selection Fields", + "description": "Additional selection fields of validation report", + "type": "array", + "uniqueItems": true, + "items": { + "title": "SRAL Configuration Type", + "description": "eDocument SRAL Configuration type", + "type": "object", + "properties": { + "fileType": { + "title": "File Type", + "description": "File Type", + "type": "string", + "maxLength": 10 + }, + "fileStructureType": { + "title": "File Structure Type", + "description": "File Structure type", + "type": "string", + "maxLength": 30 + }, + "fileDescriptionType": { + "title": "File Description", + "description": "File Description type", + "type": "string", + "maxLength": 60 + }, + "notCloudRelevantType": { + "title": "File Cloud Relevancy", + "description": "File Cloud Relevancy type", + "type": "boolean" + } + }, + "additionalProperties": false, + "required": [ + "fileType", + "fileStructureType" + ] + } + }, + "edocSpecAdditionalTable": { + "title": "eDocument Type Specific Additional Tables", + "description": "eDocument Type Specific Additional Tables", + "type": "array", + "uniqueItems": true, + "items": { + "title": "eDocument Type Specific Additional Table Type", + "description": "eDocument Type Specific Additional Table type", + "type": "object", + "properties": { + "sequenceNumberType": { + "title": "Sequence Number Type", + "description": "Sequence Number", + "type": "string", + "maxLength": 10 + }, + "tableName": { + "title": "Table Name", + "description": "Table name", + "type": "string", + "maxLength": 30 + } + }, + "additionalProperties": false, + "required": [ + "sequenceNumberType", + "tableName" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "edocumentType", + "edocTypeDesc", + "archivePrepReqType" + ] + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header", + "generalInformation" + ] +} diff --git a/file-formats/edot/type/zif_aff_edot_v1.intf.abap b/file-formats/edot/type/zif_aff_edot_v1.intf.abap new file mode 100644 index 000000000..7347b5e13 --- /dev/null +++ b/file-formats/edot/type/zif_aff_edot_v1.intf.abap @@ -0,0 +1,105 @@ +"!

Create eDocument Types

+"! eDocument types that can be used in eInvoice Process +INTERFACE zif_aff_edot_v1 +PUBLIC. + + TYPES: + "!

eDocument Type

+ "! Specify eDocument types + ty_edoc_type TYPE c LENGTH 10. + + "!

Description

+ "! Description + TYPES ty_short_description TYPE c LENGTH 30. + TYPES: + "!

SRAL Configuration Type

+ "! eDocument SRAL Configuration type + BEGIN OF ty_sral_configuration, + "!

File Type

+ "! File Type + "! $required + file_type TYPE c LENGTH 10, + "!

File Structure Type

+ "! File Structure type + "! $required + file_structure_type TYPE c LENGTH 30, + "!

File Description

+ "! File Description type + file_description_type TYPE c LENGTH 60, + "!

File Cloud Relevancy

+ "! File Cloud Relevancy type + not_cloud_relevant_type TYPE abap_bool, + END OF ty_sral_configuration. + "!

SRAL Configuration Types

+ "! SRAL Configuration types + TYPES tt_sral_configuration TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type. + + TYPES: + "!

eDocument Type Specific Additional Table Type

+ "! eDocument Type Specific Additional Table type + BEGIN OF ty_edoc_spec_additional_table, + "!

Sequence Number Type

+ "! Sequence Number + "! $required + sequence_number_type TYPE c LENGTH 10, + "!

Table Name

+ "! Table name + "! $required + table_name TYPE zif_aff_types_v1=>ty_object_name_30, + END OF ty_edoc_spec_additional_table. + "!

eDocument Type Specific Additional Table Types

+ "! eDocument Type Specific Additional Table types + TYPES tt_edoc_spec_additional_table TYPE SORTED TABLE OF ty_edoc_spec_additional_table WITH UNIQUE KEY sequence_number_type. + + TYPES: + "!

General Information

+ "! eDocument Type + BEGIN OF ty_edoc_information, + "!

eDocument Type

+ "! eDoc Type + "! $required + edocument_type TYPE ty_edoc_type, + "!

Description

+ "! eDocument Type Description + "! $required + edoc_type_desc TYPE ty_short_description, + "!

Created in Contingency Mode

+ "! Contingency + contingency TYPE abap_bool, + "!

eDocument Type Created Using Contingency

+ "! Contingency Type + contingency_type TYPE c LENGTH 10, + "!

Table Name

+ "! Table name + table_name TYPE zif_aff_types_v1=>ty_object_name_30, + "!

Preprocess Before Archiving

+ "! Archive Prep Req Type + "! $required + archive_prep_req_type TYPE abap_bool, + "!

Additional Selection Fields

+ "! Additional selection fields of validation report + edocument_sral_configuration TYPE tt_sral_configuration, + "!

eDocument Type Specific Additional Tables

+ "! eDocument Type Specific Additional Tables + edoc_spec_additional_table TYPE tt_edoc_spec_additional_table, + END OF ty_edoc_information. + + TYPES: + "!

eDocument Type

+ "! eDocument Type + BEGIN OF ty_main, + "!

Format Version

+ "! Format version + "! $required + format_version TYPE zif_aff_types_v1=>ty_format_version, + "!

Header

+ "! Header + "! $required + header TYPE zif_aff_types_v1=>ty_header_60, + "!

eDocument Type

+ "! eDocument Type + "! $required + general_information TYPE ty_edoc_information, + + END OF ty_main. +ENDINTERFACE. diff --git a/file-formats/edot/type/zif_aff_edot_v1.intf.json b/file-formats/edot/type/zif_aff_edot_v1.intf.json new file mode 100644 index 000000000..77d2b8841 --- /dev/null +++ b/file-formats/edot/type/zif_aff_edot_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "Create eDocument Types", + "originalLanguage": "en" + } +} From 499d83ab10a4805ecabd10802d95e68d7c1b1aa5 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Mon, 27 Jan 2025 15:11:17 +0100 Subject: [PATCH 02/16] React to abaplint --- .../edoi/type/zif_aff_edoi_v1.intf.abap | 15 +++++++-------- .../edot/type/zif_aff_edot_v1.intf.abap | 18 ++++++++---------- 2 files changed, 15 insertions(+), 18 deletions(-) diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 3a77f0aef..bed1d9928 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -1,5 +1,4 @@ -INTERFACE zif_aff_edoi_v1 - PUBLIC. +INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Interface direction

"! Interface direction @@ -14,7 +13,7 @@ INTERFACE zif_aff_edoi_v1 "!

Interface Version

"! Interface Version "! $required - int_version TYPE numc04, + int_version TYPE edoc_int_version, "!

Interface Version Description

"! Interface Version Description "! $required @@ -27,7 +26,7 @@ INTERFACE zif_aff_edoi_v1 END OF ty_edoc_interface_version. "!

Interface Versions

"! eDocument Interface Versions - TYPES tt_edoc_interface_version TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version. + TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version. TYPES: "!

Attribute Determination for Communication with Cloud Edition

"! DRC Integration Attribute Determination @@ -55,12 +54,12 @@ INTERFACE zif_aff_edoi_v1 "!

Response Interface Version

"! Response Interface Version "! $required - resp_int_version TYPE numc04, + resp_int_version TYPE edoc_int_version, END OF ty_edoc_int_drc_attr. "!

Interface Versions

"! eDocument Interface Versions - TYPES tt_edoc_int_drc_attr TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. + TYPES ty_edoc_int_drc_attributes TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. TYPES: "!

General Information

"! eDocument Interface @@ -82,11 +81,11 @@ INTERFACE zif_aff_edoi_v1 "!

Interface Version

"! Interface Version "! $required - edocument_interface_version TYPE tt_edoc_interface_version, + edocument_interface_version TYPE ty_edoc_interface_versions, "!

Attribute Determination for Communication with Cloud Edition

"! DRC Integration Attribute Determination "! $required - edoc_spec_additional_table TYPE tt_edoc_int_drc_attr, + edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, END OF ty_edoc_interface. TYPES: "!

eDocument Interface

diff --git a/file-formats/edot/type/zif_aff_edot_v1.intf.abap b/file-formats/edot/type/zif_aff_edot_v1.intf.abap index 7347b5e13..95f1d611c 100644 --- a/file-formats/edot/type/zif_aff_edot_v1.intf.abap +++ b/file-formats/edot/type/zif_aff_edot_v1.intf.abap @@ -1,12 +1,10 @@ "!

Create eDocument Types

"! eDocument types that can be used in eInvoice Process -INTERFACE zif_aff_edot_v1 -PUBLIC. +INTERFACE zif_aff_edot_v1 PUBLIC. - TYPES: "!

eDocument Type

"! Specify eDocument types - ty_edoc_type TYPE c LENGTH 10. + TYPES ty_edoc_type TYPE c LENGTH 10. "!

Description

"! Description @@ -32,12 +30,12 @@ PUBLIC. END OF ty_sral_configuration. "!

SRAL Configuration Types

"! SRAL Configuration types - TYPES tt_sral_configuration TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type. + TYPES ty_sral_configurations TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type. TYPES: "!

eDocument Type Specific Additional Table Type

"! eDocument Type Specific Additional Table type - BEGIN OF ty_edoc_spec_additional_table, + BEGIN OF ty_additional_table, "!

Sequence Number Type

"! Sequence Number "! $required @@ -46,10 +44,10 @@ PUBLIC. "! Table name "! $required table_name TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_edoc_spec_additional_table. + END OF ty_additional_table. "!

eDocument Type Specific Additional Table Types

"! eDocument Type Specific Additional Table types - TYPES tt_edoc_spec_additional_table TYPE SORTED TABLE OF ty_edoc_spec_additional_table WITH UNIQUE KEY sequence_number_type. + TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY sequence_number_type. TYPES: "!

General Information

@@ -78,10 +76,10 @@ PUBLIC. archive_prep_req_type TYPE abap_bool, "!

Additional Selection Fields

"! Additional selection fields of validation report - edocument_sral_configuration TYPE tt_sral_configuration, + edocument_sral_configuration TYPE ty_sral_configurations, "!

eDocument Type Specific Additional Tables

"! eDocument Type Specific Additional Tables - edoc_spec_additional_table TYPE tt_edoc_spec_additional_table, + edoc_spec_additional_table TYPE ty_additional_tables, END OF ty_edoc_information. TYPES: From e1e96b219f7a6dbbac864dbb4f222addb319585b Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Mon, 27 Jan 2025 15:19:42 +0100 Subject: [PATCH 03/16] React to abaplint --- file-formats/edoi/edoi-v1.json | 6 ++---- file-formats/edoi/type/zif_aff_edoi_v1.intf.abap | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 1ad363d6e..0e20aaed2 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -106,8 +106,7 @@ "title": "Interface Version", "description": "Interface Version", "type": "string", - "maxLength": 4, - "pattern": "^[0-9]+$" + "maxLength": 4 }, "intVersionDesc": { "title": "Interface Version Description", @@ -174,8 +173,7 @@ "title": "Response Interface Version", "description": "Response Interface Version", "type": "string", - "maxLength": 4, - "pattern": "^[0-9]+$" + "maxLength": 4 } }, "additionalProperties": false, diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index bed1d9928..90d3997e0 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -13,7 +13,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Interface Version

"! Interface Version "! $required - int_version TYPE edoc_int_version, + int_version TYPE c LENGTH 4, "!

Interface Version Description

"! Interface Version Description "! $required @@ -54,7 +54,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Response Interface Version

"! Response Interface Version "! $required - resp_int_version TYPE edoc_int_version, + resp_int_version TYPE c LENGTH 4, END OF ty_edoc_int_drc_attr. "!

Interface Versions

From 3a2e9b9517d1f1c06a49a28a34d7dd0491846001 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 28 Jan 2025 09:45:40 +0100 Subject: [PATCH 04/16] React to comments from Michael Schneider --- file-formats/edoi/.DS_Store | Bin 6148 -> 0 bytes file-formats/edot/.DS_Store | Bin 6148 -> 0 bytes file-formats/edot/README.md | 5 - file-formats/edot/edot-v1.json | 185 ------------------ .../edot/type/zif_aff_edot_v1.intf.abap | 103 ---------- .../edot/type/zif_aff_edot_v1.intf.json | 7 - 6 files changed, 300 deletions(-) delete mode 100644 file-formats/edoi/.DS_Store delete mode 100644 file-formats/edot/.DS_Store delete mode 100644 file-formats/edot/README.md delete mode 100644 file-formats/edot/edot-v1.json delete mode 100644 file-formats/edot/type/zif_aff_edot_v1.intf.abap delete mode 100644 file-formats/edot/type/zif_aff_edot_v1.intf.json diff --git a/file-formats/edoi/.DS_Store b/file-formats/edoi/.DS_Store deleted file mode 100644 index 15c04208536080b609881173172966e05394ceb5..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeH~F>b>!3`IW^4*{}x?5L#&$PI)bIYBQ_H0~B40n!fLbo72wTb%_`(ma_?&L1^T*|K_9AW70Z-{8X8XAOSd_o2|8HQ74j)4>oU06DN6#&ygRWbp!7ldY2#n&tFh z*=jL{cs<(5lGoK_>+J2Y96l`XY(B-%thd7o6Pne4f)tPfGX>T?AN~A4(jU$LvlgXN zKnnab1#CFH9rk>wJX`Nx&+G45^>w3@aXG`Ep8zI)6u;2JxLET HJXL{T_8Ah# diff --git a/file-formats/edot/.DS_Store b/file-formats/edot/.DS_Store deleted file mode 100644 index 15c04208536080b609881173172966e05394ceb5..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeH~F>b>!3`IW^4*{}x?5L#&$PI)bIYBQ_H0~B40n!fLbo72wTb%_`(ma_?&L1^T*|K_9AW70Z-{8X8XAOSd_o2|8HQ74j)4>oU06DN6#&ygRWbp!7ldY2#n&tFh z*=jL{cs<(5lGoK_>+J2Y96l`XY(B-%thd7o6Pne4f)tPfGX>T?AN~A4(jU$LvlgXN zKnnab1#CFH9rk>wJX`Nx&+G45^>w3@aXG`Ep8zI)6u;2JxLET HJXL{T_8Ah# diff --git a/file-formats/edot/README.md b/file-formats/edot/README.md deleted file mode 100644 index 23a553e6b..000000000 --- a/file-formats/edot/README.md +++ /dev/null @@ -1,5 +0,0 @@ -# EDOT File Format - -File | Cardinality | Definition | Schema | Example -:--- | :--- | :--- | :--- | :--- -`.edot.json` | 1 | [`zif_aff_edot_v1.intf.abap`](./type/zif_aff_edot_v1.intf.abap) | [`edot-v1.json`](./edot-v1.json) diff --git a/file-formats/edot/edot-v1.json b/file-formats/edot/edot-v1.json deleted file mode 100644 index 35fe1e474..000000000 --- a/file-formats/edot/edot-v1.json +++ /dev/null @@ -1,185 +0,0 @@ -{ - "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", - "$schema": "https://json-schema.org/draft/2020-12/schema", - "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edot/edot-v1.json", - "title": "eDocument Type", - "description": "eDocument Type", - "type": "object", - "properties": { - "formatVersion": { - "title": "Format Version", - "description": "Format version", - "type": "string", - "const": "1" - }, - "header": { - "title": "Header", - "description": "Header", - "type": "object", - "properties": { - "description": { - "title": "Description", - "description": "Description of the ABAP object", - "type": "string", - "maxLength": 60 - }, - "originalLanguage": { - "title": "Original Language", - "description": "Original language of the ABAP object", - "type": "string", - "minLength": 2 - }, - "abapLanguageVersion": { - "title": "ABAP Language Version", - "description": "ABAP language version", - "type": "string", - "enum": [ - "standard", - "keyUser", - "cloudDevelopment" - ], - "enumTitles": [ - "Standard", - "ABAP for Key Users", - "ABAP Cloud Development" - ], - "enumDescriptions": [ - "Standard", - "ABAP for key user extensibility", - "ABAP cloud development" - ], - "default": "standard" - } - }, - "additionalProperties": false, - "required": [ - "description", - "originalLanguage" - ] - }, - "generalInformation": { - "title": "eDocument Type", - "description": "eDocument Type", - "type": "object", - "properties": { - "edocumentType": { - "title": "eDocument Type", - "description": "eDoc Type", - "type": "string", - "maxLength": 10 - }, - "edocTypeDesc": { - "title": "Description", - "description": "eDocument Type Description", - "type": "string", - "maxLength": 30 - }, - "contingency": { - "title": "Created in Contingency Mode", - "description": "Contingency", - "type": "boolean" - }, - "contingencyType": { - "title": "eDocument Type Created Using Contingency", - "description": "Contingency Type", - "type": "string", - "maxLength": 10 - }, - "tableName": { - "title": "Table Name", - "description": "Table name", - "type": "string", - "maxLength": 30 - }, - "archivePrepReqType": { - "title": "Preprocess Before Archiving", - "description": "Archive Prep Req Type", - "type": "boolean" - }, - "edocumentSralConfiguration": { - "title": "Additional Selection Fields", - "description": "Additional selection fields of validation report", - "type": "array", - "uniqueItems": true, - "items": { - "title": "SRAL Configuration Type", - "description": "eDocument SRAL Configuration type", - "type": "object", - "properties": { - "fileType": { - "title": "File Type", - "description": "File Type", - "type": "string", - "maxLength": 10 - }, - "fileStructureType": { - "title": "File Structure Type", - "description": "File Structure type", - "type": "string", - "maxLength": 30 - }, - "fileDescriptionType": { - "title": "File Description", - "description": "File Description type", - "type": "string", - "maxLength": 60 - }, - "notCloudRelevantType": { - "title": "File Cloud Relevancy", - "description": "File Cloud Relevancy type", - "type": "boolean" - } - }, - "additionalProperties": false, - "required": [ - "fileType", - "fileStructureType" - ] - } - }, - "edocSpecAdditionalTable": { - "title": "eDocument Type Specific Additional Tables", - "description": "eDocument Type Specific Additional Tables", - "type": "array", - "uniqueItems": true, - "items": { - "title": "eDocument Type Specific Additional Table Type", - "description": "eDocument Type Specific Additional Table type", - "type": "object", - "properties": { - "sequenceNumberType": { - "title": "Sequence Number Type", - "description": "Sequence Number", - "type": "string", - "maxLength": 10 - }, - "tableName": { - "title": "Table Name", - "description": "Table name", - "type": "string", - "maxLength": 30 - } - }, - "additionalProperties": false, - "required": [ - "sequenceNumberType", - "tableName" - ] - } - } - }, - "additionalProperties": false, - "required": [ - "edocumentType", - "edocTypeDesc", - "archivePrepReqType" - ] - } - }, - "additionalProperties": false, - "required": [ - "formatVersion", - "header", - "generalInformation" - ] -} diff --git a/file-formats/edot/type/zif_aff_edot_v1.intf.abap b/file-formats/edot/type/zif_aff_edot_v1.intf.abap deleted file mode 100644 index 95f1d611c..000000000 --- a/file-formats/edot/type/zif_aff_edot_v1.intf.abap +++ /dev/null @@ -1,103 +0,0 @@ -"!

Create eDocument Types

-"! eDocument types that can be used in eInvoice Process -INTERFACE zif_aff_edot_v1 PUBLIC. - - "!

eDocument Type

- "! Specify eDocument types - TYPES ty_edoc_type TYPE c LENGTH 10. - - "!

Description

- "! Description - TYPES ty_short_description TYPE c LENGTH 30. - TYPES: - "!

SRAL Configuration Type

- "! eDocument SRAL Configuration type - BEGIN OF ty_sral_configuration, - "!

File Type

- "! File Type - "! $required - file_type TYPE c LENGTH 10, - "!

File Structure Type

- "! File Structure type - "! $required - file_structure_type TYPE c LENGTH 30, - "!

File Description

- "! File Description type - file_description_type TYPE c LENGTH 60, - "!

File Cloud Relevancy

- "! File Cloud Relevancy type - not_cloud_relevant_type TYPE abap_bool, - END OF ty_sral_configuration. - "!

SRAL Configuration Types

- "! SRAL Configuration types - TYPES ty_sral_configurations TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type. - - TYPES: - "!

eDocument Type Specific Additional Table Type

- "! eDocument Type Specific Additional Table type - BEGIN OF ty_additional_table, - "!

Sequence Number Type

- "! Sequence Number - "! $required - sequence_number_type TYPE c LENGTH 10, - "!

Table Name

- "! Table name - "! $required - table_name TYPE zif_aff_types_v1=>ty_object_name_30, - END OF ty_additional_table. - "!

eDocument Type Specific Additional Table Types

- "! eDocument Type Specific Additional Table types - TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY sequence_number_type. - - TYPES: - "!

General Information

- "! eDocument Type - BEGIN OF ty_edoc_information, - "!

eDocument Type

- "! eDoc Type - "! $required - edocument_type TYPE ty_edoc_type, - "!

Description

- "! eDocument Type Description - "! $required - edoc_type_desc TYPE ty_short_description, - "!

Created in Contingency Mode

- "! Contingency - contingency TYPE abap_bool, - "!

eDocument Type Created Using Contingency

- "! Contingency Type - contingency_type TYPE c LENGTH 10, - "!

Table Name

- "! Table name - table_name TYPE zif_aff_types_v1=>ty_object_name_30, - "!

Preprocess Before Archiving

- "! Archive Prep Req Type - "! $required - archive_prep_req_type TYPE abap_bool, - "!

Additional Selection Fields

- "! Additional selection fields of validation report - edocument_sral_configuration TYPE ty_sral_configurations, - "!

eDocument Type Specific Additional Tables

- "! eDocument Type Specific Additional Tables - edoc_spec_additional_table TYPE ty_additional_tables, - END OF ty_edoc_information. - - TYPES: - "!

eDocument Type

- "! eDocument Type - BEGIN OF ty_main, - "!

Format Version

- "! Format version - "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, - "!

Header

- "! Header - "! $required - header TYPE zif_aff_types_v1=>ty_header_60, - "!

eDocument Type

- "! eDocument Type - "! $required - general_information TYPE ty_edoc_information, - - END OF ty_main. -ENDINTERFACE. diff --git a/file-formats/edot/type/zif_aff_edot_v1.intf.json b/file-formats/edot/type/zif_aff_edot_v1.intf.json deleted file mode 100644 index 77d2b8841..000000000 --- a/file-formats/edot/type/zif_aff_edot_v1.intf.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "formatVersion": "1", - "header": { - "description": "Create eDocument Types", - "originalLanguage": "en" - } -} From 6b8c5b2b8b5f744e41862702c1f189b308010030 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 4 Feb 2025 10:54:10 +0100 Subject: [PATCH 05/16] reaction to comments --- file-formats/edoi/edoi-v1.json | 57 ++++++----------- .../edoi/type/zif_aff_edoi_v1.intf.abap | 64 ++++++++----------- 2 files changed, 46 insertions(+), 75 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 0e20aaed2..faf096602 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -3,7 +3,7 @@ "$schema": "https://json-schema.org/draft/2020-12/schema", "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edoi/edoi-v1.json", "title": "eDocument Interface", - "description": "eDocument Interface", + "description": "eDocument interface", "type": "object", "properties": { "formatVersion": { @@ -21,7 +21,7 @@ "title": "Description", "description": "Description of the ABAP object", "type": "string", - "maxLength": 60 + "maxLength": 100 }, "originalLanguage": { "title": "Original Language", @@ -35,17 +35,14 @@ "type": "string", "enum": [ "standard", - "keyUser", "cloudDevelopment" ], "enumTitles": [ "Standard", - "ABAP for Key Users", "ABAP Cloud Development" ], "enumDescriptions": [ "Standard", - "ABAP for key user extensibility", "ABAP cloud development" ], "default": "standard" @@ -58,25 +55,13 @@ ] }, "generalInformation": { - "title": "eDocument Interface", - "description": "eDocument Interface", + "title": "General Information", + "description": "General information", "type": "object", "properties": { - "edocumentInterfaceId": { - "title": "eDocument Interface", - "description": "eDocument Interface", - "type": "string", - "maxLength": 30 - }, - "interfaceDescription": { - "title": "eDocument Interface Description", - "description": "Interface Description.", - "type": "string", - "maxLength": 100 - }, "interfaceDirection": { - "title": "eDocument Interface Direction", - "description": "Interface Direction.", + "title": "Interface Direction", + "description": "Interface direction.", "type": "string", "enum": [ "outbound", @@ -92,25 +77,25 @@ ], "default": "outbound" }, - "edocumentInterfaceVersion": { + "interfaceVersion": { "title": "Interface Version", - "description": "Interface Version", + "description": "Interface version", "type": "array", "uniqueItems": true, "items": { "title": "Interface Version", - "description": "eDocument Interface Version", + "description": "eDocument interface version", "type": "object", "properties": { "intVersion": { "title": "Interface Version", - "description": "Interface Version", + "description": "Interface version", "type": "string", "maxLength": 4 }, "intVersionDesc": { "title": "Interface Version Description", - "description": "Interface Version Description", + "description": "Interface dersion description", "type": "string", "maxLength": 30 }, @@ -131,47 +116,47 @@ }, "edocSpecAdditionalTable": { "title": "Attribute Determination for Communication with Cloud Edition", - "description": "DRC Integration Attribute Determination", + "description": "Attribute determination for communication with cloud edition", "type": "array", "uniqueItems": true, "items": { "title": "Attribute Determination for Communication with Cloud Edition", - "description": "DRC Integration Attribute Determination", + "description": "Attribute determination for communication with cloud edition", "type": "object", "properties": { "processType": { "title": "Process Type", - "description": "DRC Process Type", + "description": "DRC process type", "type": "string", "maxLength": 50 }, "processVersion": { "title": "Process Version", - "description": "DRC Process Version", + "description": "DRC process version", "type": "string", "maxLength": 20 }, "processSubtype": { "title": "Process Subtype", - "description": "DRC Process Subtype", + "description": "DRC process subtype", "type": "string", "maxLength": 50 }, "drcAction": { "title": "Action", - "description": "DRC Process Action", + "description": "DRC process action", "type": "string", "maxLength": 30 }, "respInterfaceId": { "title": "Response Interface", - "description": "eDoc Response Interface", + "description": "eDoc response interface", "type": "string", "maxLength": 30 }, "respIntVersion": { "title": "Response Interface Version", - "description": "Response Interface Version", + "description": "Response interface version", "type": "string", "maxLength": 4 } @@ -190,10 +175,8 @@ }, "additionalProperties": false, "required": [ - "edocumentInterfaceId", - "interfaceDescription", "interfaceDirection", - "edocumentInterfaceVersion", + "interfaceVersion", "edocSpecAdditionalTable" ] } diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 90d3997e0..b4c4ae80b 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -1,95 +1,83 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. - "!

Interface direction

+ "!

Interface Direction

"! Interface direction - "! $required "! $values {@link zif_aff_edoi_v1.data:co_edoc_int_direction} "! $default {@link zif_aff_edoi_v1.data:co_edoc_int_direction.outbound} TYPES ty_int_direction TYPE c LENGTH 1. TYPES: "!

Interface Version

- "! eDocument Interface Version + "! eDocument interface version BEGIN OF ty_edoc_interface_version, "!

Interface Version

- "! Interface Version + "! Interface version "! $required int_version TYPE c LENGTH 4, "!

Interface Version Description

- "! Interface Version Description + "! Interface dersion description "! $required int_version_desc TYPE c LENGTH 30, "!

Active From

"! Active from "! $required active_from TYPE sy-datum, - END OF ty_edoc_interface_version. "!

Interface Versions

- "! eDocument Interface Versions + "! eDocument interface versions TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version. TYPES: "!

Attribute Determination for Communication with Cloud Edition

- "! DRC Integration Attribute Determination + "! Attribute determination for communication with cloud edition BEGIN OF ty_edoc_int_drc_attr, "!

Process Type

- "! DRC Process Type + "! DRC process type "! $required process_type TYPE c LENGTH 50, "!

Process Version

- "! DRC Process Version + "! DRC process version "! $required process_version TYPE c LENGTH 20, "!

Process Subtype

- "! DRC Process Subtype + "! DRC process subtype "! $required process_subtype TYPE c LENGTH 50, "!

Action

- "! DRC Process Action + "! DRC process action "! $required drc_action TYPE c LENGTH 30, "!

Response Interface

- "! eDoc Response Interface + "! eDoc response interface "! $required resp_interface_id TYPE c LENGTH 30, "!

Response Interface Version

- "! Response Interface Version + "! Response interface version "! $required resp_int_version TYPE c LENGTH 4, END OF ty_edoc_int_drc_attr. "!

Interface Versions

- "! eDocument Interface Versions + "! eDocument interface versions TYPES ty_edoc_int_drc_attributes TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. TYPES: "!

General Information

- "! eDocument Interface + "! General information BEGIN OF ty_edoc_interface, - "!

eDocument Interface

- "! eDocument Interface - "! $required - edocument_interface_id TYPE c LENGTH 30, - "!

eDocument Interface Description

- "! Interface Description. + "!

Interface Direction

+ "! Interface direction. "! $required - interface_description TYPE c LENGTH 100, - - "!

eDocument Interface Direction

- "! Interface Direction. - "! $required - interface_direction TYPE ty_int_direction, - + interface_direction TYPE ty_int_direction, "!

Interface Version

- "! Interface Version + "! Interface version "! $required - edocument_interface_version TYPE ty_edoc_interface_versions, + interface_version TYPE ty_edoc_interface_versions, "!

Attribute Determination for Communication with Cloud Edition

- "! DRC Integration Attribute Determination + "! Attribute determination for communication with cloud edition "! $required - edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, + edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, END OF ty_edoc_interface. TYPES: "!

eDocument Interface

- "! eDocument Interface + "! eDocument interface BEGIN OF ty_main, "!

Format Version

"! Format version @@ -98,9 +86,9 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_60, - "!

eDocument Interface

- "! eDocument Interface + header TYPE zif_aff_types_v1=>ty_header_100_cloud, + "!

General Information

+ "! General information "! $required general_information TYPE ty_edoc_interface, @@ -108,7 +96,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. CONSTANTS: "!

Interface Direction

- "! Interface Direction + "! Interface direction BEGIN OF co_edoc_int_direction, "!

Outbound

"! Outbound From 27591480261676161c86c647742090b0fac31634 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Wed, 19 Feb 2025 14:13:08 +0100 Subject: [PATCH 06/16] corrections --- file-formats/edoi/edoi-v1.json | 198 +++++++++--------- .../edoi/type/zif_aff_edoi_v1.intf.abap | 69 +++--- 2 files changed, 135 insertions(+), 132 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index faf096602..804b5c354 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -76,115 +76,115 @@ "Inbound" ], "default": "outbound" - }, - "interfaceVersion": { - "title": "Interface Version", - "description": "Interface version", - "type": "array", - "uniqueItems": true, - "items": { - "title": "Interface Version", - "description": "eDocument interface version", - "type": "object", - "properties": { - "intVersion": { - "title": "Interface Version", - "description": "Interface version", - "type": "string", - "maxLength": 4 - }, - "intVersionDesc": { - "title": "Interface Version Description", - "description": "Interface dersion description", - "type": "string", - "maxLength": 30 - }, - "activeFrom": { - "title": "Active From", - "description": "Active from", - "type": "string", - "format": "date-time" - } - }, - "additionalProperties": false, - "required": [ - "intVersion", - "intVersionDesc", - "activeFrom" - ] - } - }, - "edocSpecAdditionalTable": { - "title": "Attribute Determination for Communication with Cloud Edition", - "description": "Attribute determination for communication with cloud edition", - "type": "array", - "uniqueItems": true, - "items": { - "title": "Attribute Determination for Communication with Cloud Edition", - "description": "Attribute determination for communication with cloud edition", - "type": "object", - "properties": { - "processType": { - "title": "Process Type", - "description": "DRC process type", - "type": "string", - "maxLength": 50 - }, - "processVersion": { - "title": "Process Version", - "description": "DRC process version", - "type": "string", - "maxLength": 20 - }, - "processSubtype": { - "title": "Process Subtype", - "description": "DRC process subtype", - "type": "string", - "maxLength": 50 - }, - "drcAction": { - "title": "Action", - "description": "DRC process action", - "type": "string", - "maxLength": 30 - }, - "respInterfaceId": { - "title": "Response Interface", - "description": "eDoc response interface", - "type": "string", - "maxLength": 30 - }, - "respIntVersion": { - "title": "Response Interface Version", - "description": "Response interface version", - "type": "string", - "maxLength": 4 - } - }, - "additionalProperties": false, - "required": [ - "processType", - "processVersion", - "processSubtype", - "drcAction", - "respInterfaceId", - "respIntVersion" - ] - } } }, "additionalProperties": false, "required": [ - "interfaceDirection", - "interfaceVersion", - "edocSpecAdditionalTable" + "interfaceDirection" ] + }, + "interfaceVersion": { + "title": "Interface Version", + "description": "Interface version", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Interface Version", + "description": "eDocument interface version", + "type": "object", + "properties": { + "interfaceVersion": { + "title": "Interface Version", + "description": "Interface version", + "type": "string", + "maxLength": 4 + }, + "interfaceVersionDescription": { + "title": "Interface Version Description", + "description": "Interface dersion description", + "type": "string", + "maxLength": 30 + }, + "activeFrom": { + "title": "Active From", + "description": "Active from", + "type": "string", + "format": "date-time" + } + }, + "additionalProperties": false, + "required": [ + "interfaceVersion", + "interfaceVersionDescription", + "activeFrom" + ] + } + }, + "edocSpecAdditionalTable": { + "title": "Attribute Determination for Communication with Cloud Edition", + "description": "Attribute determination for communication with cloud edition", + "type": "array", + "uniqueItems": true, + "items": { + "title": "Attribute Determination for Communication with Cloud Edition", + "description": "Attribute determination for communication with cloud edition", + "type": "object", + "properties": { + "processType": { + "title": "Process Type", + "description": "DRC process type", + "type": "string", + "maxLength": 50 + }, + "processVersion": { + "title": "Process Version", + "description": "DRC process version", + "type": "string", + "maxLength": 20 + }, + "processSubtype": { + "title": "Process Subtype", + "description": "DRC process subtype", + "type": "string", + "maxLength": 50 + }, + "drcAction": { + "title": "Action", + "description": "DRC process action", + "type": "string", + "maxLength": 30 + }, + "responseInterfaceId": { + "title": "Response Interface", + "description": "eDoc response interface", + "type": "string", + "maxLength": 30 + }, + "responseInterfaceVersion": { + "title": "Response Interface Version", + "description": "Response interface version", + "type": "string", + "maxLength": 4 + } + }, + "additionalProperties": false, + "required": [ + "processType", + "processVersion", + "processSubtype", + "drcAction", + "responseInterfaceId", + "responseInterfaceVersion" + ] + } } }, "additionalProperties": false, "required": [ "formatVersion", "header", - "generalInformation" + "generalInformation", + "interfaceVersion", + "edocSpecAdditionalTable" ] } diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index b4c4ae80b..c5cb6272e 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -12,19 +12,19 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Interface Version

"! Interface version "! $required - int_version TYPE c LENGTH 4, + interface_version TYPE c LENGTH 4, "!

Interface Version Description

"! Interface dersion description "! $required - int_version_desc TYPE c LENGTH 30, + interface_version_description TYPE c LENGTH 30, "!

Active From

"! Active from "! $required - active_from TYPE sy-datum, + active_from TYPE sy-datum, END OF ty_edoc_interface_version. "!

Interface Versions

"! eDocument interface versions - TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY int_version. + TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY interface_version. TYPES: "!

Attribute Determination for Communication with Cloud Edition

"! Attribute determination for communication with cloud edition @@ -32,32 +32,45 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Process Type

"! DRC process type "! $required - process_type TYPE c LENGTH 50, + process_type TYPE c LENGTH 50, "!

Process Version

"! DRC process version "! $required - process_version TYPE c LENGTH 20, + process_version TYPE c LENGTH 20, "!

Process Subtype

"! DRC process subtype "! $required - process_subtype TYPE c LENGTH 50, + process_subtype TYPE c LENGTH 50, "!

Action

"! DRC process action "! $required - drc_action TYPE c LENGTH 30, + drc_action TYPE c LENGTH 30, "!

Response Interface

"! eDoc response interface "! $required - resp_interface_id TYPE c LENGTH 30, + response_interface_id TYPE c LENGTH 30, "!

Response Interface Version

"! Response interface version "! $required - resp_int_version TYPE c LENGTH 4, + response_interface_version TYPE c LENGTH 4, END OF ty_edoc_int_drc_attr. "!

Interface Versions

"! eDocument interface versions TYPES ty_edoc_int_drc_attributes TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. + + CONSTANTS: + "!

Interface Direction

+ "! Interface direction + BEGIN OF co_edoc_int_direction, + "!

Outbound

+ "! Outbound + outbound TYPE ty_int_direction VALUE 'O', + "!

Inbound

+ "! Inbound + inbound TYPE ty_int_direction VALUE 'I', + END OF co_edoc_int_direction. + TYPES: "!

General Information

"! General information @@ -65,16 +78,9 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Interface Direction

"! Interface direction. "! $required - interface_direction TYPE ty_int_direction, - "!

Interface Version

- "! Interface version - "! $required - interface_version TYPE ty_edoc_interface_versions, - "!

Attribute Determination for Communication with Cloud Edition

- "! Attribute determination for communication with cloud edition - "! $required - edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, + interface_direction TYPE ty_int_direction, END OF ty_edoc_interface. + TYPES: "!

eDocument Interface

"! eDocument interface @@ -82,27 +88,24 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Format Version

"! Format version "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_100_cloud, + header TYPE zif_aff_types_v1=>ty_header_100_cloud, "!

General Information

"! General information "! $required - general_information TYPE ty_edoc_interface, + general_information TYPE ty_edoc_interface, + "!

Interface Version

+ "! Interface version + "! $required + interface_version TYPE ty_edoc_interface_versions, + "!

Attribute Determination for Communication with Cloud Edition

+ "! Attribute determination for communication with cloud edition + "! $required + edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, END OF ty_main. - CONSTANTS: - "!

Interface Direction

- "! Interface direction - BEGIN OF co_edoc_int_direction, - "!

Outbound

- "! Outbound - outbound TYPE ty_int_direction VALUE 'O', - "!

Inbound

- "! Inbound - inbound TYPE ty_int_direction VALUE 'I', - END OF co_edoc_int_direction. ENDINTERFACE. From bbc4f1b393f6fce0299a86291dfbb0e6108a3f62 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Wed, 26 Feb 2025 11:17:47 +0100 Subject: [PATCH 07/16] corrections --- file-formats/edoi/edoi-v1.json | 30 +++---- .../edoi/type/zif_aff_edoi_v1.intf.abap | 79 ++++++++++--------- .../edoi/type/zif_aff_edoi_v1.intf.json | 2 +- 3 files changed, 53 insertions(+), 58 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 804b5c354..3c4af4674 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -63,19 +63,7 @@ "title": "Interface Direction", "description": "Interface direction.", "type": "string", - "enum": [ - "outbound", - "inbound" - ], - "enumTitles": [ - "Outbound", - "Inbound" - ], - "enumDescriptions": [ - "Outbound", - "Inbound" - ], - "default": "outbound" + "maxLength": 1 } }, "additionalProperties": false, @@ -96,12 +84,13 @@ "interfaceVersion": { "title": "Interface Version", "description": "Interface version", - "type": "string", - "maxLength": 4 + "type": "integer", + "minimum": 1, + "maximum": 9999 }, "interfaceVersionDescription": { "title": "Interface Version Description", - "description": "Interface dersion description", + "description": "Interface version description", "type": "string", "maxLength": 30 }, @@ -120,7 +109,7 @@ ] } }, - "edocSpecAdditionalTable": { + "drcAttributes": { "title": "Attribute Determination for Communication with Cloud Edition", "description": "Attribute determination for communication with cloud edition", "type": "array", @@ -163,8 +152,9 @@ "responseInterfaceVersion": { "title": "Response Interface Version", "description": "Response interface version", - "type": "string", - "maxLength": 4 + "type": "integer", + "minimum": 1, + "maximum": 9999 } }, "additionalProperties": false, @@ -185,6 +175,6 @@ "header", "generalInformation", "interfaceVersion", - "edocSpecAdditionalTable" + "drcAttributes" ] } diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index c5cb6272e..2ee5ed9fb 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -4,31 +4,55 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "! Interface direction "! $values {@link zif_aff_edoi_v1.data:co_edoc_int_direction} "! $default {@link zif_aff_edoi_v1.data:co_edoc_int_direction.outbound} - TYPES ty_int_direction TYPE c LENGTH 1. + TYPES ty_interface_direction TYPE c LENGTH 1. + CONSTANTS: + "!

Interface Direction

+ "! Interface direction + BEGIN OF co_interface_direction, + "!

Outbound

+ "! Outbound + outbound TYPE ty_interface_direction VALUE 'O', + "!

Inbound

+ "! Inbound + inbound TYPE ty_interface_direction VALUE 'I', + END OF co_interface_direction. + + TYPES: + "!

General Information

+ "! General information + BEGIN OF ty_interface, + "!

Interface Direction

+ "! Interface direction. + "! $required + interface_direction TYPE ty_interface_direction, + END OF ty_interface. + TYPES: "!

Interface Version

"! eDocument interface version - BEGIN OF ty_edoc_interface_version, + BEGIN OF ty_interface_version, "!

Interface Version

"! Interface version "! $required - interface_version TYPE c LENGTH 4, + "! $minimum 1 + "! $maximum 9999 + interface_version TYPE i, "!

Interface Version Description

- "! Interface dersion description + "! Interface version description "! $required interface_version_description TYPE c LENGTH 30, "!

Active From

"! Active from "! $required active_from TYPE sy-datum, - END OF ty_edoc_interface_version. + END OF ty_interface_version. "!

Interface Versions

- "! eDocument interface versions - TYPES ty_edoc_interface_versions TYPE SORTED TABLE OF ty_edoc_interface_version WITH UNIQUE KEY interface_version. + "! ainterface versions + TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY interface_version. TYPES: "!

Attribute Determination for Communication with Cloud Edition

"! Attribute determination for communication with cloud edition - BEGIN OF ty_edoc_int_drc_attr, + BEGIN OF ty_drc_attribute, "!

Process Type

"! DRC process type "! $required @@ -52,34 +76,15 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Response Interface Version

"! Response interface version "! $required - response_interface_version TYPE c LENGTH 4, + "! $minimum 1 + "! $maximum 9999 + response_interface_version TYPE i, - END OF ty_edoc_int_drc_attr. + END OF ty_drc_attribute. "!

Interface Versions

"! eDocument interface versions - TYPES ty_edoc_int_drc_attributes TYPE SORTED TABLE OF ty_edoc_int_drc_attr WITH UNIQUE KEY process_type. + TYPES ty_drc_attributes TYPE SORTED TABLE OF ty_drc_attribute WITH UNIQUE KEY process_type. - CONSTANTS: - "!

Interface Direction

- "! Interface direction - BEGIN OF co_edoc_int_direction, - "!

Outbound

- "! Outbound - outbound TYPE ty_int_direction VALUE 'O', - "!

Inbound

- "! Inbound - inbound TYPE ty_int_direction VALUE 'I', - END OF co_edoc_int_direction. - - TYPES: - "!

General Information

- "! General information - BEGIN OF ty_edoc_interface, - "!

Interface Direction

- "! Interface direction. - "! $required - interface_direction TYPE ty_int_direction, - END OF ty_edoc_interface. TYPES: "!

eDocument Interface

@@ -88,23 +93,23 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Format Version

"! Format version "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_100_cloud, + header TYPE zif_aff_types_v1=>ty_header_100_cloud, "!

General Information

"! General information "! $required - general_information TYPE ty_edoc_interface, + general_information TYPE ty_interface, "!

Interface Version

"! Interface version "! $required - interface_version TYPE ty_edoc_interface_versions, + interface_version TYPE ty_interface_versions, "!

Attribute Determination for Communication with Cloud Edition

"! Attribute determination for communication with cloud edition "! $required - edoc_spec_additional_table TYPE ty_edoc_int_drc_attributes, + drc_attributes TYPE ty_drc_attributes, END OF ty_main. diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.json b/file-formats/edoi/type/zif_aff_edoi_v1.intf.json index 77d2b8841..b44d20b8c 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.json +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.json @@ -1,7 +1,7 @@ { "formatVersion": "1", "header": { - "description": "Create eDocument Types", + "description": "AFF for eDocument Interface (EDOI)", "originalLanguage": "en" } } From 63a14531d8f2d35a9a3fb694eac18e28f003b4be Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 11 Mar 2025 19:19:10 +0100 Subject: [PATCH 08/16] correction --- file-formats/edoi/type/zif_aff_edoi_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 2ee5ed9fb..35634d4f1 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -47,7 +47,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. active_from TYPE sy-datum, END OF ty_interface_version. "!

Interface Versions

- "! ainterface versions + "! Interface versions TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY interface_version. TYPES: "!

Attribute Determination for Communication with Cloud Edition

From 167be4849a52a203ad3928038e6bda6ea0aaca33 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Thu, 13 Mar 2025 17:28:57 +0100 Subject: [PATCH 09/16] corrections --- file-formats/edoi/edoi-v1.json | 22 ++++++++--------- .../edoi/type/zif_aff_edoi_v1.intf.abap | 24 +++++++++---------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 3c4af4674..0858a53bb 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -61,7 +61,7 @@ "properties": { "interfaceDirection": { "title": "Interface Direction", - "description": "Interface direction.", + "description": "Interface direction", "type": "string", "maxLength": 1 } @@ -81,16 +81,16 @@ "description": "eDocument interface version", "type": "object", "properties": { - "interfaceVersion": { - "title": "Interface Version", - "description": "Interface version", + "version": { + "title": "Version", + "description": "Version", "type": "integer", "minimum": 1, "maximum": 9999 }, - "interfaceVersionDescription": { - "title": "Interface Version Description", - "description": "Interface version description", + "description": { + "title": "Description", + "description": "Description", "type": "string", "maxLength": 30 }, @@ -103,8 +103,8 @@ }, "additionalProperties": false, "required": [ - "interfaceVersion", - "interfaceVersionDescription", + "version", + "description", "activeFrom" ] } @@ -143,7 +143,7 @@ "type": "string", "maxLength": 30 }, - "responseInterfaceId": { + "responseInterface": { "title": "Response Interface", "description": "eDoc response interface", "type": "string", @@ -163,7 +163,7 @@ "processVersion", "processSubtype", "drcAction", - "responseInterfaceId", + "responseInterface", "responseInterfaceVersion" ] } diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 35634d4f1..71a104b73 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -20,27 +20,27 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. TYPES: "!

General Information

"! General information - BEGIN OF ty_interface, + BEGIN OF ty_general_information, "!

Interface Direction

- "! Interface direction. + "! Interface direction "! $required interface_direction TYPE ty_interface_direction, - END OF ty_interface. + END OF ty_general_information. TYPES: "!

Interface Version

"! eDocument interface version BEGIN OF ty_interface_version, - "!

Interface Version

- "! Interface version + "!

Version

+ "! Version "! $required "! $minimum 1 "! $maximum 9999 - interface_version TYPE i, - "!

Interface Version Description

- "! Interface version description + version TYPE i, + "!

Description

+ "! Description "! $required - interface_version_description TYPE c LENGTH 30, + description TYPE c LENGTH 30, "!

Active From

"! Active from "! $required @@ -48,7 +48,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. END OF ty_interface_version. "!

Interface Versions

"! Interface versions - TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY interface_version. + TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY version. TYPES: "!

Attribute Determination for Communication with Cloud Edition

"! Attribute determination for communication with cloud edition @@ -72,7 +72,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Response Interface

"! eDoc response interface "! $required - response_interface_id TYPE c LENGTH 30, + response_interface TYPE c LENGTH 30, "!

Response Interface Version

"! Response interface version "! $required @@ -101,7 +101,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

General Information

"! General information "! $required - general_information TYPE ty_interface, + general_information TYPE ty_general_information, "!

Interface Version

"! Interface version "! $required From dedf71fc07743b3c739151ba4a5956fe9c230c1e Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Thu, 13 Mar 2025 17:32:42 +0100 Subject: [PATCH 10/16] correction --- file-formats/edoi/type/zif_aff_edoi_v1.intf.abap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 71a104b73..3926ab726 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -36,7 +36,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "! $required "! $minimum 1 "! $maximum 9999 - version TYPE i, + version TYPE i, "!

Description

"! Description "! $required @@ -44,7 +44,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Active From

"! Active from "! $required - active_from TYPE sy-datum, + active_from TYPE sy-datum, END OF ty_interface_version. "!

Interface Versions

"! Interface versions @@ -72,7 +72,7 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Response Interface

"! eDoc response interface "! $required - response_interface TYPE c LENGTH 30, + response_interface TYPE c LENGTH 30, "!

Response Interface Version

"! Response interface version "! $required From 47369f39db662267bb74800fe8ae73c714f54719 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Fri, 14 Mar 2025 13:57:44 +0100 Subject: [PATCH 11/16] corrections --- file-formats/edoi/edoi-v1.json | 8 ++++---- file-formats/edoi/type/zif_aff_edoi_v1.intf.abap | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 0858a53bb..896254d26 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -71,9 +71,9 @@ "interfaceDirection" ] }, - "interfaceVersion": { - "title": "Interface Version", - "description": "Interface version", + "interfaceVersions": { + "title": "Interface Versions", + "description": "Interface versions", "type": "array", "uniqueItems": true, "items": { @@ -174,7 +174,7 @@ "formatVersion", "header", "generalInformation", - "interfaceVersion", + "interfaceVersions", "drcAttributes" ] } diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 3926ab726..e8cfecefe 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -102,10 +102,10 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "! General information "! $required general_information TYPE ty_general_information, - "!

Interface Version

- "! Interface version + "!

Interface Versions

+ "! Interface versions "! $required - interface_version TYPE ty_interface_versions, + interface_versions TYPE ty_interface_versions, "!

Attribute Determination for Communication with Cloud Edition

"! Attribute determination for communication with cloud edition "! $required From 3a1ecf447094476011c99c2ea2cb018dd56cad5f Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 18 Mar 2025 10:38:40 +0100 Subject: [PATCH 12/16] correction --- file-formats/edoi/edoi-v1.json | 12 +++++----- .../edoi/type/zif_aff_edoi_v1.intf.abap | 24 +++++++++---------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 896254d26..1a15c411e 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -109,14 +109,14 @@ ] } }, - "drcAttributes": { - "title": "Attribute Determination for Communication with Cloud Edition", - "description": "Attribute determination for communication with cloud edition", + "communicationAttributes": { + "title": "Communication Integration Attributes", + "description": "Communication integration attributes", "type": "array", "uniqueItems": true, "items": { - "title": "Attribute Determination for Communication with Cloud Edition", - "description": "Attribute determination for communication with cloud edition", + "title": "Communication Integration Attributes", + "description": "Communication integration attributes", "type": "object", "properties": { "processType": { @@ -175,6 +175,6 @@ "header", "generalInformation", "interfaceVersions", - "drcAttributes" + "communicationAttributes" ] } diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index e8cfecefe..ac459abd4 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -50,9 +50,9 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "! Interface versions TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY version. TYPES: - "!

Attribute Determination for Communication with Cloud Edition

- "! Attribute determination for communication with cloud edition - BEGIN OF ty_drc_attribute, + "!

Communication Integration Attributes

+ "! Communication integration attributes + BEGIN OF ty_communication_attribute, "!

Process Type

"! DRC process type "! $required @@ -80,10 +80,10 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "! $maximum 9999 response_interface_version TYPE i, - END OF ty_drc_attribute. + END OF ty_communication_attribute. "!

Interface Versions

"! eDocument interface versions - TYPES ty_drc_attributes TYPE SORTED TABLE OF ty_drc_attribute WITH UNIQUE KEY process_type. + TYPES ty_communication_attributes TYPE SORTED TABLE OF ty_communication_attribute WITH UNIQUE KEY process_type. TYPES: @@ -93,23 +93,23 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Format Version

"! Format version "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_100_cloud, + header TYPE zif_aff_types_v1=>ty_header_100_cloud, "!

General Information

"! General information "! $required - general_information TYPE ty_general_information, + general_information TYPE ty_general_information, "!

Interface Versions

"! Interface versions "! $required - interface_versions TYPE ty_interface_versions, - "!

Attribute Determination for Communication with Cloud Edition

- "! Attribute determination for communication with cloud edition + interface_versions TYPE ty_interface_versions, + "!

Communication Integration Attributes

+ "! Communication integration attributes "! $required - drc_attributes TYPE ty_drc_attributes, + communication_attributes TYPE ty_communication_attributes, END OF ty_main. From c7e09f255415f84936679f5dee2c8429fe551047 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 8 Jul 2025 10:34:34 +0200 Subject: [PATCH 13/16] changes with example --- file-formats/edoi/edoi-v1.json | 124 +++++++++--------- .../examples/fr_invoice_edoi_example.json | 25 ++++ .../edoi/type/zif_aff_edoi_v1.intf.abap | 75 +++++------ 3 files changed, 121 insertions(+), 103 deletions(-) create mode 100644 file-formats/edoi/examples/fr_invoice_edoi_example.json diff --git a/file-formats/edoi/edoi-v1.json b/file-formats/edoi/edoi-v1.json index 1a15c411e..8d4c0e8bb 100644 --- a/file-formats/edoi/edoi-v1.json +++ b/file-formats/edoi/edoi-v1.json @@ -63,7 +63,19 @@ "title": "Interface Direction", "description": "Interface direction", "type": "string", - "maxLength": 1 + "enum": [ + "outbound", + "inbound" + ], + "enumTitles": [ + "Outbound", + "Inbound" + ], + "enumDescriptions": [ + "Outbound", + "Inbound" + ], + "default": "outbound" } }, "additionalProperties": false, @@ -99,72 +111,59 @@ "description": "Active from", "type": "string", "format": "date-time" + }, + "communicationAttribute": { + "title": "Communication Integration Attributes", + "description": "Communication integration attributes", + "type": "object", + "properties": { + "processType": { + "title": "Process Type", + "description": "DRC process type", + "type": "string", + "maxLength": 50 + }, + "processVersion": { + "title": "Process Version", + "description": "DRC process version", + "type": "string", + "maxLength": 20 + }, + "processSubtype": { + "title": "Process Subtype", + "description": "DRC process subtype", + "type": "string", + "maxLength": 50 + }, + "drcAction": { + "title": "Action", + "description": "DRC process action", + "type": "string", + "maxLength": 30 + }, + "responseInterface": { + "title": "Response Interface", + "description": "eDoc response interface", + "type": "string", + "maxLength": 30 + }, + "responseInterfaceVersion": { + "title": "Response Interface Version", + "description": "Response interface version", + "type": "integer", + "minimum": 1, + "maximum": 9999 + } + }, + "additionalProperties": false } }, "additionalProperties": false, "required": [ "version", "description", - "activeFrom" - ] - } - }, - "communicationAttributes": { - "title": "Communication Integration Attributes", - "description": "Communication integration attributes", - "type": "array", - "uniqueItems": true, - "items": { - "title": "Communication Integration Attributes", - "description": "Communication integration attributes", - "type": "object", - "properties": { - "processType": { - "title": "Process Type", - "description": "DRC process type", - "type": "string", - "maxLength": 50 - }, - "processVersion": { - "title": "Process Version", - "description": "DRC process version", - "type": "string", - "maxLength": 20 - }, - "processSubtype": { - "title": "Process Subtype", - "description": "DRC process subtype", - "type": "string", - "maxLength": 50 - }, - "drcAction": { - "title": "Action", - "description": "DRC process action", - "type": "string", - "maxLength": 30 - }, - "responseInterface": { - "title": "Response Interface", - "description": "eDoc response interface", - "type": "string", - "maxLength": 30 - }, - "responseInterfaceVersion": { - "title": "Response Interface Version", - "description": "Response interface version", - "type": "integer", - "minimum": 1, - "maximum": 9999 - } - }, - "additionalProperties": false, - "required": [ - "processType", - "processVersion", - "processSubtype", - "drcAction", - "responseInterface", - "responseInterfaceVersion" + "activeFrom", + "communicationAttribute" ] } } @@ -174,7 +173,6 @@ "formatVersion", "header", "generalInformation", - "interfaceVersions", - "communicationAttributes" + "interfaceVersions" ] } diff --git a/file-formats/edoi/examples/fr_invoice_edoi_example.json b/file-formats/edoi/examples/fr_invoice_edoi_example.json new file mode 100644 index 000000000..d85b80f00 --- /dev/null +++ b/file-formats/edoi/examples/fr_invoice_edoi_example.json @@ -0,0 +1,25 @@ +{ + "formatVersion": "1", + "header": { + "description": "France: Customer Invoice Request", + "originalLanguage": "en" + }, + "generalInformation": { + "interfaceDirection": "outbound" + }, + "interfaceVersions": [ + { + "version": 1, + "description": "Initial Version", + "activeFrom": "01.01.2025", + "communicationAttribute": { + "processType": "CUSTOMER_INVOICE", + "processVersion": "1.0.0", + "processSubtype": "DOMESTIC", + "drcAction": "TRANSMIT", + "responseInterface": "INVOICER", + "responseInterfaceVersion": 1 + } + } + ] +} \ No newline at end of file diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index ac459abd4..123c7a35c 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -2,8 +2,8 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Interface Direction

"! Interface direction - "! $values {@link zif_aff_edoi_v1.data:co_edoc_int_direction} - "! $default {@link zif_aff_edoi_v1.data:co_edoc_int_direction.outbound} + "! $values {@link zif_aff_edoi_v1.data:co_interface_direction} + "! $default {@link zif_aff_edoi_v1.data:co_interface_direction.outbound} TYPES ty_interface_direction TYPE c LENGTH 1. CONSTANTS: "!

Interface Direction

@@ -27,65 +27,64 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. interface_direction TYPE ty_interface_direction, END OF ty_general_information. - TYPES: - "!

Interface Version

- "! eDocument interface version - BEGIN OF ty_interface_version, - "!

Version

- "! Version - "! $required - "! $minimum 1 - "! $maximum 9999 - version TYPE i, - "!

Description

- "! Description - "! $required - description TYPE c LENGTH 30, - "!

Active From

- "! Active from - "! $required - active_from TYPE sy-datum, - END OF ty_interface_version. - "!

Interface Versions

- "! Interface versions - TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY version. TYPES: "!

Communication Integration Attributes

"! Communication integration attributes BEGIN OF ty_communication_attribute, "!

Process Type

"! DRC process type - "! $required process_type TYPE c LENGTH 50, "!

Process Version

"! DRC process version - "! $required process_version TYPE c LENGTH 20, "!

Process Subtype

"! DRC process subtype - "! $required process_subtype TYPE c LENGTH 50, "!

Action

"! DRC process action - "! $required drc_action TYPE c LENGTH 30, "!

Response Interface

"! eDoc response interface - "! $required response_interface TYPE c LENGTH 30, "!

Response Interface Version

"! Response interface version - "! $required "! $minimum 1 "! $maximum 9999 response_interface_version TYPE i, - END OF ty_communication_attribute. + + TYPES: + "!

Interface Version

+ "! eDocument interface version + BEGIN OF ty_interface_version, + "!

Version

+ "! Version + "! $required + "! $minimum 1 + "! $maximum 9999 + version TYPE i, + "!

Description

+ "! Description + "! $required + description TYPE c LENGTH 30, + "!

Active From

+ "! Active from + "! $required + active_from TYPE sy-datum, + "!

Communication Integration Attributes

+ "! Communication integration attributes + "! $required + communication_attribute TYPE ty_communication_attribute, + END OF ty_interface_version. + + "!

Interface Versions

+ "! Interface versions + TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY version. + "!

Interface Versions

"! eDocument interface versions TYPES ty_communication_attributes TYPE SORTED TABLE OF ty_communication_attribute WITH UNIQUE KEY process_type. - TYPES: "!

eDocument Interface

"! eDocument interface @@ -93,23 +92,19 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "!

Format Version

"! Format version "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_100_cloud, + header TYPE zif_aff_types_v1=>ty_header_100_cloud, "!

General Information

"! General information "! $required - general_information TYPE ty_general_information, + general_information TYPE ty_general_information, "!

Interface Versions

"! Interface versions "! $required - interface_versions TYPE ty_interface_versions, - "!

Communication Integration Attributes

- "! Communication integration attributes - "! $required - communication_attributes TYPE ty_communication_attributes, + interface_versions TYPE ty_interface_versions, END OF ty_main. From a76b5ff42d11571309056f5c2ef6ca97e1f34ac4 Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 8 Jul 2025 10:53:14 +0200 Subject: [PATCH 14/16] changes with example --- .../edoi/examples/fr_invoice_edoi_example.json | 13 +++++++++++++ file-formats/edoi/type/zif_aff_edoi_v1.intf.abap | 4 ---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/file-formats/edoi/examples/fr_invoice_edoi_example.json b/file-formats/edoi/examples/fr_invoice_edoi_example.json index d85b80f00..fe7b4f7f0 100644 --- a/file-formats/edoi/examples/fr_invoice_edoi_example.json +++ b/file-formats/edoi/examples/fr_invoice_edoi_example.json @@ -20,6 +20,19 @@ "responseInterface": "INVOICER", "responseInterfaceVersion": 1 } + }, + { + "version": 2, + "description": "Version 2", + "activeFrom": "01.07.2025", + "communicationAttribute": { + "processType": "CUSTOMER_INVOICE", + "processVersion": "1.1.0", + "processSubtype": "DOMESTIC", + "drcAction": "TRANSMIT", + "responseInterface": "INVOICER", + "responseInterfaceVersion": 2 + } } ] } \ No newline at end of file diff --git a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap index 123c7a35c..2c5ba24bf 100644 --- a/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap +++ b/file-formats/edoi/type/zif_aff_edoi_v1.intf.abap @@ -81,10 +81,6 @@ INTERFACE zif_aff_edoi_v1 PUBLIC. "! Interface versions TYPES ty_interface_versions TYPE SORTED TABLE OF ty_interface_version WITH UNIQUE KEY version. - "!

Interface Versions

- "! eDocument interface versions - TYPES ty_communication_attributes TYPE SORTED TABLE OF ty_communication_attribute WITH UNIQUE KEY process_type. - TYPES: "!

eDocument Interface

"! eDocument interface From c6add983a5964443378b552ff2618bb6c35464eb Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 8 Jul 2025 10:59:47 +0200 Subject: [PATCH 15/16] changes with example --- ...fr_invoice_edoi_example.json => fr_invoice_edoi.edoi.json} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename file-formats/edoi/examples/{fr_invoice_edoi_example.json => fr_invoice_edoi.edoi.json} (98%) diff --git a/file-formats/edoi/examples/fr_invoice_edoi_example.json b/file-formats/edoi/examples/fr_invoice_edoi.edoi.json similarity index 98% rename from file-formats/edoi/examples/fr_invoice_edoi_example.json rename to file-formats/edoi/examples/fr_invoice_edoi.edoi.json index fe7b4f7f0..80ce6a391 100644 --- a/file-formats/edoi/examples/fr_invoice_edoi_example.json +++ b/file-formats/edoi/examples/fr_invoice_edoi.edoi.json @@ -32,7 +32,7 @@ "drcAction": "TRANSMIT", "responseInterface": "INVOICER", "responseInterfaceVersion": 2 - } + } } ] -} \ No newline at end of file +} From 39bee5a08bbd25dc075970f34b0bbabcd54a6a1b Mon Sep 17 00:00:00 2001 From: i506210 <158033259+i506210@users.noreply.github.com> Date: Tue, 8 Jul 2025 11:01:13 +0200 Subject: [PATCH 16/16] changes with example --- file-formats/edoi/examples/fr_invoice_edoi.edoi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/edoi/examples/fr_invoice_edoi.edoi.json b/file-formats/edoi/examples/fr_invoice_edoi.edoi.json index 80ce6a391..0d33ba414 100644 --- a/file-formats/edoi/examples/fr_invoice_edoi.edoi.json +++ b/file-formats/edoi/examples/fr_invoice_edoi.edoi.json @@ -32,7 +32,7 @@ "drcAction": "TRANSMIT", "responseInterface": "INVOICER", "responseInterfaceVersion": 2 - } + } } ] }