forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.Someone is actively working on this. Should link to a PR soon.enhancementNew feature or requestNew feature or request
Description
App Version
3.11.14
API Provider
OpenRouter
Model Used
claude-3.7-sonner:beta
Actual vs. Expected Behavior
Actual
- The existing display for step 1 (none checked, none unchecked) is confusing; the checked checkbox can relay the possibility that it's no longer none
- When Auto-approve is unchecked (but displays selections like Read, Edit, etc..) that's potentially misleading, and may relay the auto-approve selections are being applied.
Expected
Proposed solution:
- When unchecked, always display "None". This clearly indicates no choices are auto-approved
- When checked, there should be at least one auto-approved option selected. "None" cannot be displayed while the checkbox is checked
other scenarios - If no selections have been made in the settings; the checkbox is disabled and cannot be checked (user must make some selections).
- When the Auto-approve menu is open in the options, the top checkbox is disabled; selections can only be made on the options below.
- Top checkbox is disabled (read-only) while the menu is open. Behaves similar to existing; but the checkbox status changes dynamically depending on whether 0 or >1 checkboxes below are checked
- Apply this logic to the main settings for Auto-approve as well
- After collapsing the panel with at least one selection (i.e. "Read, Edit"), then the checkbox remains checked , and displays "Read, Edit" selections
- The checkbox in the collapsed state is enabled now. This can only toggle between two states
8a) Auto-approve: Read, Edit
8b) Auto-approve: None - If the user opens the auto-approve settings again, and de-selects all options, this will display "None" again, and disabled the checkbox in both expanded and collapsed state.
The idea here is : You can't display both a checked checkbox with None (confusing)
And you can't have an unchecked checkbox with values (Read, Edit,) displayed (also confusing)
Detailed Steps to Reproduce
- Check and uncheck the Auto-approve checkbox while "none" is selected
- Open the Auto-approve popup and select a few options (read, edit, etc..)
- Collapse the Auto-approve segment again, then check and uncheck the checkbox again
Relevant API Request Output
Additional Context
A toggle option might be worth considering here too. If we can visually discern between enabled and disabled checkbox, that's a nice to have
dosubottianyan-zhu
Metadata
Metadata
Assignees
Labels
Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.Someone is actively working on this. Should link to a PR soon.enhancementNew feature or requestNew feature or request
Type
Projects
Status
Done