Skip to content

Redesign Auto-approve; don't allow confusing checkbox status with labels #2579

@Mustachio77

Description

@Mustachio77

App Version

3.11.14

API Provider

OpenRouter

Model Used

claude-3.7-sonner:beta

Actual vs. Expected Behavior

Actual

  1. The existing display for step 1 (none checked, none unchecked) is confusing; the checked checkbox can relay the possibility that it's no longer none
  2. When Auto-approve is unchecked (but displays selections like Read, Edit, etc..) that's potentially misleading, and may relay the auto-approve selections are being applied.
    Image

Expected
Proposed solution:

  1. When unchecked, always display "None". This clearly indicates no choices are auto-approved
  2. When checked, there should be at least one auto-approved option selected. "None" cannot be displayed while the checkbox is checked
    other scenarios
  3. If no selections have been made in the settings; the checkbox is disabled and cannot be checked (user must make some selections).
  4. When the Auto-approve menu is open in the options, the top checkbox is disabled; selections can only be made on the options below.
  5. Top checkbox is disabled (read-only) while the menu is open. Behaves similar to existing; but the checkbox status changes dynamically depending on whether 0 or >1 checkboxes below are checked
  6. Apply this logic to the main settings for Auto-approve as well
  7. After collapsing the panel with at least one selection (i.e. "Read, Edit"), then the checkbox remains checked , and displays "Read, Edit" selections
  8. The checkbox in the collapsed state is enabled now. This can only toggle between two states
    8a) Auto-approve: Read, Edit
    8b) Auto-approve: None
  9. If the user opens the auto-approve settings again, and de-selects all options, this will display "None" again, and disabled the checkbox in both expanded and collapsed state.

The idea here is : You can't display both a checked checkbox with None (confusing)
And you can't have an unchecked checkbox with values (Read, Edit,) displayed (also confusing)

Image

Detailed Steps to Reproduce

  1. Check and uncheck the Auto-approve checkbox while "none" is selected
  2. Open the Auto-approve popup and select a few options (read, edit, etc..)
  3. Collapse the Auto-approve segment again, then check and uncheck the checkbox again

Relevant API Request Output

Additional Context

A toggle option might be worth considering here too. If we can visually discern between enabled and disabled checkbox, that's a nice to have

Image

Metadata

Metadata

Assignees

Labels

Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.enhancementNew feature or request

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions