Skip to content

Commit 93dc9ee

Browse files
bharat-pRichardKnop
authored andcommitted
Delete SQS message if unmarshalling fails (#504)
* Delete SQS message if unmarshalling fails * Fix failing unit test
1 parent 7a7f434 commit 93dc9ee

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

v1/brokers/sqs/sqs.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,10 @@ func (b *Broker) consumeOne(delivery *awssqs.ReceiveMessageOutput, taskProcessor
205205
decoder.UseNumber()
206206
if err := decoder.Decode(sig); err != nil {
207207
log.ERROR.Printf("unmarshal error. the delivery is %v", delivery)
208+
// if the unmarshal fails, remove the delivery from the queue
209+
if delErr := b.deleteOne(delivery); delErr != nil {
210+
log.ERROR.Printf("error when deleting the delivery. delivery is %v, Error=%s", delivery, delErr)
211+
}
208212
return err
209213
}
210214
if delivery.Messages[0].ReceiptHandle != nil {

0 commit comments

Comments
 (0)