Skip to content

Commit a911d00

Browse files
d-nettogiordano
andauthored
[Dates] Make test more robust against non-UTC timezones (JuliaLang#55829) (#184)
`%M` is the format specifier for the minutes, not the month (which should be `%m`), and it was used twice. Also, on macOS `Libc.strptime` internally calls `mktime` which depends on the local timezone. We now temporarily set `TZ=UTC` to avoid depending on the local timezone. Fix JuliaLang#55827. Co-authored-by: Mosè Giordano <[email protected]>
1 parent c690603 commit a911d00

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

stdlib/Dates/test/types.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,11 @@ end
256256
end
257257

258258
@testset "issue #31524" begin
259-
dt1 = Libc.strptime("%Y-%M-%dT%H:%M:%SZ", "2018-11-16T10:26:14Z")
259+
# Ensure the result doesn't depend on local timezone, especially on macOS
260+
# where an extra internal call to `mktime` is affected by timezone settings.
261+
dt1 = withenv("TZ" => "UTC") do
262+
Libc.strptime("%Y-%m-%dT%H:%M:%SZ", "2018-11-16T10:26:14Z")
263+
end
260264
dt2 = Libc.TmStruct(14, 30, 5, 10, 1, 99, 3, 40, 0)
261265

262266
time = Time(dt1)

0 commit comments

Comments
 (0)