-
Notifications
You must be signed in to change notification settings - Fork 146
Insertion-filter for close samples #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1543 +/- ##
==========================================
+ Coverage 88.99% 89.15% +0.15%
==========================================
Files 35 35
Lines 5836 5899 +63
==========================================
+ Hits 5194 5259 +65
+ Misses 642 640 -2 ☔ View full report in Codecov by Sentry. |
ed64911
to
12c11a8
Compare
LiorKogan
reviewed
Dec 5, 2023
3 tasks
YaacovHazan
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://redislabs.atlassian.net/browse/PM-1996
Insertion filter support
Many sensors report data periodically. Often, the difference between the measured value and the previous measured value is negligible and related to random noise or to measurement accuracy limitations. In such situations it may be preferable not to add the new measurement to the time series. This PR introduces new configuration parameters to the keys to ignore the current sample if the above scenario occurs.
Implementation:
New module configuration arguments:
Defined two new per-key parameters:
These are arguments to key configuration parameters:
Optional argument can be passed to
IGNORE …
is used when creating a new time series to set the per-key parameters and is ignored otherwise(the existing per-key configuration parameters is used).For each call to TS.ADD, if the following condition is met:
then sample is ignored. When a sample is ignored, the return value for TS.ADD and for the applicable array element in TS.MADD is max_timestamp of the key.
Additional changes
TS.INFO
output.Minor unrelated change