Skip to content

Commit 49c5284

Browse files
authored
Merge pull request #282 from alexott/spark3
Update code to use Spark 3.0 & Scala 2.12
2 parents 1a30f4e + b57c2b2 commit 49c5284

File tree

8 files changed

+17
-22
lines changed

8 files changed

+17
-22
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ The master branch contains the recent development for the next release.
2222

2323
| Spark-Redis | Spark | Redis | Supported Scala Versions |
2424
| ----------------------------------------------------------------| ------------- | ---------------- | ------------------------ |
25+
| [master](https://github.com/RedisLabs/spark-redis/) | 3.0.x | >=2.9.0 | 2.12 |
2526
| [2.4, 2.5, 2.6](https://github.com/RedisLabs/spark-redis/tree/branch-2.4) | 2.4.x | >=2.9.0 | 2.11, 2.12 |
2627
| [2.3](https://github.com/RedisLabs/spark-redis/tree/branch-2.3) | 2.3.x | >=2.9.0 | 2.11 |
2728
| [1.4](https://github.com/RedisLabs/spark-redis/tree/branch-1.4) | 1.4.x | | 2.10 |

dev/change-scala-version.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22

33
set -e
44

5-
VALID_VERSIONS=( 2.11 2.12 )
5+
VALID_VERSIONS=( 2.12 )
66

7-
SCALA_211_MINOR_VERSION="12"
8-
SCALA_212_MINOR_VERSION="9"
7+
SCALA_212_MINOR_VERSION="12"
98

109
usage() {
1110
echo "Usage: $(basename $0) [-h|--help] <version>

doc/dev.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,3 @@ To build Spark-Redis skipping tests, run:
2626
mvn clean package -DskipTests
2727
```
2828

29-
To change scala version use `./dev/change-scala-version.sh` script. It will change scala version in `pom.xml`. For example:
30-
```
31-
./dev/change-scala-version.sh 2.12
32-
```
33-
34-
```
35-
./dev/change-scala-version.sh 2.11
36-
```

pom.xml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.redislabs</groupId>
5-
<artifactId>spark-redis_2.11</artifactId>
6-
<version>2.6.0-SNAPSHOT</version>
5+
<artifactId>spark-redis_2.12</artifactId>
6+
<version>3.0.0-SNAPSHOT</version>
77
<name>Spark-Redis</name>
88
<description>A Spark library for Redis</description>
99
<url>http://github.com/RedisLabs/spark-redis</url>
@@ -47,10 +47,10 @@
4747
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
4848
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
4949
<java.version>1.8</java.version>
50-
<scala.major.version>2.11</scala.major.version>
50+
<scala.major.version>2.12</scala.major.version>
5151
<scala.complete.version>${scala.major.version}.12</scala.complete.version>
52-
<jedis.version>3.2.0</jedis.version>
53-
<spark.version>2.4.1</spark.version>
52+
<jedis.version>3.4.1</jedis.version>
53+
<spark.version>3.0.1</spark.version>
5454
<plugins.scalatest.version>1.0</plugins.scalatest.version>
5555
</properties>
5656

@@ -89,7 +89,7 @@
8989
<plugin>
9090
<groupId>net.alchim31.maven</groupId>
9191
<artifactId>scala-maven-plugin</artifactId>
92-
<version>3.2.2</version>
92+
<version>3.4.6</version>
9393
<configuration>
9494
<scalaVersion>${scala.complete.version}</scalaVersion>
9595
<javacArgs>
@@ -287,16 +287,19 @@
287287
<groupId>org.scala-lang</groupId>
288288
<artifactId>scala-library</artifactId>
289289
<version>${scala.complete.version}</version>
290+
<scope>provided</scope>
290291
</dependency>
291292
<dependency>
292293
<groupId>org.scala-lang</groupId>
293294
<artifactId>scalap</artifactId>
294295
<version>${scala.complete.version}</version>
296+
<scope>provided</scope>
295297
</dependency>
296298
<dependency>
297299
<groupId>org.scala-lang</groupId>
298300
<artifactId>scala-compiler</artifactId>
299301
<version>${scala.complete.version}</version>
302+
<scope>provided</scope>
300303
</dependency>
301304
<dependency>
302305
<groupId>org.apache.spark</groupId>

src/main/scala/com/redislabs/provider/redis/streaming/RedisStreamReceiver.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
package com.redislabs.provider.redis.streaming
22

33
import java.util.AbstractMap.SimpleEntry
4-
54
import com.redislabs.provider.redis.util.PipelineUtils.foreachWithPipeline
65
import com.redislabs.provider.redis.util.{Logging, StreamUtils}
76
import com.redislabs.provider.redis.{ReadWriteConfig, RedisConfig}
87
import org.apache.curator.utils.ThreadUtils
98
import org.apache.spark.storage.StorageLevel
109
import org.apache.spark.streaming.receiver.Receiver
11-
import org.spark_project.guava.util.concurrent.RateLimiter
12-
import redis.clients.jedis.{StreamEntryID, Jedis, StreamEntry}
10+
import org.sparkproject.guava.util.concurrent.RateLimiter
11+
import redis.clients.jedis.{Jedis, StreamEntry, StreamEntryID}
1312

1413
import scala.collection.JavaConversions._
1514

src/main/scala/org/apache/spark/sql/redis/stream/RedisSource.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import com.redislabs.provider.redis.RedisConfig
44
import com.redislabs.provider.redis.util.CollectionUtils.RichCollection
55
import com.redislabs.provider.redis.util.ConnectionUtils.{JedisExt, XINFO, withConnection}
66
import com.redislabs.provider.redis.util.StreamUtils.{createConsumerGroupIfNotExist, resetConsumerGroup}
7-
import com.redislabs.provider.redis.util.{ConnectionUtils, Logging, ParseUtils}
7+
import com.redislabs.provider.redis.util.{Logging, ParseUtils}
88
import org.apache.spark.sql.catalyst.InternalRow
99
import org.apache.spark.sql.execution.streaming.{Offset, Source}
1010
import org.apache.spark.sql.redis.stream.RedisSource._

src/test/scala/com/redislabs/provider/redis/env/RedisStandaloneEnv.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ trait RedisStandaloneEnv extends Env {
1414
.set("spark.redis.port", s"$redisPort")
1515
.set("spark.redis.auth", redisAuth)
1616
.set("spark.streaming.stopGracefullyOnShutdown", "true")
17+
.set("spark.sql.streaming.forceDeleteTempCheckpointLocation", "true")
1718
.set("spark.driver.bindAddress", "127.0.0.1")
1819

1920
override val redisConfig: RedisConfig =

src/test/scala/org/apache/spark/sql/redis/stream/RedisStreamSourceSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ trait RedisStreamSourceSuite extends FunSuite with Matchers with Env with Loggin
228228

229229
val (spark, query) = readStream2(streamKey, extraReadOptions, extraWriteOptions, writeFormat)
230230
// give some time for spark query to start
231-
Thread.sleep(50)
231+
Thread.sleep(2000)
232232
try {
233233
body(spark)
234234
} finally {

0 commit comments

Comments
 (0)