Move for-each into synchronized block.

Author: Klemen Kresnik

src/main/java/rx/subscriptions/CompositeSubscription.java

@@ -85,26 +85,24 @@ public void add(final Subscription s) {
      *         the collection of {@link Subscription} to add
      */
     public void addAll(final Subscription... subscriptions) {
-        List<Subscription> subscriptionList = new ArrayList<Subscription>(4);
-        for (Subscription s : subscriptions) {
-            if (!s.isUnsubscribed()) {
-                subscriptionList.add(s);
-            }
-        }
-
         if (!unsubscribed) {
             synchronized (this) {
                 if (!unsubscribed) {
                     if (this.subscriptions == null) {
                         this.subscriptions = new HashSet<Subscription>(4);
                     }
-                    this.subscriptions.addAll(subscriptionList);
+
+                    for (Subscription s : subscriptions) {
+                        if (!s.isUnsubscribed()) {
+                            this.subscriptions.add(s);
+                        }
+                    }
                     return;
                 }
             }
         }
 
-        for (Subscription s : subscriptionList) {
+        for (Subscription s : subscriptions) {
             s.unsubscribe();
         }
     }