Skip to content

Commit 2dd4275

Browse files
authored
[rocprofiler-sdk] Relax timing tolerance in callback_registration_lambda_with_result test from 25% to 35% (#4587)
## Motivation Random failures observed in CI environments: https://github.com/ROCm/rocm-systems/actions/runs/23772167349/job/69265926641?pr=4272 ## Technical Details This PR updates the elapsed time tolerance in the rocprofiler_lib.callback_registration_lambda_with_result test from 25% to 35%. The test compares: - wall-clock time measured around hsa_iterate_agents(...) - elapsed time accumulated via rocprofiler callback instrumentation Due to the nature of this comparison, both measurements are not strictly equivalent and can diverge because of: - system noise (CPU scheduling, contention in CI) ## JIRA ID <!-- If applicable, mention the JIRA ID resolved by this PR (Example: Resolves SWDEV-12345). --> <!-- Do not post any JIRA links here. --> ## Test Plan - CI test ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 parent 5899c98 commit 2dd4275

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/tests/registration.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ TEST(rocprofiler_lib, callback_registration_lambda_with_result)
345345
EXPECT_GT(cb_data.client_elapsed, 0);
346346
EXPECT_GT(elapsed, 0);
347347
#else
348-
decltype(elapsed) elapsed_tolerance = 0.25 * elapsed;
348+
decltype(elapsed) elapsed_tolerance = 0.35 * elapsed;
349349
int64_t diff = (cb_data.client_elapsed - elapsed);
350350
auto frac = std::abs(diff) / (1.0 * elapsed);
351351
EXPECT_NEAR(elapsed, cb_data.client_elapsed, elapsed_tolerance)

0 commit comments

Comments
 (0)