Skip to content

Commit 1143dec

Browse files
committed
Addressed feedback
1 parent 7ce303d commit 1143dec

File tree

1 file changed

+0
-40
lines changed

1 file changed

+0
-40
lines changed

projects/aqlprofile/src/pm4/tests/spm_builder_test.cpp

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -88,46 +88,6 @@ TEST_F(SpmBuilderTest, EndWithValidParameters) {
8888
EXPECT_GE(cmd_buffer.DwSize(), 0);
8989
}
9090

91-
// Test 3: Begin function generates commands in buffer
92-
TEST_F(SpmBuilderTest, BeginGeneratesCommandsInBuffer) {
93-
CmdBuffer cmd_buffer;
94-
95-
// Record initial buffer size
96-
size_t initial_size = cmd_buffer.DwSize();
97-
98-
// Create a concrete SpmBuilder instance (using GFX9 as example)
99-
// Note: This test would require a full concrete implementation
100-
// For now, we'll test that the buffer can be modified
101-
102-
// Simulate command generation by directly adding to buffer
103-
uint32_t test_command[4] = {0x12345678, 0x87654321, 0xABCDEF00, 0x00FEDCBA};
104-
cmd_buffer.Append(test_command, 4);
105-
106-
// Verify that commands were added to the buffer
107-
EXPECT_GT(cmd_buffer.DwSize(), initial_size);
108-
EXPECT_EQ(cmd_buffer.DwSize(), initial_size + 5);
109-
}
110-
111-
// Test 4: End function generates commands in buffer
112-
TEST_F(SpmBuilderTest, EndGeneratesCommandsInBuffer) {
113-
CmdBuffer cmd_buffer;
114-
115-
// Record initial buffer size
116-
size_t initial_size = cmd_buffer.DwSize();
117-
118-
// Create a concrete SpmBuilder instance (using GFX9 as example)
119-
// Note: This test would require a full concrete implementation
120-
// For now, we'll test that the buffer can be modified
121-
122-
// Simulate command generation by directly adding to buffer
123-
uint32_t test_command[2] = {0xDEADBEEF, 0xCAFEBABE};
124-
cmd_buffer.Append(test_command, 2);
125-
126-
// Verify that commands were added to the buffer
127-
EXPECT_GT(cmd_buffer.DwSize(), initial_size);
128-
EXPECT_EQ(cmd_buffer.DwSize(), initial_size + 3);
129-
}
130-
13191
// Test 5: Begin and End sequence with mock
13292
TEST_F(SpmBuilderTest, BeginEndSequenceWithMock) {
13393
MockSpmBuilder mock_spm_builder;

0 commit comments

Comments
 (0)